| 12:41.05 | *** join/#arl Ressy (Ressy@192-0-172-185.cpe.teksavvy.com) |
| 12:41.05 | *** join/#arl Ressy (Ressy@WoWUIDev/WoWAce/ARL/Ressy) |
| 12:41.05 | *** mode/#arl [+v Ressy] by ChanServ |
| 12:53.12 | Ressy | Question Torhal.. That AddLocation... |
| 12:53.23 | Ressy | Did you not add that? |
| 12:54.09 | Ressy | Because you've automatically made all pets with AddZoneLocation as a pet battle. |
| 12:54.23 | Ressy | which doesn't work. |
| 13:04.54 | Ressy | I think the best way to check would be checking if the level is set to nil |
| 14:03.44 | Torhal | Ressy: Huh? |
| 14:03.52 | Ressy | soo... |
| 14:03.55 | Ressy | AddZoneLocations. |
| 14:03.58 | Torhal | It does work that way. |
| 14:04.02 | Ressy | nope. |
| 14:04.10 | Torhal | Set levelRange and isSecondary is nil. |
| 14:04.14 | Ressy | yes. |
| 14:04.15 | Ressy | I did. |
| 14:04.21 | Ressy | its still showing pet battle. |
| 14:04.23 | Torhal | But yeah, pet_battle will always be for pets. |
| 14:04.41 | Torhal | There is a case where the pet just sits somewhere? |
| 14:04.43 | Ressy | yup |
| 14:04.50 | Torhal | Fuck. |
| 14:04.51 | Ressy | Looting from nests |
| 14:04.55 | Torhal | You didn't tell me that :D |
| 14:05.02 | Ressy | Loot egg, get pet. learn |
| 14:05.03 | Ressy | :D |
| 14:05.18 | Ressy | Leaping Hatchling for example |
| 14:05.25 | Torhal | Ok, easy fix. |
| 14:05.42 | Ressy | and Azure Crane Chick. :D |
| 14:05.58 | Ressy | Theres more nests I'm adding. |
| 14:06.04 | Ressy | but those are the ones I've run into already |
| 14:06.14 | Ressy | going through the Custom.lua page righ tnow |
| 14:06.49 | Torhal | Actually. |
| 14:07.08 | Ressy | ? |
| 14:08.43 | Torhal | The least messy way is to replace isSecondary with locationType |
| 14:09.15 | Ressy | ok... |
| 14:09.33 | Torhal | isSecondary is only ever used when no coords are supplied, and I can just do that automatically if no coords are supplied, and in its place we would put "zoneLocation" or "petBattle" |
| 14:09.41 | Torhal | or "worldDrop" |
| 14:10.06 | Ressy | isSecondary is either true or false usually.. |
| 14:10.09 | Torhal | Yes |
| 14:10.18 | Torhal | And it's never true when coords are supplied. |
| 14:10.25 | Ressy | right |
| 14:10.26 | Torhal | So just set it to tru when coords aren't. |
| 14:10.29 | Torhal | true* |
| 14:11.14 | Ressy | I don't get it.. |
| 14:11.35 | Torhal | I'm saying it's an unnecessary parameter. |
| 14:12.03 | Torhal | If we have coords, it's true. If we don't, it's false. Always. So we can infer its value instead of explicitly setting it. |
| 14:12.04 | Ressy | You'd have to check level to choose between pet battle or just zone location. |
| 14:12.33 | Ressy | cuz pet battles have coords |
| 14:12.35 | Torhal | No, because we could add other types later - better to pass it in as a parameter. |
| 14:12.58 | Torhal | So if it has coords and you don't want it to be a pet battle, you say so. |
| 14:13.04 | Torhal | Instead of trying to magically figure it out. |
| 14:13.12 | Ressy | and how will I do that. |
| 14:13.15 | Torhal | Especially |
| 14:13.39 | Torhal | I just said: Replace isSecondary with label. Or type. Or whatever I name it that makes sense. |
| 14:14.08 | Torhal | Probably an enum like ZoneLocationType.PetBattle |
| 14:14.36 | Torhal | Dunno, I need to wake up. I started sipping offee before I started talking to you. |
| 14:14.39 | Ressy | yeah.. |
| 14:14.40 | Torhal | coffee* |
| 14:14.43 | Ressy | not making much sense. |
| 14:14.49 | Ressy | pet:AddZoneLocations(Z.NORTHERN_BARRENS, nil, nil, "61.0:19.8", "62.8:20.2", "64.1:23.0", "65.0:28.7") |
| 14:14.53 | Ressy | Thats leaping hatchling. |
| 14:15.12 | Ressy | This is 2 lines for Rabbit: |
| 14:15.12 | Ressy | pet:AddZoneLocations(Z.ASHENVALE, "4-6", true) |
| 14:15.13 | Ressy | pet:AddZoneLocations(Z.AZSHARA, "3-6", false, "33.2:70.2") |
| 14:16.38 | Torhal | That would become: pet:AddZoneLocations(Z.NORTHERN_BARRENS, nil, ZL.LOOTED, "61.0:19.8", "62.8:20.2", "64.1:23.0", "65.0:28.7") |
| 14:16.43 | Torhal | Snowy Owl is: pet:AddZoneLocations(Z.WINTERSPRING, "17-18", false, "63.6:49.4", "57.6:45.8", "51.6:32.6", "57.6:58.8") |
| 14:16.55 | Torhal | Would become: pet:AddZoneLocations(Z.WINTERSPRING, "17-18", ZL.PET_BATTLE, "63.6:49.4", "57.6:45.8", "51.6:32.6", "57.6:58.8") |
| 14:17.10 | Ressy | ok... |
| 14:17.17 | Ressy | I can do a replace all in the db.. |
| 14:18.24 | Torhal | When I figure out exactly how I'm doing this, I'll just go ahead and do it. Less hassle for you. |
| 14:18.39 | Ressy | so.. I should push soon then. lol |
| 14:44.33 | Ressy | theres way more pets available from the world than I thought.. geez |
| 16:07.20 | Ressy | Torhal: Pushed ARL. |
| 16:07.22 | Ressy | go ahead :D |
| 16:10.34 | Ressy | err |
| 16:10.37 | Ressy | Collectinator. |
| 16:10.39 | Ressy | my head hurts |
| 16:15.18 | sidji | yeah I won the offline glyph quiz (IngressFS) |
| 16:34.59 | Ressy | ? |
| 16:38.36 | Ressy | Hey Torhal.. |
| 16:38.49 | Ressy | I pushed an update to Collectinator 30 mins ago, and it hasn't been packaged yet |
| 16:38.50 | Torhal | Mmmph? |
| 16:38.53 | Ressy | and packager shows nothing |
| 16:38.56 | Torhal | HAWT |
| 16:41.22 | Ressy | you kicked it. nice |
| 16:41.25 | Ressy | Pending commits |
| 16:41.25 | Ressy | <PROTECTED> |
| 16:41.29 | Torhal | Indeed. |
| 16:41.35 | Torhal | Zip exists. |
| 16:41.42 | Torhal | Thinking I'll nap. |
| 16:41.55 | Torhal | Actually, I know I will. Thinking is too difficult. |
| 16:42.01 | Ressy | lol |
| 16:42.03 | Ressy | thank you |
| 16:42.04 | Ressy | :) |