| 00:48.02 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 01:01.46 | *** join/#wowuidev Kesava (~Kesava@unaffiliated/sliker) |
| 01:54.03 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 04:14.24 | *** join/#wowuidev Gethe (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 04:18.49 | *** join/#wowuidev Gethe_ (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 04:56.15 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 04:56.16 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 05:14.11 | *** join/#wowuidev Andols (~yaaic@2a00:801:341:6295:dd75:768d:18d6:191c) |
| 05:17.53 | *** join/#wowuidev A-KO (~ako@2605:a601:a72b:900:9048:858d:fe25:a6cc) |
| 05:31.57 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 05:31.57 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 06:38.23 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 06:50.35 | *** join/#wowuidev Sintacks (~Syntax@unaffiliated/sintacks) |
| 07:13.50 | *** join/#wowuidev Andols (~yaaic@2a00:801:341:6295:dd75:768d:18d6:191c) |
| 08:16.04 | *** join/#wowuidev Fisker (~Fisker-@185.109.91.253) |
| 09:48.15 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 11:56.53 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 12:52.26 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 13:15.54 | *** join/#wowuidev Meorawr (~Meorawr@cpc157779-rdng31-2-0-cust890.15-3.cable.virginm.net) |
| 13:51.00 | *** join/#wowuidev A-KO (~ako@2605:a601:a72b:900:cdcc:5abb:cd93:e34d) |
| 14:22.19 | Gethe | I was intrigued by the earlier convo about <ScopedModifier> so I made an addon to see what i could do with it. https://github.com/Gethe/XMLTests |
| 14:23.42 | Chipzz | Gethe: I recently asked (and got an answer) about fullLockdown |
| 14:23.59 | Chipzz | lemme grep my logs |
| 14:28.47 | Chipzz | Gethe: 19:39 <@Crosshash> Prevents a frame from being used as a parameter to any Lua functions (unless explicitly allowed when called by C++ code) |
| 14:33.38 | Gethe | Yeah i remember seeing that, i'll have to contrive an example to test it |
| 14:34.02 | Gethe | see if it applies to non-blizzard code |
| 14:34.11 | Gethe | i doubt it |
| 14:35.30 | Chipzz | Gethe: and the forbidden attribute is the same as https://github.com/Gethe/wow-ui-source/blob/live/FrameXML/SecureCapsule.lua#L79 |
| 14:35.53 | Chipzz | which is unavailable to us mere mortals because it's abosrbed by SecreCapsule |
| 14:36.00 | Gethe | yeah i figured |
| 14:36.23 | Meorawr | Well, even if it wasn't absorbed it's also a protected function anyway. |
| 14:36.43 | Chipzz | I wonder why |
| 14:36.45 | Meorawr | At least as far as I remember it was |
| 14:36.57 | Chipzz | because creating forbidden frames only restricts you |
| 14:37.04 | Chipzz | it's like shooting yourself in the foot |
| 14:37.10 | Meorawr | Yeah, that's why I think I might be misremembering |
| 14:37.56 | Meorawr | I had a lot of weird experiments going on when I broke into that stuff, they all sorta merge together |
| 14:43.51 | Chipzz | :) probably a while ago too |
| 14:47.04 | Chipzz | the weird thing is, :IsForbidden and :SetForbidden are available on all ParentedObjects, including eg Texture and Aninmation |
| 14:47.19 | Chipzz | but there's only CreateForbiddenFrame |
| 14:48.34 | Meorawr | It's for when you absolutely positively 100% need it forbidden at creation; it likely adds extra checks to ensure you're not instantiating an insecure template for example. |
| 14:48.49 | Meorawr | Of course being forbidden in of itself would make that less of an issue |
| 14:49.07 | Meorawr | It likely has a purpose that we mere mortals cannot [yet] comprehend. |
| 14:49.31 | Gethe | The difference from what i can tell is that the attribute from XML removes the frame from the global table. Any other forbidden frame, like some nameplates, are accessible but not interactable. |
| 14:50.19 | Gethe | like if you do /dump WowTokenButtonTemplate it reports it as nil |
| 14:50.43 | Gethe | derp |
| 14:50.46 | Gethe | template |
| 14:50.59 | Meorawr | I'm having an off day too, if it helps :) |
| 14:51.13 | Chipzz | Gethe: wouldn't removing the frame from the global table be a side-effect from scriptsUseGivenEnv?? |
| 14:51.39 | Meorawr | iirc scriptsUseGivenEnv still creates entries in _G for concrete frame instantiations |
| 14:51.47 | Chipzz | Gethe: I don't think templates are available in the global namespace anyway? |
| 14:51.54 | Gethe | no it's not, WowTokenDialog is there |
| 14:52.06 | Gethe | yeah, found that out |
| 14:52.51 | Chipzz | from what I gather tenplates are probably done by reparsing the XML node or sth |
| 14:53.06 | Meorawr | No doubt the result of all this poking around is gonna be a surprise 9.0 change to prevent ScopedModifier from working in addons :p |
| 14:53.31 | Chipzz | my implementation parses virtual nodes and keeps them as objects, but that's causing quite a bit of issues |
| 14:54.32 | Chipzz | issues that could more easily be avoided by just reparsing the XML node on inheriting |
| 14:55.49 | Gethe | tbh i think its pretty benign. the two secure attributes don't seem to affect non-blizz frames |
| 14:55.50 | Chipzz | one issue is that you can have: <Frame name="i2" virtual="true" inherits="i1" /><Frame name="i1" virtual="true" /> |
| 14:56.24 | Chipzz | so defining a template you inherit from after the definition of the inheriting template |
| 14:56.58 | Gethe | and scriptsUseGivenEnv allows use to use mixins without adding to the global namespace |
| 14:57.32 | Chipzz | adding to the global namespace. heh :). talking about a lost fight :) |
| 14:58.06 | Chipzz | the global namespace is a clusterfuck of pollution as it is :) |
| 14:58.35 | Gethe | meh dosn't mean we have to add to it /shrug |
| 14:58.49 | Chipzz | yeah I do try to avoid adding to it myself if I can |
| 14:59.04 | Chipzz | but, meh :P |
| 14:59.44 | Chipzz | although moving a lot of API into C_* tables is a good step |
| 15:00.06 | Gethe | yeah A+ to that |
| 15:00.39 | Meorawr | I think the pitfalls of the external template case when imported within the context of a ScopedModifier makes its benefits harder to realize, especially with a lot of builtin templates having mixins added to them as time goes on it seems. |
| 15:00.43 | Funkeh` | Easy to clean that up, move all the locale to a table |
| 15:01.07 | Chipzz | Funkeh`: I was just about to mention locale |
| 15:01.27 | Funkeh` | Or keep moving 6 functions to a C_ table every patch, whatevs :p |
| 15:01.31 | Chipzz | Funkeh`: except that for scriptsUseGivenEnv locales are looked up in the addon table |
| 15:02.14 | Chipzz | Funkeh`: https://github.com/tomrus88/BlizzardInterfaceCode/blob/master/Interface/AddOns/Blizzard_AuthChallengeUI/Blizzard_AuthChallengeUI.lua |
| 15:03.36 | Gethe | except in an insecure environment, scriptsUseGivenEnv seems to still pull from the global table from anything that's not a mixin. So global strings still work |
| 15:07.50 | Chipzz | 16:55 < Gethe> tbh i think its pretty benign. the two secure attributes don't seem to affect non-blizz frames >> I found 20:03 <@Crosshash> It involves addon security so I will not elaborate further on this topic. >> a little odd |
| 15:08.19 | Chipzz | given that we have the xml and lua code anyway so can deduce from the source regardless |
| 15:09.44 | Meorawr | You were delving too greedily and too deep, clearly :) |
| 15:10.29 | Meorawr | Didn't wanna unleash the API equivalent of the Balro--oh wait there's UIDropDownMenu. |
| 15:11.05 | Chipzz | or maybe the implementation is a hack and not as secure as it should be :P |
| 15:12.35 | Meorawr | Well, "as it should be" isn't a high barrier within the context of a UI API for a video game all things considered, so yeah it's probably a bit of a hack in some areas. |
| 15:13.02 | Chipzz | Gethe: the odd thing is that Fonts appear to be special, virtual Fonts actually *are* present as global objects |
| 15:13.44 | Chipzz | then again Font doesn't derive from ParentedObject |
| 15:15.08 | Gethe | i'm not talking about the font, i was referring to the attribute "text". Globals work. |
| 15:15.31 | Chipzz | 16:50 < Gethe> like if you do /dump WowTokenButtonTemplate it reports it as nil |
| 15:15.43 | Chipzz | 16:51 < Chipzz> Gethe: I don't think templates are available in the global namespace anyway? |
| 15:15.59 | Chipzz | that's what I was referring to |
| 15:16.57 | Gethe | oh yeah font templates are a whole other thing |
| 15:17.26 | Chipzz | there's also the weird behaviour with FontStrings inheriting from Fonts |
| 15:18.45 | Chipzz | and Fonts lack :IsForbidden and :SetForbidden |
| 15:19.44 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 16:29.47 | *** join/#wowuidev Crosshash (c64a2302@198.74.35.2) |
| 16:29.48 | *** mode/#wowuidev [+o Crosshash] by ChanServ |
| 16:53.14 | *** join/#wowuidev srnty_ (~srnty@2601:640:8302:eb0c:c29a:37b7:66c:eb89) |
| 16:53.25 | *** part/#wowuidev srnty_ (~srnty@2601:640:8302:eb0c:c29a:37b7:66c:eb89) |
| 16:56.28 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 16:56.29 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 17:31.51 | Chipzz | non-development related question: does anyone know what's required for BfA Pet Battle Order Hall Missions to spawn? They spawn on some of my chars, but not all |
| 17:32.12 | Chipzz | the chars where they don't spawn still have ilvl 950 followers ^^ |
| 17:37.06 | *** join/#wowuidev Yuyuli (~Yuyuli@85-127-63-68.dsl.dynamic.surfer.at) |
| 18:51.54 | nebula | i thought they were just random rare ones |
| 18:52.09 | nebula | like for the corgi |
| 18:52.10 | nebula | ? |
| 18:52.29 | Chipzz | I'm talking about the ones that reward the tokens |
| 18:52.41 | Chipzz | the "Rat problem" one for example |
| 18:52.48 | Chipzz | I have 4 chars they spawn on |
| 18:53.10 | Chipzz | on 2 of my chars they even spawn back to back |
| 18:53.24 | Chipzz | on other chars they have never spawned at all AFAIK |
| 19:02.36 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ee3:fc00:46c5:a6f5:bd09:465e) |
| 19:05.20 | *** join/#wowuidev Fisker (~Fisker-@185.109.91.253) |
| 19:12.10 | foxlit | "BfA ... order hall... followers" |
| 19:13.33 | foxlit | that's almost garrison bingo, only missing ships. |
| 19:24.39 | nebula | i definitely saw order hall and my brain overwrote bfa with legion |
| 20:13.21 | *** join/#wowuidev Pursche01 (uid28470@gateway/web/irccloud.com/x-guddidoemogmqlgq) |
| 20:36.35 | *** join/#wowuidev Andols (~yaaic@2a00:801:341:6295:59b9:e214:b1b2:6a6a) |
| 20:36.53 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:01.52 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ee3:fc00:46c5:a6f5:bd09:465e) |
| 22:11.13 | Chipzz | nebula: I actually meant legion :P |
| 22:23.20 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ee3:fc00:46c5:a6f5:bd09:465e) |
| 22:33.01 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 23:09.35 | foxlit | legion did that thing where the missions you got were based on what content you did. |
| 23:13.18 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:70c1:5667:3ef3:f16) |