| 00:11.22 | *** join/#wowuidev dobson (~dobson@static.38.6.217.95.clients.your-server.de) |
| 00:33.26 | sylvanaar | foxlit: what would you do with such power? |
| 00:39.49 | foxlit | save time and memory. |
| 01:20.53 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 01:20.53 | *** topic/#wowuidev is 8.3 ToC: 80300 || 1.13 ToC: 11303 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 01:34.19 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 01:43.16 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 01:46.19 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 01:53.07 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 01:55.00 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 01:55.03 | *** join/#wowuidev A-KO (~ako@2605:a601:a72b:900:dc0a:4995:6747:348d) |
| 01:57.26 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 02:01.22 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 02:03.32 | *** join/#wowuidev talizea (~roimatrix@mail.epow0.org) |
| 02:10.28 | *** part/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 02:38.46 | *** join/#wowuidev Gethe_ (~Gethe@99-156-186-221.lightspeed.austtx.sbcglobal.net) |
| 06:07.31 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ee5:7500:836b:cdeb:d836:5ba4) |
| 06:47.47 | *** join/#wowuidev Yuyuli (~Yuyuli@85-127-63-68.dsl.dynamic.surfer.at) |
| 06:48.52 | *** join/#wowuidev Yuyuli_ (~Yuyuli@83.143.246.2) |
| 06:51.46 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 09:32.07 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:70c1:5667:3ef3:f16) |
| 10:16.46 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 12:19.56 | *** join/#wowuidev cirdan (~cirdan@c-73-196-43-185.hsd1.nj.comcast.net) |
| 12:46.32 | *** join/#wowuidev cirdan (~cirdan@c-73-196-43-185.hsd1.nj.comcast.net) |
| 12:52.38 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 12:54.51 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 12:57.54 | *** join/#wowuidev cirdan (~cirdan@2601:85:4600:e6:f64d:30ff:fe60:210d) |
| 13:02.36 | *** join/#wowuidev cirdan_ (~cirdan@2601:85:4600:e6:f64d:30ff:fe60:210d) |
| 13:53.58 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 14:21.49 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 14:21.49 | *** topic/#wowuidev is 8.3 ToC: 80300 || 1.13 ToC: 11303 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 14:34.07 | *** join/#wowuidev DrBunsen (55919836@54-152-145-85.ftth.glasoperator.nl) |
| 14:35.42 | DrBunsen | Hello all, I am curious if there is a way I can see if the player currently has an item selected(left clicking it)? |
| 14:39.57 | Ennea | DrBunsen, there's this: https://wow.gamepedia.com/API_GetCursorInfo |
| 14:42.34 | *** join/#wowuidev Meorawr (~Meorawr@cpc157779-rdng31-2-0-cust890.15-3.cable.virginm.net) |
| 14:54.38 | DrBunsen | Ennea: thanks, I will check that. |
| 15:03.31 | DrBunsen | Ennea: worked like a charm. |
| 15:03.57 | Ennea | :) |
| 15:31.38 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 15:50.43 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:42b:df96:2616:86f3:398d:d953) |
| 15:51.18 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 16:10.08 | *** join/#wowuidev Andols (~yaaic@2a00:801:42b:df96:26b9:477b:3b78:6ea2) |
| 16:19.55 | *** join/#wowuidev Crosshash (c64a2302@198.74.35.2) |
| 16:19.55 | *** mode/#wowuidev [+o Crosshash] by ChanServ |
| 17:40.39 | Chipzz | Crosshash: what exactly does scriptsUseGivenEnv achieve? its name implies it applies to scripts, but reading the code of for example Blizzard_AuthChallengeUI, it has text="BLIZZARD_CHALLENGE_SUBMIT", and Blizzard_AuthChallengeUI.lua has Import("BLIZZARD_CHALLENGE_SUBMIT"); , so it would appear that it applies to more than just scripts? |
| 17:42.55 | Meorawr | It makes every global lookup and assignment performed within the context of the scoped modifier hit the addon namespace/environment/whatever you want to call it table instead of _G |
| 17:43.13 | Meorawr | With a few extra quirks, like global frame names being assigned to both _G and the env table. |
| 17:44.30 | Meorawr | "within the context" is important because it also propagates those rules to templates if they get instantiated iirc, so a template outside the modifier that pulls in a mixin will scream loudly if that same mixin isn't then made available within your environment when instantiated inside the modified context. |
| 17:45.00 | Meorawr | My brain hurts remembering its quirks, it's powerful and undocumented and I love it but I also hate it. |
| 17:45.55 | Meorawr | (I might also be misremembering a few of these things) |
| 17:47.14 | Crosshash | The short version is that script functions set in .xml handlers are pulled from the local AddOn table instead of the global table. |
| 18:01.04 | Chipzz | Crosshash: the short version I got so far :) It's the long version I'm curious about. Like for example, xml text attributes also appear to be affected |
| 18:03.04 | Crosshash | It involves addon security so I will not elaborate further on this topic. |
| 18:05.33 | Chipzz | uh, ok I guess :) thanks for answering anyway! |
| 18:07.03 | *** join/#wowuidev greedom (~greedom@2001:16b8:2ee5:7500:836b:cdeb:d836:5ba4) |
| 18:10.00 | Chipzz | Meorawr: so, I already figured much of what you were saying. The reason I'm asking is it looks like I should just be inserting calls to lua_setfenv in the right places, except my XML parser is a C function, not a lua function. Looking at the implementation of setfenv it uses lua_getstack, but since it's running from a C function I suspect that approach would fail |
| 18:12.17 | Chipzz | Meorawr: I wonder if the XML KeyValue tag is also affected, sounds like a possible candidate |
| 18:14.42 | Meorawr | Chipzz: Random implementation idea; reserve a key in the Lua state's registry that initially references _G. When you parse a ScopedModifier with the attribute set, change that registry entry to reference the addon table instead. All global lookups made during parsing (be it keyvalues, mixins, scripts, etc.) should go through whatever reference is held in the registry. |
| 18:14.59 | Meorawr | Maybe make it a stack if ScopedModifier can be nested, but I don't think that's a realistic case worth supporting. |
| 18:15.38 | Meorawr | And of course revert the entry back to _G when you exit the modifier. |
| 18:20.33 | Chipzz | Meorawr: I currently have something similar but messy, with C/C++ variables |
| 18:20.50 | Chipzz | which doesn't really work anyway, so I want to clean that up |
| 18:21.51 | Meorawr | Yeah, I don't think the "magic" that binds the XML world to the Lua world can ultimately be a clean one. Any approach taken is likely to have plenty of pain points. |
| 18:23.28 | Chipzz | well so far it's mostly clean :) |
| 18:23.42 | Chipzz | except for those pain-points |
| 18:24.55 | Meorawr | Don't suppose you've tested if ScopedModifier can be nested? Just out of curiosity. |
| 18:25.10 | Chipzz | nope, not yet |
| 18:30.32 | Meorawr | The known details of ScopedModifier would, implementation-wise, suggest that any approach that involves the reference to the env table being a "temporary global" of sorts would be the right one when considering that templates defined inside a modifier don't retain it at instantiation time, and that templates instantiated within one use the "current" modifier at the point of instantiation. |
| 18:30.56 | Meorawr | As long as you're on that road I think you're set - code cleanliness be damned until you get there I think :) |
| 18:38.15 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 19:01.45 | *** join/#wowuidev IrcBridge_ (~IrcBridge@host-95-142-47-227.hosted-by-vdsina.ru) |
| 19:40.00 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 19:40.00 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 20:43.20 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 21:34.39 | foxlit | so I'm contemplating (re-)writing a highlighter for wow's xml. |
| 21:34.50 | foxlit | but <Script> this = "<!-- Terrifying! -->" </Script> |
| 21:55.38 | Chipzz | foxlit: yeah that's annoying, libxml2 also chokes on sth similar |
| 22:00.36 | foxlit | wait, why would an xml library not happily strip the xml comments out before giving you text content? |
| 22:01.20 | Chipzz | I don't recall the exact specifics but IIRC it was sth along the lines of <!-- -- --> |
| 22:01.27 | Chipzz | with -- starting a lua comment |
| 22:01.42 | Chipzz | so more like <!--\n-- lua comment\n--> |
| 22:02.03 | Chipzz | (I did say "similar" :) ) |
| 22:03.24 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:25.19 | foxlit | huh. "[...] For compatibility, the string " -- " (double-hyphen) must not occur within comments.]" |
| 22:25.34 | foxlit | ( https://www.w3.org/TR/xml/#sec-comments ) |
| 22:26.15 | znf | XML is whack |
| 22:31.11 | foxlit | also no ending with --->. Cool grammar, though. |
| 22:53.49 | Chipzz | foxlit: yeah... |
| 22:54.12 | Chipzz | so that's what I was running into I guess |
| 22:55.26 | Chipzz | foxlit: on a separate note, what's the bin.c in luacasclib? and why are there no instructions on how to compile it? |
| 23:03.04 | foxlit | Doesn't the readme mention it? |
| 23:11.35 | foxlit | Anyhow, it provides a function that adds two strings together. There is a pure lua fallback for when you haven't compiled that module, which is just a bit slower. |
| 23:28.08 | Chipzz | the website doesn't mention it |
| 23:29.04 | Chipzz | the README does indeed |