| 00:00.17 | foxlit | you have some odd expectations. |
| 00:00.39 | MooreaTv | that error handling is a language feature, yeah, very odd :) |
| 00:03.51 | foxlit | it (like error) is just a function and not some try/catch/throw language construct, so yeah. |
| 00:05.31 | foxlit | You might want to read the Lua manual rather than random guessing at coroutine semantics and hoping you get it right. |
| 00:06.31 | MooreaTv | yes I am reading https://www.lua.org/manual/5.1/manual.html#5.2 now |
| 00:06.57 | foxlit | the basic overview is in https://www.lua.org/manual/5.1/manual.html#2.11 |
| 00:09.18 | MooreaTv | I was wrongly assuming there was a default "on idle" handler resuming round robin all suspended coroutine, but it seems I have to implement it myself (or I'm sure there is some ace lib doing just that) |
| 00:11.11 | MooreaTv | in summary there seem to be very little value beside preserving some local state of coroutines vs just using after and batching things by hand in chunks in some after callback |
| 00:11.14 | Meorawr | Personal opinion based off absolutely nothing whatsoever: coroutines are rarely used in addons |
| 00:12.09 | MooreaTv | I guess the round robin thing I expect is sort of OnUpdate |
| 00:12.50 | MooreaTv | though that actually seems too often for my use case, but I can skip some frames or use after .1 instead |
| 00:13.46 | foxlit | Meorawr: https://www.townlong-yak.com/globe/wut/#q:coroutine.create (or coroutine.wrap). |
| 00:16.21 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 00:16.21 | *** topic/#wowuidev is WoW Classic Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.2.0 ToC: 80200 || 1.13 ToC: 11302 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 00:19.33 | foxlit | (so now you can think they're rarely used based on some mildly relevant numbers) |
| 00:21.12 | Meorawr | Yeah, the types of addons using them (and the context judging from filenames at least) doesn't surprise me too much |
| 00:22.02 | MooreaTv | also probably 1/2 are using it wrong :p |
| 00:26.03 | foxlit | If anyone is still playing classic, I could use some help with testing OPie: https://www.townlong-yak.com/opie/get/transient-alpaca -- create a ring, put different kinds of stuff (abilities, custom macros, built-in macros, items, pet abilities, etc) in it, check if everything works as you expect. |
| 00:31.02 | MooreaTv | looking at blizz's usage I learned about GetTimePreciseSec() which isn't documented |
| 00:34.52 | JoBbZ | anyone noticed an odd issue where if you iterate across some skills to pull down known recipe information, it pops up the crafting window for that skill? |
| 00:34.55 | JoBbZ | it's only some skills, not all |
| 00:35.22 | JoBbZ | specific to classic |
| 00:40.00 | MooreaTv | foxlit- someone wanted opie on classic, sent them your link |
| 00:40.33 | foxlit | er, no, that's not a good idea. |
| 00:41.23 | MooreaTv | ? |
| 00:43.08 | foxlit | I shared a link in this channel because I wanted somewhat-informed feedback from people who probably at least have lua errors turned on. |
| 00:44.00 | MooreaTv | k I removed it probably before they could read/get it |
| 00:44.30 | MooreaTv | (even though they wanted to write something like it themselves or port it and I told them about opie and to wait for the author to finish the port) |
| 00:44.44 | MooreaTv | (but then maybe that's more "dangerous" than useful users :) ) |
| 00:46.06 | foxlit | Assuming nothing major comes up, it'll probably be on twitch in a day or so. |
| 00:48.33 | foxlit | I'd like to avoid the possibility that it'd promptly have it barf in some way shortly after installing, but levelling 9 classes to 40 would take forever. |
| 00:49.31 | MooreaTv | I'm still only level 31... spending more time with wowlua and my addons than levelling |
| 00:52.00 | *** join/#wowuidev hizuro (~hizuro@WoWUIDev/hizuro) |
| 01:02.22 | *** join/#wowuidev Shooter (~pi@79.191.217.112.ipv4.supernova.orange.pl) |
| 01:07.44 | JoBbZ | MooreaTv: same :P |
| 01:07.52 | JoBbZ | anyone know of any good documentation on the gametooltip? :) |
| 01:17.00 | MooreaTv | now that I yield sometimes I'm down to 7k auctions/seconds :/ |
| 01:17.28 | MooreaTv | still about 10x faster than 2nd best scanner but... I lost quite a lot |
| 01:18.57 | znf | There's no getall in classic? |
| 01:50.04 | foxlit | "Mutter is end of life (EOL) and will no longer be maintained or supported." << meh, I guess I need to find another iOS irc client. |
| 02:00.28 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 02:00.29 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 02:04.33 | MooreaTv | znf- there is, otherwise it'd be minutes not single digit seconds scan time; but there are better and worse implementations from a speed point of view even with get all |
| 02:05.48 | znf | foxlit: self-hosted TheLounge |
| 02:05.50 | znf | :P |
| 02:06.17 | MooreaTv | *cough* discord *cough* |
| 02:06.23 | znf | There aren't many decent options on mac |
| 02:06.56 | znf | But I already use irccloud on my phone, so I just use that on my macbook too |
| 02:17.04 | *** join/#wowuidev MooreaWow (uid392335@gateway/web/irccloud.com/x-xtrsixficfeydnvs) |
| 02:17.27 | MooreaWow | testing 1 2 3 |
| 02:17.39 | foxlit | so probably https://apps.apple.com/us/app/palaver-irc/id538073623 |
| 02:41.27 | *** join/#wowuidev |Ackis| (~Ackis@WoWUIDev/WoWAce/ARL/Troll/Ackis) |
| 02:48.42 | znf | victim of auto-run/fly again https://i.imgur.com/IUVvKv2.png :( |
| 02:49.19 | znf | foxlit, how does that look on macos? |
| 02:49.24 | znf | I only see the iOS screenshots |
| 02:54.42 | *** join/#wowuidev Ketho (~Ketho@2a02:a44e:ac87:1:c9c:95f7:7d14:327d) |
| 03:10.59 | Ketho | foxlit: I created a ring with spells, items, built-in and custom macros. it works as expected for me |
| 03:11.26 | Ketho | except first aid doesn't show up in trade skills |
| 03:14.15 | Ketho | *the default tradeskills ring |
| 03:29.12 | *** part/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 04:44.57 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 05:10.36 | *** join/#wowuidev NiTro- (uid57822@gateway/web/irccloud.com/x-szemddldjecuhbxp) |
| 05:18.48 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:20c:6483:10b6:2dad:74ae:c30f) |
| 07:54.21 | MooreaTv | I get reports of DCs I can't repro... I wonder if I should find some network throttler or something as I don't know what cause them for some users only - I go and scan on their server and it works fine for me... |
| 08:16.22 | *** join/#wowuidev greedom (~greedom@i577BC677.versanet.de) |
| 10:35.17 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 10:35.17 | *** topic/#wowuidev is WoW Classic Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.2.0 ToC: 80200 || 1.13 ToC: 11302 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 11:05.29 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 11:18.50 | Industrial | Hi. I see people posting HandyNotes_Something plugins for HandyNotes but I can't find a classic version of the main addon. Is it out/working? |
| 11:20.28 | nevcairiel | the default works just fine |
| 11:52.23 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 12:16.36 | Ennea | hm.. i guess tiling textures in combination with SetTexCoord is something one should do via xml? |
| 12:20.52 | Ennea | or, rather.. it looks like i can't horizontally tile something with x axis texcoords that are not 0 and 1? |
| 12:21.06 | Ennea | so SetTexCoord(0.25, 0.75, 0, 1) would not work for something tiled horizontally |
| 12:21.11 | Ennea | at least the errors i've ran into suggest that |
| 14:15.09 | *** join/#wowuidev yalb (xsbot@lua/bot/yalb) |
| 15:13.26 | *** join/#wowuidev jaxdahl2 (jaxdahl@unaffiliated/jaxdahl) |
| 15:28.45 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 15:33.51 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 15:34.41 | *** join/#wowuidev A-KO (A-KO@2605:a601:a70e:1d00:4199:4bf8:34eb:9003) |
| 15:37.27 | Industrial | nevcairiel: ok ty |
| 16:37.04 | *** join/#wowuidev MooreaTv (~MooreaTV@unaffiliated/mooreatv) |
| 16:43.47 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 16:46.22 | Ennea | i distinctly remember somebody talking about uipanel layout stuff being kinda broken nowadays. does anybody have any details? |
| 16:46.43 | *** join/#wowuidev Crosshash (c64a2302@198.74.35.2) |
| 18:27.09 | *** join/#wowuidev Simca (~Simca@c-73-55-2-30.hsd1.fl.comcast.net) |
| 18:28.42 | *** join/#wowuidev Kalroth (~Kalroth@knas.io) |
| 18:29.03 | *** join/#wowuidev elGamal (~elg@5.253.206.78) |
| 18:46.08 | *** join/#wowuidev LexAwayFromHome (~lexlexlex@s154-5-197-130.bc.hsia.telus.net) |
| 19:17.31 | *** join/#wowuidev TukuiDevs (~TukuiDevs@45.32.153.30) |
| 19:29.02 | *** join/#wowuidev TukuiDevs (~TukuiDevs@45.32.153.30) |
| 19:30.42 | Elmoe | anyone have a good list of globals to steal from their luacheckrc? |
| 19:34.32 | Stanzilla | weakauras has a pretty long list |
| 19:35.29 | Elmoe | perfect thank you |
| 19:38.50 | JoBbZ | anyone have a link to detailed documentation on GameTooltip, or an addon I might look at for reference? |
| 19:39.17 | JoBbZ | also, anyone know how to write text on the worldmap frame these days? I used to do this in an addon to write zone levels to the map, which isn't necessary in retail, but would be useful in Classic now ;) |
| 19:39.30 | JoBbZ | my old routine to do it doesn't work with classic |
| 19:41.42 | Ennea | JoBbZ, what specifically are you looking for regarding gametooltip? |
| 19:41.55 | Ennea | i feel like the widget api page on the wiki documents everything you need to know |
| 19:42.15 | Ennea | and then there's also this: https://wow.gamepedia.com/UIOBJECT_GameTooltip |
| 19:45.44 | JoBbZ | Ennea: My tooltip broke when I switched my addon from: |
| 19:45.50 | JoBbZ | <Frame name="RecipeRadarAvailabilityTooltip" inherits="GameTooltipTemplate" frameStrata="TOOLTIP" parent="UIParent" hidden="true"> |
| 19:45.51 | JoBbZ | to |
| 19:45.58 | JoBbZ | <GameTooltip name="RecipeRadarAvailabilityTooltip" inherits="GameTooltipTemplate" frameStrata="TOOLTIP" parent="UIParent" hidden="true"/> |
| 19:46.04 | JoBbZ | <Frame name="RecipeRadarAvailabilityTooltipFrame" parent="UIParent" hidden="false"> |
| 19:46.30 | JoBbZ | I made the change because the old method was generating errors for people running BugGrabber |
| 19:46.45 | JoBbZ | so trying to figure out what additional changes I need to make on my end :) |
| 19:47.40 | Ennea | hm |
| 19:47.55 | Ennea | no idea ^_^ |
| 19:47.59 | JoBbZ | I think the code is a bit out of date |
| 19:48.09 | JoBbZ | This addon is a crazy mix of vanilla and modern code |
| 19:48.19 | JoBbZ | because the blizzard API for classic is an f'd up mess when it comes to professions :P |
| 19:48.25 | Ennea | i don't think you need to set the frame strata, or set it to hidden |
| 19:48.26 | JoBbZ | some of it's vanilla, some of it's modern |
| 19:48.54 | JoBbZ | Ennea: ok, thanks. I'll play with those settings. I think there are other fundamental problems in the code base |
| 19:49.38 | JoBbZ | like it uses Framename.Lines instead of Framename:NumLines() |
| 19:49.54 | JoBbZ | so that's why I want the current API reference :) |
| 19:57.10 | Ennea | heh.. having bnet chat messages in one's scrollback is fun. it replayed those messages with a different name |
| 19:57.29 | Ennea | one that's also in my friend list (would be super weird otherwise), but definitely not the one i was chatting with |
| 20:19.25 | JoBbZ | hm, interesting... GetNumTradeSkills returns zero until at least one trade skill has been opened |
| 20:19.36 | JoBbZ | after that, it returns the correct value, regardless of whether or not any trade skills are open |
| 20:19.41 | JoBbZ | this seems to be a bug vs vanilla |
| 20:20.51 | JoBbZ | I don't know why Blizzard decided to revert the tradeskills API and split out enchanting into a whole separate "crafting" API for classic |
| 20:21.27 | JoBbZ | makes dealing with trade skills in classic a nightmare :P |
| 20:25.16 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 20:25.17 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 20:28.55 | JoBbZ | wish I knew a good way of directly reporting serious API bugs to blizzard |
| 20:29.02 | JoBbZ | they don't seem to respond to the forums much |
| 20:38.32 | JoBbZ | anyone know of an addon similar to Prat for classic? I need to copy/paste some output from the chat window |
| 20:39.42 | JoBbZ | never mind, found the version for classic ;) |
| 20:45.14 | Ennea | JoBbZ, GetNumTradeSkills() returns the number of different items you can make in the currently open profession |
| 20:45.19 | Ennea | not the number of professions you have |
| 20:45.31 | Ennea | so it makes sense that it would return 0 until you actually open one |
| 20:46.33 | Ennea | oh yea, headers also |
| 20:46.38 | Ennea | "Get the number of trade skill entries (including headers)" |
| 20:46.39 | Ennea | https://wow.gamepedia.com/API_GetNumTradeSkills |
| 20:57.30 | foxlit | "currently visible" somewhere in there too. |
| 20:58.20 | foxlit | (collapsed headers very likely reduce the count by making the skills under them vanish) |
| 20:59.36 | Ennea | good point |
| 21:04.22 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 21:07.11 | nevcairiel | a good return to the terrible stateful header-aware API :p |
| 21:07.52 | Ennea | beautiful, isn't it? |
| 21:08.17 | JoBbZ | I think you're thinking of https://wow.gamepedia.com/API_GetTradeSkillInfo |
| 21:08.27 | JoBbZ | which takes an index returned by GetNumTradeSkills |
| 21:08.53 | JoBbZ | in any case, as I said, it works correctly once any profession windows has been opened, even if they are all closed in the values that it returns |
| 21:09.20 | Ennea | JoBbZ, GetNumTradeSkills() returns the number of headers and items of the currently or last open profession |
| 21:09.37 | Ennea | documentation says it does, and.. well, testing confirms that |
| 21:09.38 | nevcairiel | in concept, it makes no sense to call it before a tradeskill was selected and opened |
| 21:09.41 | Ennea | ^ |
| 21:10.08 | nevcairiel | you can theoretically perform that selection in code as well |
| 21:10.25 | JoBbZ | hm, general problem is trying to loop through all known skills |
| 21:10.39 | JoBbZ | (cooking, first aid, tailoring, etc) |
| 21:11.11 | Ennea | you can loop through whatever's currently open |
| 21:11.17 | Ennea | i believe that's your only choice ;) |
| 21:11.44 | JoBbZ | I really hate this api :P |
| 21:11.57 | JoBbZ | should be a trivial way to just query what professions a player knows |
| 21:11.58 | nevcairiel | if you just want to know if someone knows cooking or first aid, you probably want the skill lines instead |
| 21:12.02 | nevcairiel | which are equally terrible |
| 21:12.07 | Ennea | :D |
| 21:12.27 | Ennea | you should be happy we weren't given an exact copy of the 1.12.1 api |
| 21:12.38 | foxlit | meh, writing a loop to expand/collapse things isn't terrible. |
| 21:13.06 | nevcairiel | its stateful, therefor its by definition a terrible api |
| 21:13.18 | JoBbZ | GetTradeSkillLine is based on the open trade skill window |
| 21:13.39 | Ennea | JoBbZ, you want https://wow.gamepedia.com/API_GetSkillLineInfo |
| 21:13.39 | foxlit | let's not redefine terrible to mean "mildly inconvenient, sometimes" |
| 21:13.48 | Ennea | which is what nevcairiel said/meant |
| 21:13.58 | nevcairiel | no matter how easy it is to work around foxlit, stateful is always terrible |
| 21:14.07 | JoBbZ | I already use all of these functions |
| 21:14.09 | Ennea | also, aren't professions spell ids, too? |
| 21:14.15 | Ennea | could check via those if a player has them? |
| 21:14.43 | nevcairiel | If all you want to know is if someone knows a certain profession, GetSkillLineInfo is the way to go |
| 21:14.53 | JoBbZ | Ennea: you can't access spell IDs in classic |
| 21:14.59 | nevcairiel | sure you can |
| 21:15.04 | Ennea | just can't grab them from combat log |
| 21:15.09 | Ennea | can still do everything else with them |
| 21:15.19 | Ennea | would be pretty silly if you couldn't :) |
| 21:15.50 | JoBbZ | nevcairiel: https://www.wowinterface.com/forums/showthread.php?t=57437 |
| 21:15.57 | JoBbZ | feel free to update with a solution that works with Tradeskills |
| 21:16.31 | JoBbZ | in Classic |
| 21:16.39 | nevcairiel | I have no idea wtf it is you want to do, you seem to shift your requirements every couple seconds |
| 21:16.44 | JoBbZ | ? |
| 21:16.56 | nevcairiel | first you apparently wanted to just know if someone knwos a profession |
| 21:17.03 | nevcairiel | wtf do recipe spell ids have to do with that |
| 21:17.03 | JoBbZ | nevcairiel: That's just the first step |
| 21:17.29 | JoBbZ | It's a loop that initializes a database of all known recipes of a given character, for all tradeskill and crafting professions |
| 21:18.03 | JoBbZ | to allow the determination of whether or not a given character needs X recipe sold on vendors |
| 21:18.16 | JoBbZ | https://bitbucket.org/yunohu/reciperadarclassic/src/master/SkillDB.lua#lines-87 |
| 21:18.38 | nevcairiel | doesnt it say "already known" in the tooltip? :p |
| 21:19.00 | JoBbZ | the point is it filters out what you already know |
| 21:19.16 | nevcairiel | so read the tooltip, if thats your only goal |
| 21:19.18 | JoBbZ | you can set waypoints to vendors in the zone you're in (or in other zones) |
| 21:19.19 | JoBbZ | no |
| 21:19.38 | JoBbZ | the addon is for helping find vendors that have recipes you need, regardless of your current location |
| 21:19.47 | JoBbZ | most often used to find vendors in the zone you're in |
| 21:19.51 | JoBbZ | but could be other zones as well |
| 21:19.52 | Ennea | that seems oddly specific and a bit.. complicated |
| 21:20.06 | nevcairiel | so? you can still make a tooltip for it and check, if nothing else |
| 21:20.28 | nevcairiel | tooltip scanning for m issing api returns has been a thing since 1.0 :P |
| 21:23.03 | JoBbZ | it does more than just that |
| 21:23.08 | JoBbZ | it tells you if it's available now, or later |
| 21:23.14 | JoBbZ | it tells you if an alt could use it now, or later |
| 21:23.20 | JoBbZ | it's not just about your present character |
| 21:23.32 | JoBbZ | https://imgur.com/oZacuJ3 |
| 21:23.47 | JoBbZ | hm, better link would be |
| 21:23.47 | JoBbZ | https://i.imgur.com/oZacuJ3.png |
| 21:23.57 | JoBbZ | or https://i.imgur.com/MDdvZty.png |
| 21:24.00 | JoBbZ | as another example |
| 21:24.18 | JoBbZ | green means learnable now, read means learnable later, etc |
| 21:24.59 | nevcairiel | what you do with the information or how you present it really doesnt change anything |
| 21:25.25 | JoBbZ | I'm open to suggestions to improving the code however possible, but your bit about tooltips is meaningless to me :) |
| 21:25.56 | JoBbZ | I'm also curious on the API in classic for getting spellIDs, since every route I tried didn't exist in classic, only later versions |
| 21:26.09 | nevcairiel | the point is that you should be flexible about the information you actually need and not be set in your ways just because on retail you use spell ids |
| 21:26.12 | JoBbZ | I at least found a way to extract itemIDs and enchant IDs |
| 21:26.38 | Ennea | getting spell ids for professions? doubt you can |
| 21:26.40 | nevcairiel | this current crafting api was basically used until legion, what did people do before legion on retail? |
| 21:26.41 | JoBbZ | if you read that forum thread, I clearly noted I grab the itemIDs/enchantIDs, since the spellIDs aren't available |
| 21:26.58 | Ennea | but you got item ids, so it's cool |
| 21:27.13 | JoBbZ | nevcairiel: not true. For example, Enchanting (in vanilla) was a whole separate thing from tradeskills |
| 21:27.21 | JoBbZ | pita to deal with, but I found a way to get the IDs ;) |
| 21:27.26 | nevcairiel | and its in classic too |
| 21:27.41 | nevcairiel | but thats irrelevant and just misdirecting |
| 21:27.49 | JoBbZ | right.. |
| 21:27.54 | JoBbZ | you said the API hadn't changed until legion |
| 21:27.55 | Ennea | getting the item id shouldn't be much of an issue |
| 21:27.56 | JoBbZ | I'm saying that's false |
| 21:28.11 | JoBbZ | they merged enchanting into trade skills long before legion |
| 21:28.33 | JoBbZ | Ennea: yes, i've already stated multiple times I can get the itemID for trade skills, and the enchanting ID for enchants... |
| 21:28.34 | nevcairiel | that is not an api change for the tradeskill api, other then deleting the special enchanting api |
| 21:30.45 | Ennea | JoBbZ, you also said it's a pita to deal with |
| 21:31.43 | JoBbZ | what's missing from Classic is GetTradeSkillRecipeLink |
| 21:31.49 | JoBbZ | which is another API difference |
| 21:32.01 | nevcairiel | because you can't link recipes in classic |
| 21:33.14 | JoBbZ | sure, but that's an API change to trade skills (and the related Crafting API as well) |
| 21:33.20 | JoBbZ | clearly a difference between vanilla and legion |
| 21:33.30 | JoBbZ | again, your asserting the API is not different is incorrect |
| 21:33.35 | JoBbZ | but all of this is immaterial |
| 21:33.44 | foxlit | for bonus points, write a short function to return the player's skill in Pandaria Fishing on 8.2 |
| 21:33.48 | JoBbZ | all I would really like is a way to query the professions a character knows |
| 21:34.02 | nevcairiel | we told you that pages of chat ago |
| 21:34.06 | Ennea | professions: check spell ids |
| 21:34.21 | Ennea | items you can make: open tradeskill window for each profession and loop them |
| 21:34.25 | nevcairiel | skill lines work, spell ids might work |
| 21:34.31 | Ennea | spell ids work, i just checked |
| 21:34.39 | JoBbZ | again.. without opening any trade skill windows |
| 21:34.41 | Ennea | just a bit of a pita to find them, since wowhead doesn't list them |
| 21:34.45 | Ennea | JoBbZ, again: can't |
| 21:34.55 | JoBbZ | Ennea: I got all the spell IDs out of wowhead just fine |
| 21:35.00 | JoBbZ | I have a database that maps itemIDs to spellIDs |
| 21:35.07 | nevcairiel | you dont need to open the window, you just n eed to tell the game that you did |
| 21:35.07 | JoBbZ | (or enchantIDs) |
| 21:35.10 | Ennea | this is like talking to a wall.. |
| 21:35.15 | JoBbZ | nevcairiel: how? :) |
| 21:35.34 | Ennea | C_TradeSkillUI.OpenTradeSkill, i assume |
| 21:35.37 | JoBbZ | Ennea: when you say it "works" how did you check? what API? |
| 21:35.49 | nevcairiel | implementation left as an excercise to the reader |
| 21:35.52 | Ennea | IsPlayerSpell(), using the spell id for engineering |
| 21:36.12 | foxlit | but there are like 5. |
| 21:36.14 | JoBbZ | Ennea: I'll test the C_TradeSkillUI, but pretty sure it doesn't exist in classic.. |
| 21:36.47 | Ennea | yea, looks like it doesn't. oh well, there's another way |
| 21:36.54 | Ennea | if you're lost, check blizzard's code i guess |
| 21:36.58 | nevcairiel | in short call SelectTradeSkill with the right id |
| 21:37.13 | JoBbZ | nevcairiel: thanks |
| 21:37.22 | JoBbZ | Ennea: I thought part of the purpose of this channel was to offer help. Am I mistaken? |
| 21:37.39 | Ennea | i'm not going to research things i don't know to help somebody else who also doesn't |
| 21:37.45 | Ennea | unless something seems particularly interesting |
| 21:37.55 | nevcairiel | pointing someone to a place where they find info is often better help then spoon-feeding them |
| 21:37.59 | Ennea | ^ |
| 21:38.02 | JoBbZ | nevcairiel: I'll play with that, unfortunately the API page doesn't exist |
| 21:38.14 | JoBbZ | nevcairiel: agreed, an API pointer is all I'm really asking for |
| 21:38.21 | JoBbZ | I read through everything I could find that was documented |
| 21:38.23 | JoBbZ | this one isn't |
| 21:38.23 | JoBbZ | so |
| 21:38.31 | JoBbZ | https://wow.gamepedia.com/API_SelectTCradeSkill |
| 21:38.37 | JoBbZ | no docs, so I'll futz with it |
| 21:38.39 | JoBbZ | tyvm :) |
| 21:38.40 | Ennea | checking blizzard's code might help with understanding undocumented functions |
| 21:38.42 | nevcairiel | your first stop should've been the blizzard tradeskill UI code |
| 21:38.55 | nevcairiel | "how does this thing get the recipes that I also want to know about" |
| 21:38.57 | JoBbZ | heh, actually their link is broken |
| 21:38.58 | JoBbZ | lol |
| 21:39.16 | JoBbZ | although even select trade skill doesn't exist |
| 21:39.19 | Ennea | why their link? that's your link o.o |
| 21:39.34 | JoBbZ | https://wow.gamepedia.com/Patch_1.13.2/API_changes |
| 21:39.37 | JoBbZ | is where I got the link from |
| 21:39.40 | JoBbZ | their link has a typo |
| 21:39.49 | Ennea | ah |
| 21:39.56 | Ennea | man, i thought that list was auto generated |
| 21:39.59 | Ennea | how does a typo get in there? |
| 21:42.16 | JoBbZ | hm, an old doc says: "SelectTradeSkill" - Selects a recipe in the trade skill listing, doesn't seem quite what I want, but that doc could be wrong |
| 21:43.48 | JoBbZ | old code example I found shows something similar, it gets a recipe from an open trade skill window |
| 21:44.06 | Ennea | try a new code example |
| 21:45.10 | JoBbZ | companion function for enchanting is SelectCraft |
| 21:45.21 | nevcairiel | last resort try to do CastSpellByName("Tailoring") and just supress the UI from actually opening |
| 21:46.31 | JoBbZ | nevcairiel: do that for all the professions, I suppose, since I don't know what ones they have. How to keep the UI from actually opening is knowledge I don't have, but would be happy to learn |
| 21:46.53 | Ennea | just take a look at blizzard's code already :/ |
| 21:46.55 | nevcairiel | figuring out which professions they have is easy, we went over that - use skill lines :) |
| 21:47.02 | Ennea | ^ or spell ids |
| 21:47.38 | JoBbZ | I'll read through https://github.com/tomrus88/BlizzardInterfaceCode/tree/livevsclassic/Interface/AddOns/Blizzard_TradeSkillUI in the mean time |
| 21:47.41 | nevcairiel | and an easy way to suppress the opening is to just unregister the event from UIParent, just remember to register it again after you are done or the UI will break :P |
| 21:52.50 | JoBbZ | nevcairiel: CastSpellByName present and works, not entirely clear how to unregister the event/register the event but I'll see what google tells me I guess |
| 21:55.20 | JoBbZ | hm, unregister TRADE_SKILL_OPEN I'm guessing |
| 21:55.26 | JoBbZ | then re-register it |
| 21:58.24 | JoBbZ | err, TRADE_SKILL_OPEN |
| 21:58.25 | JoBbZ | argh |
| 21:58.30 | JoBbZ | _SHOW even :P |
| 22:00.16 | nevcairiel | yeah thats the one |
| 22:00.44 | JoBbZ | thanks for the pointers, much appreciated :) |
| 22:07.39 | JoBbZ | hm, actually after all of this, all I really need to do is figure out why pressing the minimap button triggers the profession windows at all, it should just use the existing db |
| 22:40.52 | JoBbZ | nevcairiel: I think I've figured it out... see this addon is really old, and resurrecting it has been a pain, and figuring out what parts have to use the old API and which parts have to use the new API have been an... adventure |
| 22:41.16 | JoBbZ | nevcairiel: in any case, there's this code in there that calls: HideUIPanel(TradeSkillFrame) and HideUIPanel(CraftFrame) |
| 22:41.29 | JoBbZ | and that's not working in Classic, and I'm guessing that's not the valid way to do things these days ;) |
| 22:45.29 | JoBbZ | yeah that function doesn't exist at all in classic per https://wow.gamepedia.com/Global_functions/Classic |
| 23:05.59 | JoBbZ | hm nm, it does, was looking at the wrong thing |
| 23:16.04 | JoBbZ | ok, now I'm completely and utter baffled... I have a function that calls several other functions. If I comment one of those specific functions out, the skill frame no longer pops up (great). If I comment out *every single line* in the function I commented out, and let the other code call it, the frame comes back... even though that function now does nothing except exit... ??? |
| 23:17.21 | foxlit | they haven't yet invented magic. |
| 23:18.33 | JoBbZ | I also tried just making "return" the first line of the function, and as long as the function is called, I get the profession frame popped up |
| 23:18.38 | JoBbZ | I even exited/restarted, same deal |
| 23:18.49 | JoBbZ | just to make sure it wasn't some strange issue that /reload wouldn't fix |
| 23:20.32 | foxlit | just to be clear: what you're describing isn't practically possible. Therefore, your code doesn't do what you think it does. It's impossible to tell how exactly you've messed up without looking at that code. |
| 23:21.46 | JoBbZ | only place in the entire code base it gets called, too |
| 23:21.55 | JoBbZ | so it's not like something else is calling it later, and there's some oddity there |
| 23:22.28 | JoBbZ | oh lol, figured it out.. sigh |
| 23:22.44 | JoBbZ | I was looking at an old version of the file for reference, and was editing it, not the one in my addon folder :P |
| 23:24.44 | JoBbZ | ok there we go, it's the call to CastSpell(index, BOOKTYPE_SPELL) that's opening up the tradeskill frame |
| 23:32.21 | JoBbZ | and the call to HideUIPanel is not working as desired. ;) |
