| 00:19.57 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 00:19.57 | *** topic/#wowuidev is WoW Classic Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.2.0 ToC: 80200 || 1.13 ToC: 11302 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 01:21.33 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:95ce:5555:1e47:ad70) |
| 02:04.11 | *** join/#wowuidev Semlar (~semlar@072-189-128-149.res.spectrum.com) |
| 02:04.45 | LexSfX | is there a way to get localized spec names? my addon currently only works in English because the spec names returned are in English and i check against those names |
| 02:05.30 | LexSfX | "Combat", "Fury", "Holy", etc. |
| 02:06.35 | *** join/#wowuidev Cairenn (~Karen@MMOI/Administratrix/Cairenn) |
| 02:06.35 | *** mode/#wowuidev [+o Cairenn] by ChanServ |
| 02:29.25 | znf | Are you actually asking if you can check if the player is "Fury" when dealing with localisations? |
| 03:02.18 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 03:36.22 | *** join/#wowuidev Elmoe (~Elmoe@24.18.143.238) |
| 04:17.42 | *** join/#wowuidev jaxdahl (jaxdahl@unaffiliated/jaxdahl) |
| 04:47.29 | *** join/#wowuidev Andols (~yaaic@2a00:801:300:4ec9:b3ed:4eb6:f410:1a8d) |
| 05:31.54 | *** join/#wowuidev kristopher (~kris@121-82-244-83f1.osk1.eonet.ne.jp) |
| 05:37.22 | kristopher | Is there any way for me to create a custom event that can be used with RegisterEvent()? Bonus points if it doesn't need any libraries. |
| 05:41.47 | mitch0 | probably not, see AceEvent. it's been a while though since I last actively worked on addons ;) |
| 05:41.59 | mitch0 | were there arena frames in classic? |
| 05:42.53 | kristopher | Yeah, I've kind of got something set up with AceEvent or CallBackHandler. Haven't got it working how I want yet though. |
| 06:03.25 | LexSfX | classic doesn't have arena, so no arena frames |
| 06:04.18 | mitch0 | alrighty, disabled those as well then. apparently no focus frame either |
| 06:04.34 | LexSfX | yeah, as i discovered today :( |
| 06:05.17 | LexSfX | kristopher, if you want something to fire whenever a particular function runs, you can use hooksecurefunc or frame:SetScript (depending on whether it's a frame script or not). that will run your function immediately after every the other function runs |
| 06:05.23 | LexSfX | after every time* |
| 06:05.47 | LexSfX | that can avoid custom events in most cases, i've found |
| 06:06.27 | LexSfX | just make sure you're only running your hook once ever, since building up multiple hooks in a session is bad |
| 06:06.56 | LexSfX | (i mean adding that hook to that function; not running the function your hook adds) |
| 06:08.46 | kristopher | My end goal is actually to create a compatibility layer for a non-classic addon on classic. It crashes because it can't register an event. I just want to create a dummy event that never actually goes off. |
| 06:09.15 | kristopher | I could edit the source of the addon itself and comment out the event registration, but it would defeat the purpose. |
| 06:09.37 | mitch0 | could someone give the latest RangeDisplay alpha (r392) a try? did some drycode changes for classic ;) |
| 06:09.47 | LexSfX | kristopher: you can define and use IsClassic() like this |
| 06:09.49 | LexSfX | local function IsClassic() return WOW_PROJECT_ID == WOW_PROJECT_CLASSIC end |
| 06:10.08 | LexSfX | then just check (not IsClassic()) before registering your event |
| 06:10.49 | mitch0 | or you could just do local IsClassic = (WOW_PROJECT_ID == WOW_PROJECT_CLASSIC). no need to call a function every time ;) |
| 06:11.06 | LexSfX | true but it makes it shorter if you use it in a few places |
| 06:11.11 | LexSfX | not a big deal either way |
| 06:11.39 | mitch0 | LexSfX: I mean, define the local at the top of the file |
| 06:11.44 | LexSfX | oh, yeah |
| 06:11.45 | mitch0 | so, addon-local |
| 06:11.55 | LexSfX | what if the game suddenly turns non-classic though??? |
| 06:11.56 | LexSfX | lol jk |
| 06:12.02 | mitch0 | ;) |
| 06:12.32 | kristopher | All of those involve editing the existing addon. I'm basically trying to create a drop-in compatibility layer that puts stub functions to things that don't exist in classic. It works fine with variables and functions, but I'm stuck on how to handle non-existing events. |
| 06:13.23 | LexSfX | you could hook their functions directly. redefine the functions they define in your own addon... it's kinda dirty though if they use any protected functions though |
| 06:13.24 | kristopher | Maybe not possible though. From what I read, it sounds like events are hard-coded in the exe. |
| 06:14.44 | kristopher | That's a bit much. If it needs to be edited for every addon, might as well just patch the addon instead. Thank you for the suggestions though. |
| 06:15.56 | kristopher | But as long as there aren't any event issues. I have a very basic compatibility layer in progress. |
| 06:16.27 | LexSfX | i hook collectgarbage in my own addon so i don't have to edit every addon that uses it irresponsibly (meaning, at all), which works nicely |
| 06:17.10 | kristopher | I wonder if I could hook RegisterEvent... |
| 06:17.52 | LexSfX | interesting idea! |
| 06:18.13 | kristopher | dangerous idea lol. But I'll give it a shot |
| 06:19.47 | LexSfX | there's no harm in playing around with it :) |
| 06:34.25 | LexSfX | looks like Blizzard hooks RegisterEvent at MapCanvas_DataProviderBase.lua:79 in the classic wow-ui-source |
| 06:41.53 | kristopher | Ooh, O |
| 06:42.13 | kristopher | I'll take a look, I was having trouble finding exactly what to hook. |
| 06:46.03 | *** join/#wowuidev Sintacks (Sintacks@75-109-20-148.chlncmtk01.res.dyn.suddenlink.net) |
| 06:48.11 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 06:51.29 | *** join/#wowuidev harl (~harl@unaffiliated/harl) |
| 07:21.20 | *** join/#wowuidev Elmoe (~Elmoe@24.18.143.238) |
| 08:00.06 | Ennea | i have my own tooltip anchored in such a way to GameTooltip that they are the same width |
| 08:00.13 | Ennea | yet GetWidth() returns different values for both |
| 08:00.17 | Ennea | any idea why? |
| 08:02.57 | nevcairiel | tooltips are magic |
| 08:03.06 | nevcairiel | also perhaps scaling |
| 08:03.09 | nevcairiel | do they look the same? :p |
| 08:05.51 | Ennea | they look the same, yea |
| 08:07.43 | Ennea | the difference in width even differs.. ugh |
| 08:08.38 | Ennea | ah.. i forgot to give my own tooltip a parent |
| 08:08.46 | Ennea | set the parent to UIParent, now the widths match |
| 09:38.07 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:291a:fe3f:766b:ece6) |
| 09:42.29 | Ennea | hm.. hooksecurefunc('BrowseSearchButton_OnUpdate') does not call my callback function (only if i call BrowseSearchButton_OnUpdate manually). using BrowseSearchButton:HookScript('OnUpdate') works, however |
| 09:42.32 | Ennea | that seems weird |
| 09:45.43 | nevcairiel | if a function is assigned through XML you can't hook it that way, because hooking replaces the global of the function, but not any already assigned references |
| 09:46.28 | nevcairiel | a hook is litereally nothing more then BrowseSearchButton_OnUpdate = function() original() callback() end |
| 09:46.47 | nevcairiel | if someone saved the original reference of the function, it would still be the same thing after |
| 09:47.43 | Ennea | ahh. i didn't know about the xml part |
| 09:48.06 | Ennea | thanks! |
| 10:44.26 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 11:42.22 | *** join/#wowuidev Gnarfoz (smallbrain@WoWUIDev/WowAce/Gnarfoz) |
| 12:59.00 | Semlar | foxlit: do you know if there's any way to trigger a keybinding (eg INTERACTTARGET) and running a macro with the same keypress |
| 13:17.25 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 13:39.34 | *** join/#wowuidev bluspacecow (~bluspacec@121.99.191.137) |
| 13:39.34 | *** mode/#wowuidev [+v bluspacecow] by ChanServ |
| 13:47.00 | Chipzz | nevcairiel: the problem is hardly exclusive to XML though, :SetScript has the exact same problem |
| 13:48.22 | nevcairiel | of course, but the default UI doesnt use that really |
| 13:48.47 | nevcairiel | and even in xml it only started recently where they forego the wrapper function and instead do direct a ssigment |
| 13:48.52 | nevcairiel | assignment* |
| 13:48.57 | nevcairiel | well "recently" |
| 13:50.46 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 13:51.14 | Chipzz | not sure what change you're talking about |
| 13:54.27 | nevcairiel | basically <OnEvent>Frame_OnEvent(event, ...)</OnEvent> vs <OnEvent function="Frame_OnEvent"/>. The former is what it used to be historically for everything, and allows hooking as was attempted, the second started to be used at some point later, and would not catch the hook |
| 13:54.51 | Chipzz | ah |
| 13:55.22 | Chipzz | don't think that's really a matter of what was being used first |
| 13:55.38 | Chipzz | more a matter of personal taste depending on Blizzard Employee |
| 13:55.56 | nevcairiel | perhaps, but i figure the support for that was also added only later |
| 13:56.25 | Chipzz | I seem to recall in Vanilla the inline versions got their arguments as global variables? |
| 13:56.31 | nevcairiel | in even more recent code its now using Mixins and method="...", another kind that was not supported later |
| 13:56.37 | Chipzz | or rather, I hard rumors about... |
| 13:56.41 | nevcairiel | yes that was the case |
| 13:56.59 | Chipzz | yeah mixins are definitely more recent |
| 13:57.04 | Chipzz | much cleaner code IMO |
| 13:57.15 | nevcairiel | there was "this" global for the event throwing frame, and arg1...argX globals for the arguments |
| 13:58.33 | Chipzz | either way the first version would only allow hooking through :HookScript, right? |
| 13:59.10 | Chipzz | or am I misreading what you typed... hmmm |
| 13:59.16 | nevcairiel | the one with the inline code block you can actually hook the function, the one with function=... you need hookscript, for the method one, i rekcon you can hook the method and it works? |
| 13:59.29 | nevcairiel | didnt actually try |
| 13:59.47 | Chipzz | actually the inline version doesn't need a function header |
| 13:59.54 | Chipzz | did you add that on purpose or? |
| 14:00.11 | nevcairiel | what function header |
| 14:00.21 | Chipzz | Frame_OnEvent(event, ...) |
| 14:00.41 | nevcairiel | its a function call, not a header =p |
| 14:00.45 | Chipzz | you can just do <OnEvent>print(self)</OnEvent> |
| 14:01.02 | nevcairiel | its common for functions to be defined in .lua files and called like that from frame scripts |
| 14:01.04 | Chipzz | ah, now I see what you're trying to say |
| 14:04.01 | Chipzz | except your code should read <OnEvent>Frame_OnEvent(self, ...)</OnEvent> |
| 14:04.20 | nevcairiel | isnt that what i wrote |
| 14:04.26 | nevcairiel | oh right the self |
| 14:04.37 | nevcairiel | i think event is a named variable too |
| 14:04.44 | nevcairiel | but i might be wrong, never use that syntax myself |
| 14:06.21 | Chipzz | a lot of people here have a thorough hatred of XML and don't even use it :) |
| 14:22.17 | *** join/#wowuidev VIad (~Vlad@cm-84.213.147.218.getinternet.no) |
| 14:28.39 | Ennea | nevcairiel, event being a named variable sounds right |
| 14:28.55 | Ennea | Chipzz, for good reasons, in my opinion :p |
| 14:32.10 | Chipzz | Ennea: I disagree these reasons are good. at least the "cannot redefine virtual template". the problem IMO lies with the culture of embedding code copies, which in every field in IT I have worked in so far is considered a bad anti-pattern |
| 14:33.04 | Chipzz | I use the nolibs (or what is it called?) option in Curse too |
| 14:33.16 | Ennea | what's the nolibs option? |
| 14:33.22 | Ennea | and personally, i'm just not a fan of XML |
| 14:33.28 | Ennea | i find it too.. big? |
| 14:33.33 | nevcairiel | normal people are not happy to have dozens of unknown things show up in their addon list |
| 14:33.58 | Chipzz | don't install embedded libraries but instead install the libraries as separate addons |
| 14:34.09 | nevcairiel | thats why the embed thing became popular in the first place a decade ago or so, because people didnt like it, authors didnt like getting bothered about |
| 14:34.26 | Chipzz | use ACP, done/done |
| 14:34.39 | Chipzz | I just fixed the problem :) |
| 14:34.55 | nevcairiel | people also dont like being told to fix an addon problem with another addon |
| 14:35.16 | Chipzz | ACP is cool for other reasons too |
| 14:35.44 | Chipzz | like expanding/ collapsing the tree, very nice for big addons like DBM |
| 14:36.03 | Ennea | heh, not even i'm a fan of having the libraries separately |
| 14:38.35 | Chipzz | on the topic of XML; I;m generally not a fan of it, it gets (or rather got, json is th nw cool-aid :) ) for a lot of things |
| 14:39.05 | Chipzz | but WoW XML is a lot like HTML in a way, and for WoW UI IMO it works |
| 14:39.14 | Chipzz | much more readable and compact than doing it in code |
| 14:39.40 | Chipzz | s/for a lot/abuse for a lot/ |
| 14:44.25 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 14:49.55 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 15:15.47 | *** join/#wowuidev A-KO|pc (A-KO@2605:a601:a70e:1d00:c914:73a8:dab8:d649) |
| 15:27.44 | VIad | foxlit: can one grab OPie for 8.1 and use it on the classic client? I miss my OPie rings :'( |
| 15:34.02 | Mr_Rabies | VIad: not exactly the same but https://www.curseforge.com/wow/addons/ringmenu |
| 15:34.39 | *** join/#wowuidev Meorawr (~Meorawr@cpc96138-rdng26-2-0-cust327.15-3.cable.virginm.net) |
| 16:14.45 | *** join/#wowuidev kd3 (~kd3@unaffiliated/kd3) |
| 16:17.55 | VIad | dunno why but its been like this forever, mostly fields for some reason https://imgur.com/bU1C6xq |
| 16:19.47 | Mr_Rabies | it's essentially this but not sure why it's happening https://whatis.techtarget.com/definition/moire-effect |
| 16:20.05 | Mr_Rabies | are you using like a higher/smaller render resolution, or nvidia DSR? |
| 16:21.57 | Mr_Rabies | you could also play with the scaling on the frame itself if both of those are turned off |
| 16:22.27 | Mr_Rabies | it could be reducing some of those lines to subpixel size and causing moire effect |
| 16:23.50 | Mr_Rabies | or simply not matched with pixel size, possibly? |
| 16:29.19 | nevcairiel | this happens in games all the time due to resizing or anti-aliased rendering |
| 16:34.19 | Mr_Rabies | i think the worst thing is pixel shimmer from old consoles on a newer display, when the original rendering didn't use square pixels or whatever |
| 17:03.37 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:14.50 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 17:14.50 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 17:29.06 | *** join/#wowuidev TSquare (~tomthomps@198.74.35.2) |
| 17:29.06 | *** mode/#wowuidev [+o TSquare] by ChanServ |
| 18:08.17 | foxlit | viad: the current version *is* for 8.1. But you can grab basically any old verson (https://www.townlong-yak.com/opie/release ) and it'll still not work on the frankenclient. |
| 18:11.53 | znf | frankenclient heh |
| 18:41.16 | *** join/#wowuidev jaxdahl2 (jaxdahl@unaffiliated/jaxdahl) |
| 18:56.07 | Gnarfoz | has anyone managed to get the Classic client to remember the last realm? |
| 18:57.57 | nevcairiel | no, its just broken |
| 18:58.54 | Gnarfoz | bleh T_T |
| 19:14.11 | VIad | foxlit: I took the 8.1 one and added some local API wrappers to some C_ and spec API to return nothing/dummy data and OPie works pretty well out of the box like that. |
| 19:15.29 | foxlit | your definition of "pretty well" sucks. |
| 19:19.57 | VIad | well its mostly just making it not care for spec conditions, mounts, battlepets, toys, world markers isnt there, quest item API is not there, so rest works fine as far I can tell atm |
| 19:20.33 | VIad | I can see why it would be messy to keep both working in the same branch so I get it why you would wanna avoid having to support classic |
| 19:22.09 | foxlit | it's more that you can't tell what's broken. Try creating a custom macro. |
| 19:23.49 | VIad | yeah, I didn't say all the features are working, but the spell ring and casting has been behaving so far :x |
| 19:24.18 | foxlit | "so rest works fine" |
| 19:24.48 | VIad | gotta look at the bright sides though |
| 19:37.37 | *** join/#wowuidev Dejablue (~Dejoblue@cpe-173-91-122-138.neo.res.rr.com) |
| 19:41.52 | Justwait | Is there anything to go from spellName -> spellicon for classic |
| 19:42.39 | Justwait | Would love to have the icon with the spell name from the combatlog events ;( |
| 19:52.53 | kd3 | huh. free character transfers from the *queue* screen? that's new |
| 19:54.14 | *** join/#wowuidev Semlar (~semlar@072-189-128-149.res.spectrum.com) |
| 19:54.21 | Ennea | what? lol |
| 19:54.39 | Ennea | oh damn |
| 19:54.40 | Ennea | :D |
| 20:04.34 | znf | lol |
| 20:05.02 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 20:05.02 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 20:27.32 | foxlit | <PROTECTED> |
| 20:28.08 | Kalroth | "Category: Special Events" .. they got that right for sure |
| 20:33.38 | *** join/#wowuidev lithammer (~lithammer@2a02:2770::21a:4aff:fe88:c18d) |
| 21:19.45 | *** join/#wowuidev MooreaTv (~MooreaTV@unaffiliated/mooreatv) |
| 21:22.18 | *** join/#wowuidev MooreaTv (~MooreaTV@unaffiliated/mooreatv) |
| 21:38.17 | netameta | Anyone knows of a loot council addon for classic ? |
| 22:04.04 | *** join/#wowuidev TSquare (~tomthomps@198.74.35.2) |
| 22:04.04 | *** mode/#wowuidev [+o TSquare] by ChanServ |
| 22:43.56 | *** join/#wowuidev harl (~harl@unaffiliated/harl) |