| 04:49.54 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 04:49.54 | *** topic/#wowuidev is WoW Classic Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.2.0 ToC: 80200 || 1.13 ToC: 11302 || http://pastebin.com || Discord: https://discord.gg/sVQCHr5 || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl |
| 06:14.10 | *** join/#wowuidev Andols (~yaaic@2a00:801:340:bc1:478a:3e94:d0a9:7a1c) |
| 06:57.06 | *** join/#wowuidev Andols (~yaaic@2a00:801:340:bc1:478a:3e94:d0a9:7a1c) |
| 07:01.51 | *** join/#wowuidev Semlar (~semlar@072-189-128-149.res.spectrum.com) |
| 07:20.19 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:341:4458:c40d:c36c:f916:ded2) |
| 07:34.15 | *** join/#wowuidev Andols (~yaaic@2a00:801:3f2:b78c:a90b:9434:d80c:dccf) |
| 07:38.31 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:3f2:b78c:bc53:777b:39c3:3db8) |
| 08:17.56 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:dd28:fade:311:c2a3) |
| 08:24.53 | *** join/#wowuidev jaxdahl (jaxdahl@unaffiliated/jaxdahl) |
| 08:43.19 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 08:53.35 | Chipzz | sylvanaar: I would say that a) the links they're creating are technically correct; so on a technical level you should be able to handle them; b) you are correct in that there's a conventional way of creating links (which I would label the "right" way too personally); and c) that your handler isn't going to run every frame; I doubt there are servers that have a trade (or other) chat with >60 messages/ sec |
| 08:55.45 | Chipzz | I would also say that d) asking the author to change his links wouldn't be a dick thing to do (unless you use expletives - did I spell that correctly?) and e) people aren't forced to upgrade their addons so relying on everyone to upgrade their broken addon is not a strategy that will help anyway |
| 09:23.44 | foxlit | sylvanaar: fix your code. There is no reason link targets have to include colons. |
| 09:28.06 | foxlit | Since you can't send custom links to chat, it seems that your code runs after someone else's chat filter, which means that you might see both loose |H and loose |c escapes in message text, and are responsible for not breaking either. |
| 09:29.38 | Chipzz | sylvanaar: I only read your explanation on IRC at first; now I read the bug report, I would say that this is entirely on you |
| 09:30.56 | Chipzz | this is not a simple |H|c|r|h issue, this is |H|c|rfoo|h, part of the link isn't colored, and that makes sense for them to do |
| 09:31.51 | nevcairiel | If your addon messes with chat, its your responsibility to not break any kind of chat anyone could ever put in there. Anything else, and your addon is just broken. |
| 09:32.11 | Chipzz | and what foxlit said about the colons; colons are merely the way blizzard separates data, and is copied by lots of oter people, but the |h target is entirely arbitrary |
| 09:36.54 | Chipzz | on a related note my personal opinion is that the wiki page is severely lacking in that regard; it does no effort to mention the target is arbitrary and on the opposite almost suggests they're necessary; and the link types shouldn't be on that page at all IMO, should be a separate page |
| 09:42.23 | Ennea | anybody else having too many lines removed from chat when reporting a player? classic, btw |
| 10:50.10 | sylvanaar | Sure. I can try to adjust. But this code has been working for 10 years. This is the first addon not to do standard links |
| 10:50.47 | sylvanaar | Thatâs why it was a question |
| 10:52.34 | Ennea | sylvanaar, what about class colored player links? the color is inside the link there, too |
| 10:52.43 | sylvanaar | Hey maybe do links like everyone else - I guess was my thought |
| 10:53.09 | nevcairiel | if wow accepts it then its perfectly valid |
| 10:53.16 | nevcairiel | I wouldnt change it because one chat addon screws up |
| 10:53.41 | sylvanaar | Eh? Yeah thatâs.a point I guess by they arenât in the message body |
| 10:54.31 | foxlit | sylvanaar: there are no "standard" links. |
| 10:54.55 | sylvanaar | Yeah. I know |
| 10:55.49 | sylvanaar | I got the pattern from |
| 10:55.59 | Ennea | also, if anybody has any info on my previous question regarding chat messages being deleted when reporting a player, that'd be great |
| 10:56.04 | Ennea | that shit's a bit difficult to test |
| 10:56.50 | sylvanaar | The wow code somewhere I am sure |
| 10:58.07 | nevcairiel | there is enough toxicity on classic realms to report plenty people for testing, i'm sure |
| 10:59.52 | foxlit | If someone prints |cFFFFFFFFred to chat while Fred is in your group, are you also going to break the color code? :) |
| 11:00.31 | nevcairiel | well a 7 letter color code is kinda awkward |
| 11:00.57 | sylvanaar | Ok guys. Can you help me find a pattern that matches every possible link variation |
| 11:01.45 | nevcairiel | i dont even know what it is you are trying to accomplish instead of just letting the links be |
| 11:02.42 | sylvanaar | Was that for me foxlit? |
| 11:03.18 | sylvanaar | I want to color some text in a message containing links |
| 11:04.32 | sylvanaar | So I need to exclude the links from being matched |
| 11:05.25 | nevcairiel | so why not go simple and only match the mandatory |H .. |h ..|h pattern |
| 11:05.26 | sylvanaar | so like "Hi I am Fred [Invite Fred]", you'd only want to color Fred |
| 11:06.17 | Ennea | nevcairiel, not that much toxicity so far, surprisingly |
| 11:06.21 | sylvanaar | "Hi I am Beef [Invite Beef]" |
| 11:06.39 | nevcairiel | you should see this realm Ennea :p |
| 11:06.47 | Ennea | which one are you on again? :D |
| 11:07.17 | nevcairiel | plenty people getting instantly flamed for being retail babies just for asking some simple beginner-style questions |
| 11:07.26 | Ennea | damn |
| 11:07.42 | Ennea | i'm on venoxis, and everybody is just super friendly here, with a few exceptions to the rule |
| 11:07.53 | nevcairiel | and from what I gather from the forums, thats happening all over |
| 11:08.03 | Ennea | the forums are their usual cesspit |
| 11:25.16 | foxlit | sylvanaar: you probably need to account for more than just links -- something that looks like a player name could also appear in a texture or atlas escape. |
| 11:28.55 | sylvanaar | oh, i need to mention that player names are matched kinda complicatedly using frontiers "%f[%a\192-\255]" |
| 11:29.03 | sylvanaar | so they won't match just anywhere |
| 11:29.17 | sylvanaar | but let me find an example of what you are talking about |
| 11:31.14 | sylvanaar | i tried to simulate the regex \b |
| 11:31.33 | foxlit | |TInterface/AddOns/NotPrat/Fred-Moonglade.tga:0|t |
| 11:32.23 | sylvanaar | they that kinda looks like it'd match |
| 11:39.05 | sylvanaar | it actually doesn't match |
| 11:41.42 | sylvanaar | anywho, I hate changing 10 year old code - there could be a million reasons its like that |
| 11:41.56 | sylvanaar | but - I think its safe to take the colon out at least |
| 11:42.13 | sylvanaar | "|c.-|H.-|h.-|h|r" |
| 11:42.56 | foxlit | that's insisting on a color prefix/suffix which doesn't have to exist. |
| 11:43.25 | sylvanaar | sigh |
| 11:43.48 | Ennea | could make it optional |
| 11:44.02 | nevcairiel | just strip out the |c and |r from the mathc |
| 11:44.05 | nevcairiel | no reason it has to be there |
| 11:44.21 | Ennea | good point |
| 11:44.28 | sylvanaar | ok - I will take your guys advice |
| 11:44.44 | nevcairiel | the three-part |H syntax is always the same |
| 11:44.47 | sylvanaar | |H.-|h.-|h |
| 11:44.49 | nevcairiel | that much you know |
| 11:44.53 | nevcairiel | anything else is optional |
| 11:46.26 | foxlit | it still has this nice pathological case where the first | is actually escaped itself and what you match isn't a link. |
| 11:48.16 | sylvanaar | yeah I know |
| 11:48.33 | sylvanaar | 10 years - no real issues |
| 11:48.52 | sylvanaar | i think its just too much of an edge case |
| 11:49.09 | sylvanaar | hey is there a way to link a commit to a GH issue? |
| 11:49.43 | MooreaTv | in the commit just say "Fixes #23" and it'll close it |
| 11:49.59 | MooreaTv | or say "wip for #23" and it'll put a link |
| 11:50.21 | MooreaTv | if you already made the commit just paste the commit url and it'll show the short hash as link |
| 11:51.54 | MooreaTv | curious, how do you know the stuff you don't want to change is matching a pattern ? (there is no "not" in lua patterns afaik?) |
| 11:52.14 | MooreaTv | (link the actual code?) |
| 11:54.55 | sylvanaar | can you rephrase that |
| 11:55.04 | sylvanaar | i didnt quite understand |
| 11:55.51 | MooreaTv | can you link the code you've been talking about... the code that if I gathered correctly, highlights someones name but try to not match inside an existing highlight/link/colored section |
| 11:56.35 | MooreaTv | it'll be easier for me to read the code to see how you do the "not" part (I have a few guesses but... curious...) |
| 11:58.10 | sylvanaar | oh sure, it first matches things that it doesn't want to match, and stashes them - then it runs the matches it wants to do, then it puts the stashed matches back |
| 11:58.58 | MooreaTv | oh so like cut and paste ? you cut out, remember the offset you cut at, and put it back after the other gsub ? |
| 11:59.00 | sylvanaar | the stashing is kinda lame - it uses a string unlikely to be matched by anything else as a placeholder |
| 11:59.13 | MooreaTv | ohhh |
| 11:59.48 | sylvanaar | I have always wanted to rewrite it but there was never any reason to - has worked since 2007 |
| 12:00.43 | MooreaTv | if you know/control the input that's fine but for user generated data not so much - though I suppose you could use something like \0S1\0 \0S2\0 etc |
| 12:01.21 | MooreaTv | but the offset should work no? |
| 12:01.59 | MooreaTv | just remember to put back S1 at offset o1, etc... (just have to be careful the offset change as you reinsert/remove to do it reversed order or some such) |
| 12:02.01 | sylvanaar | that's actually better than what I have |
| 12:02.27 | sylvanaar | but like I said - it has never been a problem |
| 12:02.28 | sylvanaar | https://github.com/sylvanaar/prat-3-0/blob/master/services/patterns.lua |
| 12:02.35 | MooreaTv | ^ thx |
| 12:03.41 | MooreaTv | @####@ could be a cute smiley :) |
| 12:04.17 | MooreaTv | @##8##@ now we know how to troll prat users :p |
| 12:04.43 | sylvanaar | yes |
| 12:06.30 | sylvanaar | try it out - what happens? |
| 12:07.18 | MooreaTv | I only use my own addons :p (that's not true, but I use very few addons, never used prat, but I have a power user that uses it) |
| 12:08.11 | MooreaTv | I command you for having an open source license though! I aim to only use oss addons |
| 12:10.02 | MooreaTv | I do use WIM, great stuff! (well in classic I haven't so far) |
| 12:10.36 | sylvanaar | WIM is pazza's addon - its pretty great - lot of people have been maintaining it since he left |
| 12:12.11 | sylvanaar | i was able to break something by forging a placeholder token |
| 12:13.13 | sylvanaar | https://www.irccloud.com/pastebin/JpmLIiFr/ |
| 12:14.00 | sylvanaar | seems like thats what you can do - print things out more than once |
| 12:14.41 | MooreaTv | eheh |
| 12:15.03 | MooreaTv | you can probably make it exceed the 255 bytes |
| 12:15.14 | sylvanaar | probably |
| 12:15.59 | MooreaTv | \0 is harder to send/type (is it even possible outside of code) |
| 12:16.21 | sylvanaar | maybe I should take your idea |
| 12:16.38 | sylvanaar | this code is so old - and so core though, meh |
| 12:17.14 | sylvanaar | but it does seem like a good idea |
| 12:17.14 | MooreaTv | well it's a bit of gold plating as what you have mostly works; depends what else you have going on but probably not worth touching |
| 12:18.58 | Ennea | since we're talking about chat addons and i suspect the thing i asked about it may be due to my own chat addon.. |
| 12:19.05 | Ennea | sylvanaar, is hooking AddMessage still the way to go? |
| 12:19.09 | sylvanaar | no |
| 12:19.18 | Ennea | there's ChatFrame_AddMessageEventFilter, so i guess i should use that now? |
| 12:19.22 | sylvanaar | write a filter |
| 12:19.24 | sylvanaar | yeah |
| 12:19.29 | sylvanaar | BUT |
| 12:19.39 | sylvanaar | do not have side effects in your filter function |
| 12:19.48 | Ennea | what do you mean by side effects? |
| 12:20.48 | sylvanaar | don't say write to a saved variable, or increment a counter, or interact with things outside your function |
| 12:20.55 | Ennea | ah |
| 12:20.57 | Ennea | right |
| 12:21.03 | sylvanaar | you know "pure function" |
| 12:21.05 | Ennea | yea |
| 12:22.26 | Ennea | makes me wonder, though, is https://github.com/sylvanaar/prat-3-0 up to date? there's only like two occurrences of ChatFrame_AddMessageEventFilter in there. one is commented out and the other is hooking that function |
| 12:22.27 | sylvanaar | you can get away with not being 100% pure - you can read external data |
| 12:22.41 | sylvanaar | oh, lol - prat |
| 12:22.56 | Ennea | you're just maintaining that, eh? |
| 12:22.57 | Ennea | :D |
| 12:23.12 | sylvanaar | eh? |
| 12:23.21 | sylvanaar | no, there are some things you can't do with chat filters |
| 12:23.33 | sylvanaar | like modify the playerlinks |
| 12:23.36 | sylvanaar | timestamps |
| 12:23.39 | sylvanaar | etc |
| 12:23.40 | Ennea | ah |
| 12:23.50 | Ennea | so hooking addmessage is still the go to way to do that? |
| 12:23.51 | Ennea | ._. |
| 12:24.22 | sylvanaar | I hook CF_MEH, its better for most things |
| 12:25.25 | Ennea | what's CF_MEH? |
| 12:25.34 | sylvanaar | ChatFrame_MessageEventHandler |
| 12:25.49 | MooreaTv | I dedup in my filter but not sure if that's ... not ok |
| 12:26.27 | sylvanaar | dedup what? why? because you have side-effects you need to dedupe? |
| 12:26.41 | MooreaTv | yes I take action on the message |
| 12:26.55 | MooreaTv | so I kinda want to take 1 action not 5 |
| 12:27.03 | sylvanaar | yeah exactly |
| 12:27.29 | sylvanaar | prat has a dedup algorithm too, how does yours work |
| 12:27.31 | Ennea | sylvanaar, anything specific i wouldn't be able to do without hooking addmessage? and what fun stuff would i be dealing with if i had side effects in my filters? |
| 12:27.51 | Ennea | also, any potential side effects of hooking addmessage i'm not aware of? |
| 12:27.55 | sylvanaar | Ennea: you will need to dedup like MooreaTv |
| 12:28.18 | MooreaTv | so far that's all I needed : https://github.com/mooreatv/DynamicBoxer/blob/master/DynamicBoxer/DBoxChat.lua#L24-L30 (and then I have an internal duplicate error below that that never triggers) |
| 12:29.00 | MooreaTv | ie it seems you only get called back to back, multiple times, not interleaved |
| 12:29.02 | sylvanaar | yeah prat's works same way basically |
| 12:29.08 | sylvanaar | each event gets an ID |
| 12:29.18 | MooreaTv | with the same seq# |
| 12:29.42 | MooreaTv | but I have a big LRU table just in case too :) |
| 12:30.02 | Ennea | everything's so easy when just hooking addmessage D: but if the issue i have with player reports is because of that, i guess i will need to change how everything works right now |
| 12:30.42 | sylvanaar | Ennea: you can do it if you want, you may just have compatibility problems. |
| 12:30.43 | foxlit | is there some reason you want to process your message in a chat *filter*? |
| 12:31.07 | foxlit | The saner thing to do would be to just register for CHAT_MSG_WHATEVER and do whatever processing you need there. |
| 12:32.00 | sylvanaar | hes filtering it though |
| 12:32.05 | MooreaTv | if addressed to me, because it is a filter, I suppress the message if it's for the addon |
| 12:33.04 | Ennea | foxlit, i'm changing the messages |
| 12:33.13 | Ennea | altering the looks of the chat |
| 12:33.57 | sylvanaar | Ennea: you don't have to work alongside prat do you? |
| 12:34.19 | Ennea | nah |
| 12:34.22 | Ennea | making my own chat addon |
| 12:34.44 | foxlit | MooreaTv: but you supress the duplicates as well. So the simpler version is just to have a filter that supresses everything with your prefix/event logic, and a separate event handler that calls DB:ProcessMessage. |
| 12:35.18 | foxlit | (which drops the deduplication code and doesn't screw you over if someone has disabled whispers in all their chat frames) |
| 12:35.38 | MooreaTv | oh that's possible ? hmmm |
| 12:36.17 | MooreaTv | I mean it's possible for a user to supress whispers altogether and then no filter is called? |
| 12:37.38 | sylvanaar | I had a similar problem with chat sounds. I wanted to play a sound for an event, but only if it printed on one of the chatfranes |
| 12:37.43 | MooreaTv | but yeah it's a good idea to seperate the supression from the processing... it was sort of a short cut to not have to look at the whispers in 2 places |
| 12:39.54 | sylvanaar | Can you come up with a solution to avoid deduping in that case foxlit ? |
| 12:40.24 | foxlit | hm, maybe not. it runs the filters before FCFManager_ShouldSuppressMessage, which is perhaps a waste. |
| 12:41.21 | foxlit | sylvanaar: PlaySound from a hook on the ChatFrame's AddMessage. |
| 12:42.54 | sylvanaar | What if it goes to all the frames |
| 12:42.56 | foxlit | (although that interprets one of as "a specific" rather than "any") |
| 12:43.24 | MooreaTv | you mean the filters are always run, there is no way for a user to not have filters triggered on whispers? |
| 12:44.33 | sylvanaar | I basically did what MooreaTv did and gave each event an ID |
| 12:45.06 | MooreaTv | it's probably the other way around, I did what you did long before I did it :) |
| 12:45.35 | sylvanaar | I asked for it to be added to aceevent but everyone thought it was a dumb idea |
| 12:47.23 | sylvanaar | Basically just a counter |
| 12:47.37 | MooreaTv | I have my own app level id for my later dedup in case the first one fails (and it hasn't been needed so far) but the wow/system level is just the built in seq (12th or 13th arg depending how you count) you don't need to "give" an id, right ? |
| 12:48.30 | MooreaTv | because if you did give an id, based on what... next time a message comes in, how would you know it's same or not |
| 12:53.31 | sylvanaar | Oh wow added a sequence number? |
| 12:53.47 | MooreaTv | https://github.com/mooreatv/DynamicBoxer/blob/master/DynamicBoxer/DBoxChat.lua#L16 |
| 12:54.05 | MooreaTv | it's a counter it seems |
| 12:54.27 | MooreaTv | (from observing the values/debug, if I recall) |
| 12:55.04 | sylvanaar | Seems like my idea wasnât so dumb lol. I need to check it out |
| 12:55.20 | sylvanaar | I can replace that old code then |
| 12:55.40 | MooreaTv | except you can't know the counter because you're not wow ? |
| 12:56.18 | sylvanaar | I can just save it |
| 12:56.24 | MooreaTv | I mean, I don't get how you would implement it yourself ? you'd have to mutate the message or payload somewhere before the filters |
| 12:56.38 | sylvanaar | I just need *A* number |
| 12:57.04 | sylvanaar | I can show you |
| 12:57.05 | MooreaTv | sure but as you said, functional, how does you filter attach that number to the event? |
| 12:57.32 | MooreaTv | can't load https://wow.gamepedia.com/CHAT_MSG_WHISPER it's dead/broken for me (I think I edited that page but forgot) |
| 12:57.56 | MooreaTv | please do, I am curious :) |
| 12:58.12 | sylvanaar | I donât use filters |
| 12:58.25 | sylvanaar | Prat predates them |
| 12:58.44 | MooreaTv | ah, but then how do you have duplicates if you don't have filters? |
| 12:59.19 | MooreaTv | (what are you deduping?) |
| 13:00.01 | sylvanaar | addmessage's essentially - its the same problem |
| 13:00.06 | sylvanaar | https://github.com/sylvanaar/prat-3-0/blob/master/services/events.lua at the bottom |
| 13:01.42 | MooreaTv | I thought I could read lua by now :) |
| 13:02.29 | MooreaTv | so you set some global? that's a bit risky |
| 13:02.34 | sylvanaar | Prat tried to solve the issue of modularity of chat addons prior to the chat filter thing - it did it by streamlining the whole hook and modify process so each module didn't need to hook the chatframe |
| 13:02.40 | sylvanaar | its not global |
| 13:02.46 | sylvanaar | look at the top |
| 13:03.17 | sylvanaar | https://www.irccloud.com/pastebin/IjiwBEGo/ |
| 13:03.46 | sylvanaar | that was prior to the new table that bliz gives you for your stuff - I never updated it |
| 13:04.00 | MooreaTv | you know you can click on a link to get a line number in github url :) |
| 13:04.25 | MooreaTv | so who is using or reading EVENT_ID? |
| 13:04.44 | sylvanaar | Prat's modules |
| 13:05.07 | MooreaTv | (click on line number to highlight, shift click for a range) |
| 13:06.01 | sylvanaar | https://www.irccloud.com/pastebin/pGSWJRhC/ |
| 13:06.48 | sylvanaar | https://github.com/sylvanaar/prat-3-0/blob/cd6f6050900f973593692432d17590cf0bd46804/modules/Sounds.lua#L324-L325 |
| 13:06.57 | MooreaTv | cheers ^ |
| 13:07.15 | MooreaTv | but I have bad news for you :) |
| 13:07.52 | MooreaTv | well maybe it doesn't happen in chat context... but I stepped on the surprise to me that you can actually reenter event code (!) [in AH context] |
| 13:08.21 | MooreaTv | ie some blizz api use continuations it seems |
| 13:08.43 | MooreaTv | and multiple threads to not block the UI while doing stuff |
| 13:09.41 | sylvanaar | well there are no coroutines here, and once the sound plays - the id is cancelled for playing the sound again |
| 13:09.44 | sylvanaar | https://github.com/sylvanaar/prat-3-0/blob/cd6f6050900f973593692432d17590cf0bd46804/modules/Sounds.lua#L366-L370 |
| 13:10.49 | sylvanaar | you saying the same event is processed twice or something by the same frame? |
| 13:11.12 | MooreaTv | I mean that your EVENT_ID can change in the middle because you can get event processing to reenter |
| 13:11.49 | sylvanaar | OnEvent is called more than once for the same event? |
| 13:12.13 | MooreaTv | specifically GetAuctionItemTimeLeft can suspend your code and process more events and reenter |
| 13:12.19 | sylvanaar | ah |
| 13:12.50 | sylvanaar | well, I am sure there is some way to solve that too |
| 13:13.12 | MooreaTv | well for chat the way is to use blizzard provided ID :) |
| 13:13.55 | sylvanaar | i didn't know about the ID, that's awesome |
| 13:14.00 | MooreaTv | and probably not call any possibly expensive/blocking api from within the processing |
| 13:14.17 | MooreaTv | can you guys open https://wow.gamepedia.com/CHAT_MSG_WHISPER ? |
| 13:14.20 | sylvanaar | let me grab a sample |
| 13:15.11 | MooreaTv | logging everything is a good way to find stuff but if I could open that page I'd know if it was documented before I found out or not |
| 13:15.22 | sylvanaar | https://www.irccloud.com/pastebin/31lfQ8u7/ |
| 13:16.18 | MooreaTv | [06:14:49] 2, |
| 13:16.33 | sylvanaar | arg11? |
| 13:16.55 | MooreaTv | well I have a dejavu on whether it's 11,13,... |
| 13:17.13 | sylvanaar | you can just count, it's the 11th in the array |
| 13:17.28 | MooreaTv | I know but your array is missing the frame and the event, so 2 more |
| 13:18.14 | sylvanaar | oh, no the name is called arg11, not the 11th argument |
| 13:18.44 | sylvanaar | chat mod lingo |
| 13:19.12 | MooreaTv | = 13 (and in my code it's 9th because I only use ... after I get msg and author out too and I don't say it's 9 :) ) |
| 13:20.19 | sylvanaar | well this is just plain awesome |
| 13:20.38 | sylvanaar | I can finally get rid of RegisterAllEvents() !!! |
| 13:21.58 | MooreaTv | oh wow, UIParent_OnEvent is a good contestant for the most horrible piece of code in the world |
| 13:23.13 | MooreaTv | someone apparently never heard of table dispatch and thinks a zillion if/elseif is great, that must be a fun function to merge |
| 13:24.08 | MooreaTv | it's only a 1029 lines :) |
| 13:24.21 | MooreaTv | https://www.townlong-yak.com/framexml/live/UIParent.lua#1108 |
| 13:25.12 | sylvanaar | probably written by a C programmer |
| 13:27.03 | MooreaTv | can you see gamepedia ? it worked briefly from anon window and then died again |
| 13:27.18 | Ennea | seems a bit broken right now |
| 13:31.54 | *** join/#wowuidev MooreaTv2 (~MooreaTV@45.56.150.40) |
| 13:34.19 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 13:42.51 | *** join/#wowuidev m^rk (~mrk@75-136-211-136.dhcp.kgpt.tn.charter.com) |
| 13:43.15 | Ennea | your talk about chat ids made me find my bug.. i think |
| 13:43.32 | Ennea | i was recording chat messages and replaying the last 20 on addon reload, so you'd have some content when reloading your ui or logging back in |
| 13:43.45 | Ennea | it seems that messed with something, leading to too many messages being deleted when reporting a player from chat |
| 13:44.07 | m^rk | is there some kind of offical info about what's different between classic and retail as far as modding api? |
| 13:44.51 | MooreaTv | the id probably restart at 1 on /reload (or maybe not?) |
| 13:45.06 | Ennea | official? not as far as i know, m^rk |
| 13:45.35 | Ennea | MooreaTv, probably. thing is, i just saved every argument to addmessage and replayed it like that |
| 13:45.43 | Ennea | so if the id is in there somewhere.. well, duplicates |
| 13:45.55 | Ennea | in any case, i removed that code and now it works. the one time i've tried at least |
| 14:12.31 | sylvanaar | chat scrollback is like the best feature |
| 14:12.50 | sylvanaar | honestly think it it my favorite chat mod feature |
| 14:13.48 | sylvanaar | It should be a requirement for any chat mod |
| 14:15.41 | Ennea | it is a good feature, but not if it breaks other things :D |
| 14:15.45 | Ennea | i'll need to look into that again |
| 14:15.55 | Ennea | perhaps stripping all the other arguments will do the trick |
| 14:16.04 | Ennea | well.. any non required ones |
| 14:16.31 | sylvanaar | what breaks? |
| 14:16.37 | sylvanaar | i wasn't following |
| 14:16.44 | sylvanaar | I suspect your implementation is the same as mine |
| 14:16.59 | Ennea | when reporting players from chat, it deletes their messages. not sure if all of them or just all recent ones |
| 14:17.17 | Ennea | when i leave my scrollback code in, a bunch of other messages get deleted as well |
| 14:17.33 | Ennea | like.. it also deleted a bunch of unrelated guild messages and a whisper close to the messages of the player i was reporting |
| 14:17.45 | Ennea | removed my scrollback code and it doesn't do that anymore (the one time i've tried since then) |
| 14:17.47 | sylvanaar | did you fix it |
| 14:17.50 | sylvanaar | can i see it? |
| 14:17.54 | Ennea | so far only by removing my scrollback code :D |
| 14:18.13 | Ennea | and my scrollback code is simple. i just hook AddMessage and write all its arguments to a table that keeps its own size at 20 entries |
| 14:18.21 | Ennea | on load, i just spit them out again using AddMessage |
| 14:18.23 | sylvanaar | seems like mine |
| 14:18.24 | Ennea | unpacking the arguments into it |
| 14:18.45 | Ennea | i wanna test reporting some more without the code |
| 14:18.51 | Ennea | no other messages to report so far sadly :) |
| 14:19.23 | sylvanaar | so it deletes them IN the scrollback once you load back in? |
| 14:20.03 | sylvanaar | or what |
| 14:20.44 | Ennea | no, the additional messages that are being deleted are always around the messages that are supposed to be deleted |
| 14:20.53 | Ennea | maybe it deletes some older ones as well, it's a bit difficult to keep track |
| 14:21.15 | sylvanaar | but this is during the game? not when you reload the scrollback |
| 14:21.26 | Ennea | yes, during |
| 14:21.28 | Ennea | let's say you got two offending channel messages, a whisper, a guild message, a party message, another two random channel messages from other users and a looted item message all in that order |
| 14:21.30 | sylvanaar | oh |
| 14:21.38 | Ennea | at that point in time i've been playing for an hour or so already, scrollback is long gone |
| 14:21.47 | Ennea | i report the player of the first two channel messages |
| 14:21.54 | Ennea | and it deletes those, the guild message and one of the channel messages |
| 14:21.56 | Ennea | none of the others |
| 14:22.01 | sylvanaar | i see |
| 14:22.13 | Ennea | something like that, essentially. but i'd need to analyze this more to be more specific about the exact symptoms |
| 14:22.21 | Ennea | difficult to test because it involves reporting players ^^ |
| 14:22.59 | foxlit | ... just replace the report function with one that does nothing. |
| 14:23.23 | Ennea | :D |
| 14:23.40 | Ennea | i feel like that's not an adequate solution ;p |
| 14:23.50 | Ennea | whatever is breaking may be affecting other things, too |
| 14:25.24 | Ennea | ugh.. well, i was just able to test it again, and it's not related to the scrollback after all |
| 14:25.47 | Ennea | i guess it might just be AddMessage hooks in general |
| 14:26.14 | Ennea | although this time, it deleted all the messages from the past 13 minutes. geez |
| 14:26.54 | sylvanaar | sounds like you are smearing the message ids or something causing them to be the same |
| 14:27.32 | Ennea | it does, but all i'm doing is three gsub()s on the message, and then calling the original AddMessage |
| 14:27.35 | Ennea | not modifying anything else |
| 14:27.47 | sylvanaar | can you show code |
| 14:27.59 | Ennea | sec, lemme strip all the weird comments that are still in there |
| 14:28.45 | Ennea | https://pastebin.com/338y3wfL |
| 14:29.03 | Ennea | this is inside a loop over all the chat frames |
| 14:32.52 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 14:33.49 | *** join/#wowuidev Arrowmaster (~Arrowmast@WoWUIDev/WoWAce/ResponsibleForEverythingAndNothing/Arrowmaster) |
| 14:34.53 | sylvanaar | are you stripping the identifier off the player by chance? |
| 14:35.42 | Ennea | nope |
| 14:35.58 | Ennea | and if i were, i guess that still wouldn't explain non-player messages being deleted as well |
| 14:36.33 | sylvanaar | yes because the identifier would be nil |
| 14:36.42 | sylvanaar | idk just theorizing |
| 14:37.21 | Ennea | good theory |
| 14:37.25 | Ennea | hm |
| 14:37.55 | Ennea | the identifier is the second "argument" in the player escape sequence, right? |
| 14:38.27 | sylvanaar | yeah |
| 14:38.38 | sylvanaar | why not dump your final version of the chat message somewhere |
| 14:38.44 | sylvanaar | and also dump the first one |
| 14:38.58 | sylvanaar | then we can see what are the real modifications you made to it |
| 14:39.12 | sylvanaar | that is what I do in prat - it helps immensely |
| 14:40.11 | Ennea | i've set something up that records the modified one now. the last 20, to be precise |
| 14:40.21 | sylvanaar | you need pre and post |
| 14:40.25 | Ennea | so i can look at them the next time before reporting a player, and see if maybe the identifier is borked |
| 14:40.30 | Ennea | yea, i should add pre as well |
| 14:40.30 | sylvanaar | i cannot live without /pratdebugmsg |
| 14:49.52 | Ennea | all looking good so far :/ |
| 14:49.56 | Ennea | nothing important is being stripped |
| 14:50.21 | Ennea | i wonder if it's not actually my doing. i'm gonna play with my chat addon disabled for a few hours and will try to see if it happens without it as well perhaps |
| 14:51.07 | sylvanaar | <PROTECTED> |
| 14:53.19 | Ennea | uhh |
| 14:53.26 | Ennea | i currently have nothing to copy them from |
| 14:53.34 | sylvanaar | awww |
| 14:53.34 | Ennea | i just throw them into a table and look at them via spew |
| 14:53.37 | Ennea | where do you dump them? |
| 14:53.46 | sylvanaar | its part of prat |
| 14:54.09 | Ennea | no, i mean.. |
| 14:54.12 | Ennea | where do your dumps end up? |
| 14:54.19 | sylvanaar | on a frame |
| 14:54.21 | Ennea | ah |
| 14:54.27 | sylvanaar | that you can copy from |
| 14:54.35 | sylvanaar | well first in the chat |
| 14:54.42 | sylvanaar | then i can copy from the chatframe |
| 14:55.04 | *** join/#wowuidev Andols (~yaaic@2a00:801:3fb:4019:f5cd:7234:726a:1fe6) |
| 14:55.44 | Ennea | best i can do right now :D https://i.imgur.com/eZSdXKd.png |
| 14:56.23 | sylvanaar | https://usercontent.irccloud-cdn.com/file/h8RncEHs/image.png |
| 14:56.46 | Ennea | that seems quite useful |
| 14:57.07 | sylvanaar | looks pretty sane |
| 14:57.25 | Ennea | yea, i'm not doing anything complicated either |
| 14:57.42 | Ennea | so i'm wondering if just the act of hooking addmessage itself breaks it |
| 14:57.46 | sylvanaar | I had a standalone addon that did chatframe copy - not sure that it still works or not |
| 14:57.49 | Ennea | or, as i said, if it's perhaps just broken because blizz broke it |
| 14:58.46 | sylvanaar | maybe |
| 15:04.49 | Ennea | hah |
| 15:04.55 | Ennea | okay, the bug exists even without my chat addon |
| 15:05.00 | Ennea | so it's blizz' fault |
| 15:05.19 | sylvanaar | hah |
| 15:05.54 | Ennea | previously, when i deemed it working without my addon, i wasn't waiting very long after reloading |
| 15:06.00 | Ennea | but now i was sitting in trade chat with the default ui |
| 15:06.16 | Ennea | and after a while reported somebody incredibly spammy, and it cleared a couple dozen other messages as well |
| 15:06.31 | Ennea | so i'm wondering if it only starts happening when the maximum number of messages in the frame has been reached |
| 15:06.39 | Ennea | in any case, not my bug, so i ain't gonna look into it anymore :D |
| 15:07.05 | Ennea | thank god i can have my scrollback back, too |
| 15:11.37 | Ennea | wowhead now facing problems as well. first gamepedia, then wowhead? hmm.. :p |
| 15:22.25 | *** join/#wowuidev Meorawr (~Meorawr@cpc96138-rdng26-2-0-cust327.15-3.cable.virginm.net) |
| 15:22.52 | Ennea | ah, looks like it was AWS dying |
| 15:22.55 | Ennea | multiple sites affected |
| 15:31.04 | znf | yup |
| 15:31.07 | znf | https://status.aws.amazon.com/ |
| 16:13.07 | sylvanaar | any redditors here use masstagger? |
| 16:16.45 | sylvanaar | https://www.reddit.com/r/masstagger/comments/cxx8y6/open_source/ |
| 16:18.20 | Ennea | first i've heard ofit |
| 16:18.21 | Ennea | *of it |
| 16:18.27 | talizea | nah, the default setting is insane (tags people from pewdiepie meme subreddits as far right lol) |
| 16:18.44 | Ennea | sounds pretty lame anyway |
| 16:19.12 | Ennea | if i find myself in a position where i need political views tagged, i'm clearly in the wrong sub |
| 16:19.49 | talizea | it's wide enough that like 20%+ of all users are tagged, instead of just the I don't know, *worst* 2% |
| 16:21.51 | talizea | I mod a 500k+ subreddit and don't need it at all, just use RES + toolbox |
| 16:22.38 | sylvanaar | anyone interested in making a competitor? |
| 16:23.36 | sylvanaar | u/morphen has created a fiefdom where he gets to say who is good and bad based on the mods default settings |
| 16:23.45 | sylvanaar | I think thats wrong - plus it is closed source |
| 16:25.33 | sylvanaar | its just some guy's personal politics made into an addon that nobody ever changes the default settings of |
| 16:26.26 | sylvanaar | and I am a liberal - I got the mod to tag T_D users |
| 16:26.35 | sylvanaar | but it has gone way too faR |
| 16:28.10 | talizea | in the past, people used https://absurdlyobfuscated.com/tagger/ to hack the tags into RES usernotes, but that was a bit messy |
| 16:29.40 | sylvanaar | I have a whole plan - but want collaborators |
| 16:30.28 | sylvanaar | what subreddits should I post on? |
| 16:30.39 | sylvanaar | to find supporters / collaborators |
| 16:31.01 | talizea | message https://www.reddit.com/user/creesch, he knows everyone |
| 16:33.05 | sylvanaar | aws issues I gues |
| 16:36.52 | sylvanaar | upvote my post! https://www.reddit.com/r/masstagger/comments/cxx8y6/open_source/ |
| 16:42.01 | foxlit | Frankly, your post sucks. |
| 16:43.43 | foxlit | it's vague unsubstantiated accusations coupled with "I'm an open source developer who believes in all the values..." nonsense. |
| 16:45.27 | foxlit | all while failing to explain what you're actually proposing ("this, but open source" isn't enough), and why that would be any better than the current state of affairs, whatever that is. |
| 16:46.10 | sylvanaar | why are you guys always so blunt |
| 16:47.27 | sylvanaar | Should I have said - u/morphen is not trustworthy enough to provide governance over what is considered "good" and "evil" by idiot users of the addon |
| 16:47.40 | sylvanaar | that more your style? |
| 16:48.16 | foxlit | what do you want, though? |
| 16:48.32 | foxlit | do *you* want to be the one providing governance over ... |
| 16:48.42 | foxlit | do you want there to be no defaults at all? |
| 16:48.46 | sylvanaar | I guess to make my own fucking one where people can pick which subreddits to add |
| 16:48.51 | sylvanaar | and yes |
| 16:48.54 | sylvanaar | no defaults |
| 16:49.01 | sylvanaar | they have to pick the ones they want |
| 16:49.49 | sylvanaar | not - the random one some guy thinks has people who post bad things |
| 16:50.00 | sylvanaar | how fucking stupid is that |
| 16:50.07 | sylvanaar | r/drama |
| 16:50.14 | sylvanaar | nazis are there |
| 16:50.18 | sylvanaar | wtf |
| 16:51.05 | sylvanaar | this guy wouldn't know good governance if it was being shoved up his ass |
| 16:51.41 | sylvanaar | is that better - should I be blunt like that? |
| 16:52.39 | foxlit | You should be whatever you want to be. I don't think the personal insults are helping you in any way, but examples of what you think is egregious might. |
| 16:53.09 | sylvanaar | which insults? |
| 16:53.35 | foxlit | "this guy wouldn't know good governance if it was being shoved up his ass" |
| 16:53.36 | sylvanaar | the ones I just said here in my meltdown |
| 16:53.40 | sylvanaar | oh yeah |
| 16:53.43 | sylvanaar | i agree |
| 16:54.32 | sylvanaar | i was venting |
| 16:57.13 | sylvanaar | you know I'd like to be used to find other Typescript developers on reddit |
| 16:57.24 | sylvanaar | not just for negative purposes |
| 17:00.12 | znf | what's a masstagger? |
| 17:01.39 | znf | ah, political crap |
| 17:01.51 | znf | just stay away from political subreddits |
| 17:07.33 | nebula | avoid politics? impossible! |
| 17:11.55 | znf | this AWS outage is annoying |
| 17:12.00 | sylvanaar | I wan489 |
| 17:12.03 | znf | no reddit, no wowhead, and other websites |
| 17:12.03 | sylvanaar | no shit |
| 17:12.10 | znf | too much internet depends on AWS |
| 17:14.30 | Alram | too much of the internet depends on a single AWS region* |
| 17:15.25 | sylvanaar | not to go on and on but look at this dudes post history: https://old.reddit.com/user/morpen, I am supposed to trust him to follow good governance |
| 17:15.37 | sylvanaar | im sorry that was the last one ill stop |
| 17:17.51 | znf | the reddit links don't work |
| 17:17.54 | znf | and it's frustrating |
| 17:34.29 | sylvanaar | Annoying |
| 17:37.34 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:46.36 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 17:46.36 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 18:28.34 | *** join/#wowuidev ScytheBlade1 (~Death@about/pxe/ScytheBlade1) |
| 18:33.50 | Gnarfoz | wasn't the point of AWS and stuff like it that it should be super resilient? I guess people just rely on multi-AZ and not multi-region? |
| 18:34.00 | Gnarfoz | (and region-wide outages are far too common) |
| 18:35.27 | Gnarfoz | apparently, this was a single-AZ outage, tho |
| 18:35.31 | Gnarfoz | so, wtf cloud people |
| 18:35.41 | Ennea | yea, it looks like people don't set it up super well |
| 18:37.40 | Gnarfoz | that would seem to be AWS hosting 101 shit |
| 18:42.27 | znf | as someone who tried to figure out the AWS eco-system by himself... that shit is pretty hard |
| 18:43.49 | znf | as in, the AWS toolkit & lingo is kind of hard to master, so some people just don't bother figuring out more than the basics |
| 18:44.30 | Gnarfoz | I know exactly what you mean |
| 18:45.08 | znf | I've turned down multiple people who wanted to migrate their small to medium business to AWS |
| 18:45.13 | Gnarfoz | but being able to quickly spin up your $everything in another AZ should be something someone as big as reddit should be able to handle :D |
| 18:46.08 | znf | true, no excuse at that level |
| 18:50.55 | Ennea | hm, reddit was available to me throughout all of this at least |
| 18:50.59 | Ennea | wowhead was done for quite a while |
| 19:11.25 | Gnarfoz | was just sluggish as hell for me |
| 19:33.35 | znf | 9 out of 10 requests were errors to reddit for me |
| 19:33.38 | znf | it's better now, yes |
| 19:42.02 | Ennea | hm |
| 20:05.29 | Ennea | bleh.. IsCombatLog() isn't actually super helpful. it returns false for all chat frames on load |
| 21:29.41 | m^rk | does curseforge have any support to help the same addon to work in retail and classic - such as a way to supply a different TOC files or does it require a different projects? |
| 21:31.22 | Gnarfoz | I think you need to publish a version that has the "Game version" set to 1.13.2 |
| 21:31.30 | Gnarfoz | and it will be picked up by the client as usable for Classic |
| 21:31.35 | Gnarfoz | or somesuch |
| 21:31.46 | m^rk | ok thanks, interesting |
| 21:32.18 | nebula | setting both on one file was known to cause problems, though, i'm not sure if that is fixed |
| 21:32.28 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 22:00.04 | foxlit | https://www.townlong-yak.com/box/39apfE.lua |
| 22:03.13 | MooreaTv | I have a ticket open with curseforge because I noticed some addons don't show up in twitch despite having 1.13.2 versions on curseforge - it seems the api fails to return them and "gameVersionLatestFiles": [], in some of the json |
| 22:03.43 | MooreaTv | (or 1 of the 2, I have addons only showing in classic and some only in bfa and some not showing at all) |
| 22:04.42 | foxlit | theoretically, that shows which variables are read/which functions are called before calling functions/writing to variables, as well as which functions might end up being called / which variables might end up being written to if you call a function. |
| 22:08.25 | foxlit | for example, if we consider HideUIPanel to be "protected", it's probably a bad idea to call AuctionFrame_Hide or write to UIErrorsFrame.AddMessage. |
| 22:09.54 | *** join/#wowuidev Ketho (~Ketho@2a02:a44e:ac87:1:f966:a9ab:bc8d:49d7) |
| 22:11.06 | foxlit | (I think that fragment is just looking at Blizzard_AuctionUI.) |
| 22:28.23 | MooreaTv | are you talking about an upcoming globe warning/lint check? |
| 22:32.04 | Gnarfoz | sounds like taint research |
| 22:33.11 | foxlit | assuming everything works, maybe. |
| 22:34.57 | MooreaTv | is the source of your checks available somewhere? I'd like to run some locally without making zips each time |
| 22:35.35 | foxlit | nope. |
| 22:36.55 | Gnarfoz | his voodoo is too strong for the general public |
| 22:38.49 | foxlit | but have a convenient makefile one-liner: git archive --prefix `basename $$PWD`/ --format zip -9 head | curl -F q=@- https://www.townlong-yak.com/globe/api/upload-archive | xargs open |
| 22:39.13 | foxlit | (might need to adjust if you don't have open) |
| 22:40.34 | MooreaTv | it's nice you produce json though and not some rendered html |
| 22:41.15 | MooreaTv | ah thx, that's nice too |
| 22:42.40 | Ketho | Chipzz: I'll mark the arbitrary link type arguments |
| 22:42.48 | Ketho | but yea they probably should be on their own page now |
| 22:50.19 | Chipzz | cool; there's also a discussion with Dan that adds some info to the |T tag that's not in the wiki atm |
| 22:50.40 | Chipzz | but I need to dig through my logs to find these :) |
| 23:00.03 | Chipzz | Ketho: http://chipzz.safehex.be/ui_escape_sequences |
| 23:04.45 | Ketho | nice |
| 23:05.31 | Chipzz | it's been in my mental TODO list for like forever, should make a wiki account and do the edit |
| 23:05.50 | Chipzz | but if you want to pick that up and make the corrections, WFM too |
| 23:06.23 | Ketho | I don't know much about textures so I'd just copypaste it |
| 23:08.53 | Ketho | holy moly that's a lot of color formatting |
| 23:30.43 | *** join/#wowuidev Andols (~yaaic@2a00:801:20c:3ef7:b78d:80aa:b990:a731) |
| 23:54.44 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 23:58.26 | *** join/#wowuidev Andols (~yaaic@2a00:801:300:4ec9:c592:c748:ae4d:3226) |
| 23:59.31 | Gnarfoz | rip "Classic" Ragnaros |
