| 15:43.00 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 15:43.00 | *** topic/#wowuidev is WoW Classic Beta Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.1.x ToC: 80100 || http://pastebin.com || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl || Currently mode +r due to spam until a better solution is found. |
| 16:09.31 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 16:09.31 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 16:40.47 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 16:42.50 | *** part/#wowuidev whydb (~whydb@ec2-3-9-122-80.eu-west-2.compute.amazonaws.com) |
| 16:46.47 | *** join/#wowuidev alestane (~nevin@pool-71-248-186-95.bstnma.fios.verizon.net) |
| 16:46.48 | *** mode/#wowuidev [+v alestane] by ChanServ |
| 17:18.35 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 17:26.00 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 17:26.41 | Alram | 8.2.5 PTR is up |
| 17:26.44 | Alram | For those wanting to test uh, things |
| 17:30.37 | AcidWeb | new build? |
| 17:35.18 | Simca | same build |
| 17:36.12 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:57.47 | Stanzilla | TSquare Crosshash EditBox is still broken in 8.2.5 :( |
| 17:57.52 | *** join/#wowuidev Ackis (~Ackis@WoWUIDev/WoWAce/ARL/Troll/Ackis) |
| 17:58.28 | Crosshash | I don't know what the status is, I'll ask |
| 17:59.55 | Stanzilla | thanks |
| 18:06.08 | Chipzz | TSquare, Crosshash: is either of you still interested in the XSD and XML validation work I did in the past? I suppose it's low prio but just asking |
| 18:13.45 | nevcairiel | Since its bug the devs day, do you have a nice explanation what makes the new UnitAura functions nice? :D |
| 18:14.59 | Crosshash | What's the validation work do? |
| 18:16.59 | Crosshash | New UnitAura avoids multiple iterations to find the aura by index |
| 18:17.21 | nevcairiel | so the index-based functions basically iterated internally everytime? |
| 18:17.22 | nevcairiel | i see |
| 18:17.54 | nevcairiel | i suppose they had to, so they could apply filters on the overall buff list |
| 18:18.29 | Crosshash | Yeah, now it sucks a little less |
| 18:44.27 | Chipzz | Crosshash: enable XML validation with the .xsd and xmllint; there's fixes to the XSD and there's fixes to small bugs in the XML |
| 18:44.55 | Chipzz | Crosshash: TheDanW told me he logged an issue with what I submitted in your internal issue tracker IIRC |
| 18:46.12 | Chipzz | Crosshash: the point is that if someone wants to make the effort to incorporate the changes I made it would probably be possible to add xmllint as a step to the build/QA infra |
| 18:47.13 | Crosshash | Is this the one from 2017? |
| 18:47.40 | Chipzz | probably yeah |
| 18:48.12 | Chipzz | but if it's too outdated I'ld be willing to update my work from back then |
| 18:49.57 | Chipzz | I know at least part of it is outdated since I didn't update it for the new intrinsics that were added; but then that's a minor thing, just adding a couple of lines to the .xsd |
| 18:51.41 | *** join/#wowuidev LexAwayFromHome (~lexlexlex@s154-5-197-130.bc.hsia.telus.net) |
| 18:59.28 | Funkeh` | new UnitAura? |
| 19:01.38 | znf | ... |
| 19:01.41 | znf | are you fucking kidding me |
| 19:01.50 | znf | 9pm event bugged again |
| 19:01.56 | znf | I got the debuff without the event starting |
| 19:03.09 | znf | https://i.imgur.com/BL0s4ws.png |
| 19:14.55 | Simca | yikes |
| 19:15.36 | Simca | yeah they removed index-based UnitAura iteration a while ago, like 8.1? something like that |
| 19:16.18 | znf | hey Simca, code my aura scanner |
| 19:17.05 | znf | https://pastie.dev/SAOu26.sql - line 219 |
| 19:17.14 | znf | if I enable the code for aura returning, my FPS drops to 10 in raids :( |
| 19:21.55 | Funkeh` | Simca: they are talking about a new UnitAura on PTR so... |
| 19:22.19 | Simca | oh ok |
| 19:22.33 | Crosshash | Chipzz: funny, it turns out I was the one that applied what you submitted (or most of it) in 7.3.5 |
| 19:34.21 | znf | wowpedia claims that the index (2nd argument to UnitBuff/UnitAura) is from 1 to 40 |
| 19:34.28 | znf | but, what happens if there are more than 40? |
| 19:36.17 | Crosshash | I think that's old. There is no 40 limit. |
| 19:39.00 | Chipzz | Crosshash: oh nice :) unfortunately, my latter submission didn't get followed up upon ;( but if you feel like picking it up again, lemme know |
| 19:42.26 | znf | is there any possible way I could improve this code somehow so it doesn't murder my CPU? https://pastie.dev/MFY7xe.sql |
| 19:48.27 | Crosshash | Chipzz: sure |
| 19:56.35 | mikma | so, wowc open beta in couple of days? |
| 20:01.53 | Maldivia | 8th, I think |
| 20:08.56 | nevcairiel | Simca: index-based iteration was not removed, in fact it was made the only option we had because name-based lookup was removed instead, but apparently index-based in really inefficient, so now we get a proper "iterator" |
| 20:09.19 | Simca | ahh okay |
| 20:09.24 | Simca | i had it backwards |
| 20:10.18 | Simca | maybe that code znf posted will be less murdersome on the ptr |
| 20:10.59 | znf | Can't test without a boss |
| 20:12.03 | nevcairiel | FindAuraByName should be more efficient - however, if you really wanted it to be good, you would change INDICATOR_AURAS to be a lookup table and only iterate over the auras once and check if its in the table |
| 20:14.33 | znf | Not sure what a lookup table is |
| 20:15.27 | znf | I was thinking similarly to just iterate over all the auras on the mob (how exactly do you do that, do you just loop from 1 to 9999 with UnitAura() ?) and storing them in a table and then comparing, but I'm sure Lua has something better |
| 20:15.30 | *** join/#wowuidev Sintacks (Sintacks@75-109-20-148.chlncmtk01.res.dyn.suddenlink.net) |
| 20:16.00 | znf | or is there an api call to get the number of auras on a target? |
| 20:16.38 | Simca | you used to loop with UnitAura, now on the ptr apparently you get an iterator object I guess |
| 20:16.48 | Simca | so you loop with that, i'd imagine |
| 20:17.11 | znf | But how do you know when the stop the loop? |
| 20:22.49 | znf | as in: for i=1,999 do table.insert(UnitAura('unit', i, 'filter')) end |
| 20:22.54 | znf | how do I know there's not more than 999? |
| 20:23.03 | Simca | when you find what you're looking for or when the iterator goes to nil (or however it's set up) |
| 20:23.27 | Simca | so like. while UnitAuraIterator() do --stuff here end |
| 20:24.25 | Simca | or something like: while true do local a, b, c, d, e = UnitAuraIterator() if (a = nil) break end end |
| 20:24.31 | Simca | == nil* |
| 20:24.40 | Simca | but it depends on how they implemented it, I haven't looked yet |
| 20:25.56 | znf | And until 8.2.5? :P |
| 20:26.26 | znf | as in, how are people doing it now? |
| 20:26.52 | znf | they just check if UnitAura() returns nil and break? |
| 20:26.57 | Meorawr | Same principle, yeah |
| 20:29.30 | nevcairiel | even today, your loop is basically inside out and would be more efficient if it was the other way around |
| 20:34.53 | znf | function iterateAuras(target); auraIndex=0; local auraTable; while UnitAura(target, auraIndex) do auraTable.insert(UnitAura(target, auraIndex)); auraIndex=auraIndex+1 end; return auraTable; end |
| 20:34.54 | znf | ? |
| 20:35.06 | nevcairiel | no tables. |
| 20:37.28 | *** join/#wowuidev TomCat (~IceChat9@unaffiliated/tomcat) |
| 20:37.47 | TomCat | Good afternoon, friends |
| 20:41.59 | znf | so, uhm, local INDICATOR_AURAS = { "Ice Block"={"stuff"}, "Spell Reflection"={"other stuff"} }; function iterateAuras(target); auraIndex=0; while UnitAura(target, auraIndex) do local aura = UnitAura(target,auraIndex); return INDICATOR_AURAS[aura[0]]; auraIndex=auraIndex+1 end; return auraTable; end |
| 20:42.00 | znf | ? |
| 20:42.20 | znf | without the return auraTable, obviously |
| 20:42.44 | nevcairiel | well obviously you would check if its actually a m atch before returning |
| 20:42.50 | znf | writing this in one-line is hard |
| 20:42.52 | nevcairiel | but something like that |
| 20:43.06 | nevcairiel | only one iteration over all auras |
| 20:43.13 | nevcairiel | and not one per aura in your table |
| 20:43.22 | nevcairiel | already cut down by potentially a lot |
| 20:46.07 | znf | ok, so, like if INDICATOR_AURAS[aura[0]] then return aura end |
| 20:46.16 | znf | but now how do I also return the extra data I have in INDICATOR_AURAS |
| 20:46.27 | znf | actually, I wonder... do I even care for that, hmmm |
| 20:46.58 | nevcairiel | also its not aura[0], it doesnt return a table, it returns a list, and the name is first |
| 20:47.00 | nevcairiel | so just aura |
| 20:47.27 | znf | this is insanely old code, I only need aura name and timer, and I bet I can just return the proper color from debuffType |
| 20:47.31 | znf | ah, ok |
| 20:48.45 | znf | wait, if it's a list, I then the whole list to be returned back |
| 20:51.04 | znf | I'm assuming table.pack is not a good idea |
| 21:00.22 | znf | nevcairiel, one more thing - my old code had a sort of priority, so I would add the most important ones at the top of my table, but using it like I mentioned above will obviously return the first one it finds |
| 21:00.35 | znf | So if I want to have a priority, I'd have to go the other way around, presumably? |
| 21:01.27 | nevcairiel | priorities are annoying because your most important one could be at the end of the list of course |
| 21:01.56 | nevcairiel | but you could save which you found a nd then sort them later |
| 21:15.09 | znf | I'm failing to see what I did wrong here: https://pastie.dev/Flqn68.bash |
| 21:16.06 | znf | iterateAuras("player") returns nil, even tough I have Power Word: Fortitude on me |
| 21:16.17 | znf | oh |
| 21:16.46 | znf | indexes start at 1, doh |
| 21:16.47 | nevcairiel | your table is wrong |
| 21:16.53 | nevcairiel | it should be keys, n ot values |
| 21:17.23 | nevcairiel | wrap every entry in something like [...] = true, or so |
| 21:23.11 | znf | oki doki, that works, thanks |
| 21:28.20 | znf | nevcairiel, is there a char limit on the text on suf bars? |
| 21:28.32 | nevcairiel | dont think so |
| 21:28.36 | nevcairiel | but you would run out of space |
| 21:29.04 | znf | https://i.imgur.com/RWVyAEk.png |
| 21:29.09 | znf | it gets ... :P |
| 21:29.18 | nevcairiel | yeah thats the space l imit :p |
| 21:29.49 | nevcairiel | you can change the allocation or something so that the left part gets more space then the right part |
| 21:31.07 | znf | hmmm, it does seem to work for my own auras, when I tested with the stamina buff, but not on mobs in the wild with mind bomb |
| 21:33.47 | *** join/#wowuidev AcidWeb (~AcidWeb@londe.iosphe.re) |
| 21:38.56 | znf | oh, String (optional) - list of filters, separated by spaces or pipes. "HELPFUL" by default. The following filters are available: |
| 21:38.57 | znf | ok... |
| 21:47.48 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:48.43 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 22:48.43 | *** mode/#wowuidev [+o Seerah] by ChanServ |
