| 00:18.25 | *** join/#wowuidev purl (ibot@c-174-52-60-165.hsd1.ut.comcast.net) |
| 00:18.25 | *** topic/#wowuidev is WoW Classic Beta Addon Cat: https://www.wowinterface.com/downloads/cat160.html || 8.1.x ToC: 80100 || http://pastebin.com || Battletags: http://bit.ly/2MAEFxk || This channel is logged, via purl || Currently mode +r due to spam until a better solution is found. |
| 00:22.51 | Mr_Rabies | oh man these intro to 8.2 quests are killing me on alts |
| 00:22.55 | Mr_Rabies | think i'm done with alts for now lol |
| 00:29.43 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 00:44.37 | znf | yeah, doing both mechagon and nazjatar on a single alt is painful |
| 01:15.28 | *** join/#wowuidev Andols (~yaaic@2a00:801:205:9c5e:d86f:7e54:da86:9dd6) |
| 01:19.46 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:df2:7adb:777b:b356) |
| 01:44.53 | *** join/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 01:44.53 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 01:51.01 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 02:02.12 | nebula | SetHighlightTexture |
| 02:02.38 | nebula | that's not the search box |
| 02:02.48 | Simca | is there a good way to narrow down the :ShowUIPanel taint? |
| 02:02.52 | Simca | also why is it tainting lol |
| 02:03.16 | nebula | not taint, the function bails in combat for non-secure code |
| 02:04.07 | nebula | https://www.townlong-yak.com/framexml/live/UIParent.lua#3195 |
| 02:04.27 | nebula | er, few lines up |
| 02:05.02 | Simca | '/m' fails to open the macro panel in combat |
| 02:06.45 | nebula | "bails in combat for non-secure code" i guess that is the definition of tainting :p |
| 02:07.55 | nebula | i'd just grep for the macro panel in your addons dir, probably faster than weeding through taintLog 2 |
| 02:10.25 | Simca | it blames Prat-3.0 in the taintLog 2 output |
| 02:12.28 | Simca | Well, to be precise, it blames about 10 things for it in that millisecond it errored |
| 02:12.51 | Simca | Details, Ace3 (many times), and Prat-3.0 |
| 02:15.28 | Simca | it doesn't error with prat disabled |
| 02:15.42 | Simca | is it even possible for prat to make that action secure, though? |
| 02:16.12 | Simca | it's a chat window replacement, can it not interfere with /m enough to make it work without sacrificing what it does |
| 02:16.50 | nebula | i use prat and don't get an error |
| 02:16.58 | Simca | strange |
| 02:17.12 | Simca | must be a combination of addons, but it doesn't manifest without prat enabled |
| 02:20.39 | nebula | oh that's a lie, i don't have prat for this alt |
| 02:20.51 | Simca | you're right anyway |
| 02:20.58 | Simca | i poked 3 guildies with prat, they have no issues with it |
| 02:21.11 | Simca | for me, the issue is 100% consistent until prat is disabled |
| 02:27.27 | znf | why would you still use prat? :P |
| 02:27.38 | nebula | change is hard |
| 02:54.18 | Simca | change to what? |
| 02:54.39 | Simca | i thought it was just chatter and prat and chatter is dead |
| 03:08.52 | *** join/#wowuidev jaxdahl2 (jaxdahl@unaffiliated/jaxdahl) |
| 03:13.06 | *** part/#wowuidev Seerah (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 03:22.44 | *** join/#wowuidev TSquare (~tomthomps@198.74.35.2) |
| 03:22.45 | *** mode/#wowuidev [+o TSquare] by ChanServ |
| 03:57.59 | znf | Simca, BCM |
| 03:58.14 | znf | https://www.curseforge.com/wow/addons/basic-chat-mods |
| 03:58.19 | znf | Funkeh` is still around and kicking :P |
| 04:43.56 | Mr_Rabies | can i move my editbox to the top and other such good stuff from prat with BCM? |
| 04:44.57 | Mr_Rabies | a lot of addons could really use better descriptions on twitch, i can't really tell most of what BCM does by looking at its page |
| 04:56.07 | Mr_Rabies | can do almost everything i do with prat, but can't do sounds on messages :O |
| 05:22.05 | Simca | that's fine for me |
| 05:22.10 | Simca | sounds nice, will DL and replace prat |
| 05:22.16 | Simca | that will solve my taint good enough for me |
| 05:50.06 | *** join/#wowuidev A-KO (A-KO@136.52.64.157) |
| 06:37.57 | *** join/#wowuidev brykrys (~brykrys@WoWUIDev/Norganna/Dev/Brykrys) |
| 07:17.28 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 10:32.50 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 10:49.07 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 14:02.37 | sylvanaar | Im kinda surprised it does that |
| 14:06.22 | sylvanaar | if you make a macro to open the macro pane and put it on the action bar, it doesn't work either |
| 14:08.49 | nevcairiel | the taint goes deep |
| 14:12.38 | Funkeh` | I think I figured it out |
| 14:12.50 | Funkeh` | I think it's anything that hooks ItemRefTooltip |
| 14:13.55 | Funkeh` | https://www.townlong-yak.com/framexml/live/ItemRef.lua#391 |
| 14:15.05 | nebula | i would be nice if blizzard added a nice way to add custom link handlers |
| 14:15.16 | nebula | it* |
| 14:16.05 | nebula | or just bailed if it didn't find a link it wanted to handle so you could just post hook it |
| 14:17.04 | Funkeh` | thats exactly what should happen :P |
| 14:17.43 | Funkeh` | bust last time we brought it up I think it was with Dan he started talking about implementing a proper system which doesn't seem to have panned out |
| 14:19.11 | *** join/#wowuidev Meorawr (~Meorawr@cpc96138-rdng26-2-0-cust327.15-3.cable.virginm.net) |
| 14:19.36 | ThiefMaster | is there any addon that shows a clickable link for anyone who just left the party? i want to whisper people who leave without a comment, but that's almost impossible if they have weird names and never wrote anything in chat so i could click their name there.. |
| 14:40.35 | sylvanaar | so hooking SetItemRef? lol |
| 14:44.18 | sylvanaar | I could probably do it thiefmaster, idk it would be a huge pain to develop though without my second account being active |
| 14:45.31 | Funkeh` | aren't the majority of leavers just server hoppers |
| 14:46.43 | sylvanaar | nebula: yeah if you want to do custom links you have to deal with "* tainted my UI" - pretty lame |
| 14:58.23 | Simca | why on earth would taint to ItemRefTooltip propagate to MacroPanel:ShowUIPanel() |
| 14:58.38 | Simca | that must be a bizarre pathway |
| 14:59.23 | Simca | well actually it's ShowUIPanel(MacroFrame) |
| 14:59.26 | Simca | but yeah |
| 15:18.07 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 15:40.26 | Funkeh` | shrug, I figured out a way to use a secure hook in BCM so I'm done as far as I'm concerned :p |
| 15:51.12 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 15:56.50 | *** join/#wowuidev Andols (~yaaic@2a00:801:205:9c5e:4aa7:57d5:ae0a:8d95) |
| 16:00.03 | *** join/#wowuidev MiRai (~MiRai@unaffiliated/mirai) |
| 16:07.25 | sylvanaar | I hook SetHyperlink |
| 16:07.59 | sylvanaar | fully |
| 16:11.02 | sylvanaar | I dont hook SetItemRef except in one place where i use a posthook |
| 16:18.49 | *** join/#wowuidev Andols (~yaaic@2a00:801:340:70f8:588d:2c10:fc6c:f2ec) |
| 16:41.45 | MiRai | Did the information that /fstack provides change? It used to show the names of frames, but now it's just "UIParent" followed by a string of alphanumerics. |
| 16:42.28 | MiRai | Oh, wait... I pressed a modifier and new information has appeared. |
| 16:42.30 | AcidWeb | /run SetCVar("fstack_preferParentKeys", 0) |
| 16:43.04 | MiRai | AcidWeb: Nice, thanks. |
| 16:44.07 | Funkeh` | Simca: dunno if you swapped or not, but I pushed a new BasicChatMods which should now have 0 insecure hooks |
| 16:46.21 | Simca | yeah, sylvanaar, the problem I am having is not with Prat alone, it can't be. I've talked with many others with the same version who cannot reproduce the taint. It must be a combination of addons. However, removing Prat from that combination does fix the issue, so it's involved somehow. |
| 16:46.30 | Simca | Funkeh`: thanks |
| 16:55.22 | sylvanaar | Simca: thanks for letting me know. |
| 17:02.27 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 17:11.53 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:3f8:fd63:512a:8f2c:a96b:d348) |
| 17:24.52 | *** join/#wowuidev A-KO (A-KO@2605:a601:a70e:c800:ad30:8bc6:4d2f:6ac) |
| 17:35.39 | *** join/#wowuidev Breeni (~Breen@80.175.117.105) |
| 17:39.08 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 18:00.23 | *** join/#wowuidev Andols (~yaaic@2a00:801:3f8:fd63:512a:8f2c:a96b:d348) |
| 18:05.05 | Simca | just got an 'interface action failed' when clicking on a chat link without Prat enabled, will look at taint log, maybe i can narrow down what other addon i have that's causing a problem in Prat |
| 18:20.35 | sylvanaar | Prat gets blamed for everything - i think really because of how early it loads |
| 18:21.20 | *** join/#wowuidev Andols (~yaaic@2a00:801:341:cfbe:eb48:fa41:abf9:170c) |
| 18:22.58 | sylvanaar | i have the same problem when I try to open the macro window in combat - so let me know. I probably have whatever other addon it is |
| 18:24.24 | nevcairiel | "P" isn't particularly early in the alphabetical loading order |
| 18:33.14 | sylvanaar | oh cmon |
| 18:34.11 | sylvanaar | I list all these optional deps ## OptionalDeps: Prat-3.0_Libraries, LibSink-2.0, LibSharedMedia-3.0, AceGUI-3.0-SharedMediaWidgets, LibDataBroker-1.1, LibDBIcon-1.0, LibAlts-1.0, LibChatAnims |
| 18:34.32 | sylvanaar | seems to cause me to load early |
| 18:38.41 | sylvanaar | Ok maybe i am wrong - I think I recall loading early when I used to use LoadsWith |
| 18:39.46 | sylvanaar | but somehow Prat seems to host the embedded libraries instead of other addons - idk why that is |
| 18:39.58 | nevcairiel | Optional Deps cause the other things to load when you load, not the other way around :) |
| 18:40.10 | sylvanaar | indeed |
| 19:05.28 | *** join/#wowuidev Andols (~yaaic@2a00:801:341:cfbe:eb48:fa41:abf9:170c) |
| 19:05.31 | foxlit | Simca: '/m' fails to open the macro panel in combat << more or less every addon registering a slash command should do that. |
| 19:06.05 | Simca | hours and hours of play without prat and i have not had an issue despite dozens of other addons that register slash commands |
| 19:06.21 | Simca | with prat enabled, the taint is instant and 100% reproductible |
| 19:06.30 | Simca | it is pretty weird |
| 19:07.26 | foxlit | seems rather boring. You taint the insecure command dispatch, it fails when it tries to ShowUIPanel. |
| 19:08.12 | foxlit | It's more or less the same mechanism that meant people couldn't /quit before they moved that to secure commands earlier. |
| 19:08.17 | nevcairiel | just ask them to move it to the secure dispatcher |
| 19:08.24 | nevcairiel | not that I think that slash command is that crucial |
| 19:10.44 | foxlit | it's a bit weird that you can do that despite the early, secure ChatFrame_ImportAllListsToHash call, but meh, that applies to /quit as well. |
| 19:17.50 | Simca | i mean the part i think is weird is that Prat alone doesn't cause this issue, it's some sort of combination of addons, neither enough by itself but together they can taint it |
| 19:29.27 | Simca | 7/20 14:04:07.014 Execution tainted by WeakAuras while reading SetItemRef - Interface\FrameXML\ChatFrame.lua:3721 |
| 19:29.27 | Simca | <PROTECTED> |
| 19:30.14 | Alram | a Stanzilla classic |
| 19:32.23 | foxlit | it doesn't write it by default, so you imported something? |
| 19:32.44 | *** join/#wowuidev Seerah1 (~umsin@75-36-111-192.lightspeed.mmphtn.sbcglobal.net) |
| 19:32.44 | *** mode/#wowuidev [+o Seerah1] by ChanServ |
| 19:33.09 | Simca | possible |
| 19:33.12 | Simca | 7/20 10:58:57.237 Global variable SetItemRef tainted by WeakAuras - Interface\AddOns\WeakAuras\Transmission.lua:590 |
| 19:33.18 | Simca | that's the exact line it gives |
| 19:34.55 | foxlit | probably function ItemRefTooltip:SetHyperlink(link, ...) (:589) |
| 19:36.03 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 19:36.09 | Vardex | Should be fixed in next release https://github.com/WeakAuras/WeakAuras2/pull/1460 |
| 19:36.50 | foxlit | no, that made it worse for Simca -- I'm looking at the "old" version. |
| 19:37.25 | foxlit | btw, protip: use "garrmission:x:" as a link prefix and hooksecurefunc SetItemRef. |
| 19:38.46 | *** join/#wowuidev jaxdahl (jaxdahl@unaffiliated/jaxdahl) |
| 19:39.20 | Stanzilla | yeah should be fixed |
| 19:39.51 | Stanzilla | or are yo usayin gthe fix is bad foxlit |
| 19:41.26 | Funkeh` | yes, the reason everyone moved from SetItemRef to .SetHyperlink was to avoid previous sources of taint, where you're in the execution path of all those other commands |
| 19:41.59 | MooreaTv | foxlit- is it possible to make "Classic-removed" a different color (like green instead of red) if it's within an if ? (eg https://github.com/mooreatv/DynamicBoxer/blob/master/DynamicBoxer/DBoxUI.lua#L855 ) |
| 19:43.28 | Simca | i don't have the same problem those people on github did. it's not with the dressing room, just with clicking on item links in chat in combat. and it's not consistent |
| 19:43.50 | Simca | it also doesn't actually block the tooltip from appearing. it just complains anyway |
| 19:45.36 | Stanzilla | Funkeh` foxlit better suggestion then? |
| 19:46.13 | Funkeh` | It's not the solution I used, but it wil work better than mine |
| 19:46.36 | Funkeh` | the one he already suggested |
| 19:47.49 | Funkeh` | Personally I only need numbers so I hooked FloatingPetBattleAbility_Show and used battlePetAbil as the link |
| 19:50.12 | Funkeh` | you would use garrmission:data:data:... as the link |
| 19:50.29 | Funkeh` | if you don't use a number as the first bit of data it will silently return |
| 19:51.01 | Funkeh` | local garrMissionID, garrMissionDBID = link:match("garrmission:(%d+):([0-9a-fA-F]+)") |
| 19:51.37 | Funkeh` | you want that to fail, then you just hooksecurefunc SetItemRef and do your own scanning in that |
| 19:53.12 | Funkeh` | "garrmission:weakauras:data:" would do it |
| 20:03.39 | *** join/#wowuidev Andols2 (~yaaic@2a00:801:2c0:ce19:b378:f6d3:e289:81d4) |
| 20:03.49 | Nimhfree_ | does anyone know if there is a way in classic to get something like this to work: tooltip:SetHyperlink(strformat("quest:%d", questId)) |
| 20:06.38 | *** join/#wowuidev pompy (~Mike@2601:87:4101:92f0:df2:7adb:777b:b356) |
| 21:29.59 | Simca | caching unknown quests? not sure. if it uses the 8.x cache system, it should work fine, but the server for 1.13 may be more restrictive of information |
| 22:20.49 | *** join/#wowuidev Andols (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:32.25 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 22:33.15 | *** join/#wowuidev VIad (~Vlad@cm-84.213.147.218.getinternet.no) |
| 22:37.39 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 22:37.46 | Simca | i have a feeling we talked about this before but i forgot the answer - if my email or username (tried both, including old email) + password combination isn't working to push to my repos, is there any reasonable way to fix that |
| 22:37.58 | Simca | (for curseforge) |
| 22:47.47 | MooreaTv | simca- can you access https://authors.curseforge.com/account/api-tokens ? if so, use that ? |
| 23:00.48 | Simca | how? just put in an api key for password? |
| 23:01.17 | Simca | or do you mean create a new repository at another site, set up stuff there, then create a webhook |
| 23:01.20 | Simca | for every project i have |
| 23:01.31 | Simca | because i could do that, it's just daunting |
| 23:01.41 | nevcairiel | use an api key as password |
| 23:02.10 | Simca | nowhere on the knowledge base is that suggested as a possibility, including https://authors.curseforge.com/knowledge-base/projects/3453-repository-migration |
| 23:02.16 | Simca | but i'm not too surprised |
| 23:03.33 | nevcairiel | no idea if thats intentional or if auth is just bugged, but getting answers from them is almost impossible, and the workaround works fine |
| 23:03.44 | Simca | yep that completed instantly without issue |
| 23:03.45 | Simca | thanks |
| 23:08.04 | MooreaTv | yw :) |
| 23:08.47 | MooreaTv | also using auto pull/auto build from say github, is very nice once setup and the setup isn't that daunting I think |
| 23:09.16 | Simca | i just have like 6 active addons |
| 23:11.18 | MooreaTv | plenty to get benefits, and not too many to setup :) |
| 23:24.25 | *** join/#wowuidev MooreaTv (~MooreaTV@172-10-234-41.lightspeed.sntcca.sbcglobal.net) |
| 23:46.10 | *** join/#wowuidev jaxdahl2 (jaxdahl@unaffiliated/jaxdahl) |