| 00:07.10 | *** join/#wowuidev Corrodias (~no@2600-6c44-6d00-0e86-74ca-d067-f205-67c9.dhcp6.chtrptr.net) |
| 00:07.20 | Corrodias | why, what's the downside of the expansion pack including other stuff? |
| 00:16.52 | kd3 | sighs in $dayjob |
| 00:16.54 | kd3 | What the hell is the point of a form validator if you just discard the output of the validation? Grrrrrrrrrrrr |
| 00:56.58 | Corrodias | we-ell... some validators might throw errors that need to be caught, as part of the validation process... but i assume that's not the case, if you're looking at it. |
| 01:11.35 | foxlit | Corrodias: it will give you the previous expansions... in July. |
| 01:11.59 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 01:14.57 | foxlit | so your options are to buy this and (a) wait until July to play through the previous expansions, reaching Shadowbringers content way late or (b) also buy Stormblood now to reach the current level cap before Shadowbringers releases. |
| 01:17.01 | Corrodias | i suppose they want you to do B, but if you decide to wait, it's just a nice bonus that you get the previous expansions included and don't have to buy them separately |
| 01:22.34 | *** join/#wowuidev niluser (~niluser@192.162.189.80.dyn.plus.net) |
| 01:23.54 | foxlit | (seems like thats just par for the course for subscription mmos) |
| 01:24.32 | Corrodias | is that how WoW works? I quit during TBC, so i don't know whether previous expansions are included in the latest game purchase. |
| 01:26.31 | foxlit | base wow includes everything through Legion now |
| 03:28.15 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 04:27.08 | nebula | I pre-ordered SB shortly after it was available hoping it would unlock the earlier stuff since I only played ARR, but nope :( |
| 04:28.59 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 04:34.38 | *** join/#wowuidev Gethe (~Gethe@98.156.187.225) |
| 04:56.48 | *** join/#wowuidev Andols (~yaaic@m83-185-86-126.cust.tele2.se) |
| 05:31.16 | *** join/#wowuidev Shadnix_ (foobar@p4FEFC527.dip0.t-ipconnect.de) |
| 06:37.49 | *** join/#wowuidev mitch0 (~mitch@94-21-182-161.pool.digikabel.hu) |
| 07:33.06 | *** join/#wowuidev Shadnix (foobar@p5B3D2C39.dip0.t-ipconnect.de) |
| 08:49.13 | *** join/#wowuidev VIad (~Vlad@cm-84.213.147.218.getinternet.no) |
| 09:30.31 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 10:48.27 | *** join/#wowuidev Andols (~yaaic@m83-185-86-126.cust.tele2.se) |
| 12:00.17 | *** join/#wowuidev Breen (~Breen@80.175.117.105) |
| 13:06.32 | *** join/#wowuidev Gethe (~Gethe@98.156.187.225) |
| 14:27.37 | *** join/#wowuidev Tercioo (~Tercioo@196.240.255.6) |
| 15:00.17 | *** join/#wowuidev Andols (~yaaic@m77-218-230-130.cust.tele2.se) |
| 15:39.22 | TSquare | Good Morning |
| 15:44.28 | Cairenn | Hey |
| 17:35.38 | *** join/#wowuidev Caleb| (~Caleb|@WoWUIDev/WoWAce/EnsidiaFails/Caleb) |
| 17:56.10 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 18:05.50 | *** join/#wowuidev Infus (~quassel@p200300CCB71ACA0016DDA9FFFEE90B78.dip0.t-ipconnect.de) |
| 18:06.56 | Infus | TSquare: so from our testing on the 8.2 PTR, it seems all the apsi now only take file ids. Is that correct? |
| 18:10.47 | foxlit | texture:SetTexture("Interface/Icons/Temp") seems fine on 8.2. |
| 18:13.43 | foxlit | it's probably more that some files no longer have actual names. |
| 18:13.48 | Infus | ah right, except Interface, but e.g "Textures\\SpellActivationOverlays\\Eclipse_Sun no longer works |
| 18:14.36 | Infus | or "Spells\\Aspect_Beast" to take two examples |
| 18:15.45 | nevcairiel | files are/can be stored without names in casc, so if they change anything its likely that the names are lost, since the games dont need them anymore. probably not strictly a UI change as such |
| 18:16.42 | Infus | it would have very inconvenient if we don't upgrade our users settings well in advanced of 8.2 |
| 18:19.22 | foxlit | well, you could always ship a dictionary later. |
| 18:20.18 | Infus | that's the inconvenient part |
| 18:20.24 | Simca_ | namehashes are removed in 8.2 for all files outside Interface\ |
| 18:20.39 | Simca_ | no names outside that directory will resolve now |
| 18:20.49 | foxlit | (it's all Simca's fault for whining about filename typos) |
| 18:20.55 | nevcairiel | i wonder how many sounds in addons that breaks :D |
| 18:21.55 | foxlit | probably relatively few, since you don't have easy access to sound file names to begin with. |
| 18:22.17 | foxlit | (everything ui-related has a soundkit id anyway) |
| 18:24.01 | nevcairiel | bossmods play plenty other sounds, for example |
| 18:24.54 | Simca_ | overwriting sound files to remove sounds you don't like or replace sounds you don't like has been a thing for many years |
| 18:24.59 | Simca_ | and that's dead in 8.2 too |
| 18:25.17 | nevcairiel | even one of my own addons plays some creature sounds |
| 18:25.35 | nevcairiel | "Sound\\Creature\\Peasant\\PeasantWhat3.ogg" for example |
| 18:25.53 | *** join/#wowuidev Funkeh` (Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 18:25.54 | Simca_ | the VFS can add new files, which can be addressed by addons, but it won't be able to replace old files because it can't resolve them |
| 18:26.15 | nevcairiel | is there a way to resolve names to IDs in the 8.1.5 client? |
| 18:26.21 | nevcairiel | or just using db2 files? |
| 18:26.28 | Simca_ | not in the client itself |
| 18:26.44 | foxlit | nevcairiel: yes. |
| 18:27.10 | Infus | TSquare: anyway the point is, you might want to announce this via a blue post, since it'll probably affect a fair number of addons |
| 18:27.13 | Infus | GetFileIDFromPath |
| 18:27.52 | Simca_ | oh, that'll be really useless in 8.2 lol |
| 18:27.57 | Gnarfoz | [20:24:52] <Simca_> overwriting sound files to remove sounds you don't like or replace sounds you don't like has been a thing for many years <-- Spell_RO_FromtheShadows_Impact.ogg Spell_RO_ShurikenToss_Impact_xx.ogg :( |
| 18:28.26 | Simca_ | https://wow.tools/files/ and 'Download listfile' for a CSV format of filedata;name |
| 18:30.34 | Funkeh` | Infus: what did I miss |
| 18:30.40 | nevcairiel | hm PlaySoundFile with that ID doesnt work tho |
| 18:31.00 | Funkeh` | PlaySoundFile doesn't take IDs? |
| 18:31.12 | nevcairiel | something has to if there is no filenames =p |
| 18:31.12 | Simca_ | hopefully it does in 8.2 |
| 18:31.18 | Simca_ | or the function is completely useless |
| 18:31.24 | Simca_ | which would be really amusing |
| 18:31.28 | Funkeh` | I guess this is what I missed |
| 18:31.28 | nevcairiel | well addon files are still a thing |
| 18:31.38 | Simca_ | i mean i guess, yeah |
| 18:32.16 | nevcairiel | but unless there is a new sound function that i dont know about, not sure how to play any wow-provided audio file anymore |
| 18:32.20 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 18:32.36 | nevcairiel | other then UI files with soundkit IDs |
| 18:33.38 | Funkeh` | so what's happening exactly? I wasn't in the channel |
| 18:33.55 | Funkeh` | No longer able to reference file names? |
| 18:33.57 | nevcairiel | no files outside of Interface\ can be addressed by name anymore in 8.2 |
| 18:34.00 | Kalroth | i bet nev broke it |
| 18:34.10 | Alram | workingasintended.jpg |
| 18:34.17 | Funkeh` | ah |
| 18:34.29 | nevcairiel | IDs work for textures |
| 18:34.33 | nevcairiel | but sounds apparently .. not |
| 18:34.59 | Funkeh` | I see my ability to predict the future worked out well in moving tons of SetTexture calls to IDs |
| 18:35.21 | nevcairiel | it wasnt exactly hard to guess that this day might come |
| 18:35.40 | Funkeh` | nebula was a doubting me |
| 18:35.43 | nevcairiel | just need them to fix PlaySoundFile |
| 18:36.21 | Funkeh` | Not really, just need them to publish a proper list of sound IDs instead of the half arsed list that currently exists in that global table |
| 18:36.37 | nevcairiel | only UI related files probably even have a SoundKit ID |
| 18:36.46 | Alram | everything has |
| 18:36.59 | Alram | or well, everything that is used |
| 18:37.07 | Funkeh` | nevcairiel: that wouldn't explain their high ID count and jumps between numbers |
| 18:37.27 | Funkeh` | something similar to this would be great: https://www.townlong-yak.com/framexml/live/Helix/ArtTextureID.lua |
| 18:37.29 | nevcairiel | well then there is a db2 somewhere and I dont care what they publish, its not like the publish a texture ID list |
| 18:37.44 | Funkeh` | no foxlit does that for us in that link :D |
| 18:38.09 | Funkeh` | although he restricts it to the interface folder |
| 18:38.58 | nevcairiel | and thats already 30k textures, all of them would probably be a million or so |
| 18:39.01 | nevcairiel | :D |
| 18:39.09 | Alram | BLPs? |
| 18:39.15 | Alram | around 400k |
| 18:39.34 | Alram | and considering most wont have a filename anymore |
| 18:39.35 | Alram | rip that too |
| 18:39.51 | nevcairiel | must annoy dataminers as well |
| 18:39.57 | Alram | it is not great |
| 18:40.02 | Funkeh` | are they killing GetFileIDFromPath ? |
| 18:40.09 | Alram | it is probably already dead |
| 18:40.15 | Alram | i don't see how it can work for non-interface files |
| 18:40.17 | nevcairiel | the data it uses is j ust not part of the game anymore |
| 18:40.19 | nevcairiel | so.. |
| 18:40.26 | Funkeh` | silly not to have that for a transition patch IMHO |
| 18:40.32 | Funkeh` | can put it in dev tools or something |
| 18:40.39 | foxlit | you leave GetFileIDFromPath out of this. |
| 18:41.08 | Funkeh` | dev tools is already LoD so |
| 18:41.23 | foxlit | it should work just fine for the subset of files that still have names, and I need it. |
| 18:41.47 | Funkeh` | what wil still have names? everything in interface? |
| 18:42.02 | Alram | everything extracted with the exportinterfacefiles thing |
| 18:42.04 | foxlit | whatever blizzard, in their infinite wisdom, flags to have names. |
| 18:42.12 | Alram | not sure if that is literally everything in interface or not |
| 18:42.17 | nevcairiel | yes, those names are stored seperately, because its used for the interface export |
| 18:42.22 | foxlit | (I'm sure they accept bribes.) |
| 18:43.24 | Funkeh` | did he say what the primary motivator of the change was |
| 18:43.47 | Alram | mostly performance and to "not have load-bearing filenames" anymore |
| 18:44.05 | Alram | it is actually marginally quicker so i can't entirely blame them |
| 18:44.31 | Alram | with the nice side effect of making it much harder on dataminers and being able to build a more robust content pipeline |
| 18:44.48 | nevcairiel | so a win/win/win |
| 18:45.00 | Alram | in their book very much so |
| 18:45.10 | Alram | in everyone's book that uses the game files outside of blizzard, not really |
| 18:45.26 | nevcairiel | all I do is play some creature sound files |
| 18:45.35 | nevcairiel | just need to go dig up the IDs for those |
| 18:45.47 | nevcairiel | (in-game, that is) |
| 18:46.07 | Alram | you need to go through soundkit in-game? |
| 18:46.17 | Alram | unsure if soundkitname is even exposed in-game |
| 18:46.49 | nevcairiel | i'm fine reading dumped db2 files and match them manually, its only a handful of files |
| 18:47.17 | foxlit | cascHandle.root:getFileID("path") |
| 18:47.29 | nevcairiel | the casc ID doesnt work for sound playback |
| 18:47.40 | Alram | getFileID by path? |
| 18:47.41 | Alram | cute |
| 18:47.52 | Alram | :( |
| 18:48.09 | Funkeh` | TheDanW: will you also be aiming to fix every remaining API that still doesn't accept IDs in time for 8.2? Such as SetBackdrop (the tables) or :SetHighlightTexture or SetMaskTexture |
| 18:48.12 | Funkeh` | oops |
| 18:48.15 | Funkeh` | TSquare: |
| 18:48.19 | Funkeh` | sorry bad habbit |
| 18:48.34 | nevcairiel | all of those probably reference Interface\ textures so its not like its a blocking issue as s uch |
| 18:48.36 | foxlit | hm, so playsoundfile doesn't accept file ids? |
| 18:48.41 | nevcairiel | not as of yet |
| 18:50.36 | Funkeh` | nevcairiel: I use non-interface based textures a lot in SexyMap, especially for minimap texture masks |
| 18:51.23 | Funkeh` | I would like to hope they would at least fix the remaining API to work with IDs as a baseline requirement |
| 18:52.20 | Funkeh` | And oh god is it going to destroy peoples custom shapes and textures, didn't even think of that |
| 18:53.50 | Infus | yes, that's my point, if you want to use GetFileIdFromPath you need to do that now |
| 18:54.36 | Funkeh` | so basically update the addon, store everything in a table (since I can't use the API with IDs right now) and leave the table waiting for the patch. And that's assuming they even fix the APIs like SetMaskTexture to accept IDs |
| 18:55.22 | Infus | <PROTECTED> |
| 18:55.39 | Funkeh` | I assume you will have a similar issue with WeakAuras |
| 18:56.23 | Infus | yes and it's unlikely that we'll get everyone to use a new wa version before 8.2 |
| 18:56.46 | Funkeh` | same with SexyMap, there's even less reason to update it |
| 19:13.05 | Stanzilla_ | one can only hope that somehow the UI department wakes up and does a blue post on what their goals are |
| 19:13.07 | Stanzilla_ | haHaa |
| 19:13.46 | nevcairiel | as mentioned above this isnt exactly a UI change, the UI functions stopping to work is just fallout from a general game change |
| 19:13.51 | *** join/#wowuidev ls- (~ls-@mx-ll-223.206.116-36.dynamic.3bb.co.th) |
| 19:15.50 | Stanzilla_ | still UI deparment since they have to make sure everything works as before or atleast provide guidance on how to handle the change |
| 19:17.08 | nevcairiel | Step 1: Change your path to the corresponding ID. Step 2: Upload updated addon. Step 3: Go back to relaxing. |
| 19:20.37 | nevcairiel | You had to manually crawl around game files to get the file names of non-interface files in the first place, so expecting you to crawl back in there and get the ID translation manually is probabl fair. |
| 19:21.10 | Funkeh` | *totally ignores the discussion that just happened* |
| 19:21.39 | nevcairiel | user generated data is always a problem, but its not something they are ever going to solve for you |
| 19:22.09 | Stanzilla_ | maybe read what I actually wrote |
| 19:22.12 | Funkeh` | don't remove the required translator function prior to the API even being ready for the change? |
| 19:22.15 | Stanzilla_ | a blue post about their goals are would be good |
| 19:22.51 | Funkeh` | indeed |
| 19:23.02 | nevcairiel | Personally I might have tried to delay such changes to the next expansion, but maybe they didn't think the impact was too bad |
| 19:23.24 | Alram | tbh i did expect it for 9.0 |
| 19:23.35 | Alram | but everything was basically ready sooo i guess why not |
| 19:24.30 | Funkeh` | how can you say that |
| 19:24.31 | nevcairiel | but translation isnt always build into the game. For 8.0 all previous map data was basically invalidated with no translation in the game client, so I had to build my own. They were nice enough to provide data to help, but not in-game accessible either way. |
| 19:24.33 | Funkeh` | the API isn't even ready xD |
| 19:24.40 | Alram | every other game system is |
| 19:24.46 | Infus | TSquare: btw, text selection is broken again in 8.2, details at https://github.com/WeakAuras/WeakAuras2/issues/1290, including a minimal reproducing a example and some gifs that show the problem |
| 19:24.56 | foxlit | (GetFileIDFromPath isn't removed, it just won't have the necessary data for the affected files.) |
| 19:25.29 | Infus | it was previously broken in 7.2, but the cause seems to be different |
| 19:30.10 | *** join/#wowuidev phyber (phyber@unaffiliated/phyber) |
| 19:30.49 | foxlit | The other alternative is that they could flag more files to retain names. |
| 19:31.47 | nevcairiel | i'm sure there is hundreds if not thousands of random textures and sounds that people use in weakauras or other random things |
| 19:32.00 | nevcairiel | how would you collect that data |
| 19:33.37 | foxlit | ... throw up a google forms sheet for interested parties to enter file names into. |
| 19:34.14 | nevcairiel | that doesnt sound like something someone totally wouldnt paste an entire listfile into |
| 19:34.53 | foxlit | okay, authenticate against the battle.net ouath and ban them. |
| 19:35.51 | foxlit | I mean, it's a best-effort thing. People can obviously be asses if they want, in which case they don't get stuff done. |
| 19:36.16 | nevcairiel | there is always that one ass that ruins it for everyone else. this is the internet, afterall. |
| 19:38.51 | *** join/#wowuidev Shamatix (~henri@188-177-91-26-cable.dk.customer.tdc.net) |
| 19:52.23 | TSquare | OK, so things blew up here :) |
| 19:52.43 | TSquare | Coming in late to this: I was told about the change a couple of weeks ago |
| 19:53.12 | TSquare | There is a bug in to fix the audio override. I have not spoken with the lead of the team that is overseeing it |
| 19:53.35 | TSquare | I'll try and have that discussion this week |
| 19:54.11 | TSquare | Just so that I have it clear. Interface files are good? |
| 19:54.35 | TSquare | I'm not sure (other than audio files) what problems you are seeing |
| 19:54.53 | nevcairiel | Some addons seem to be referencing non-interface textures |
| 19:55.01 | TSquare | like building textures? |
| 19:55.20 | nevcairiel | one example given above was Textures\\SpellActivationOverlays\\Eclipse_Sun |
| 19:56.09 | nevcairiel | or Spells\\Aspect_Beast |
| 19:56.27 | nevcairiel | Funkeh` probably has some more |
| 19:57.23 | Funkeh` | [19:48:11] <Funkeh`> will you also be aiming to fix every remaining API that still doesn't accept IDs in time for 8.2? Such as SetBackdrop (the tables) or :SetHighlightTexture or SetMaskTexture |
| 19:58.09 | Funkeh` | https://github.com/funkydude/SexyMap/blob/master/BorderPresets.lua see "texture" entries |
| 19:58.10 | TSquare | are those functions broken? |
| 19:58.17 | Funkeh` | they don't handle IDs |
| 19:59.05 | TSquare | oh, well we can add variants for those, but since the interface art is not being affected, I assume they are still ok as is |
| 19:59.24 | TSquare | I'm not saying I won't add variants, just checking the priority |
| 19:59.36 | Funkeh` | why variants when SetTexture works for both? |
| 19:59.56 | TSquare | oh, if there is a workaround that's great |
| 20:00.09 | Funkeh` | there isn't a workaround |
| 20:00.25 | Funkeh` | I'm stating that some of the API calls accept both IDs or paths |
| 20:00.32 | TSquare | ohhh ... yea |
| 20:00.32 | Funkeh` | others have not been updated yet |
| 20:00.41 | TSquare | sure, that makes sense |
| 20:00.55 | Funkeh` | I was told it was "on the todo" but would have hoped it would be done for a major change like this |
| 20:01.03 | Funkeh` | (that's when I asked like 2 years ago) |
| 20:01.20 | TSquare | is this really a major change? I really didn't think many addons would even notice this change |
| 20:01.53 | Funkeh` | it's a major change for addons that allow user specific decorations like SexyMap or WeakAuras |
| 20:02.14 | Funkeh` | it will completely break customized decorations for all users of those addons |
| 20:02.16 | TSquare | this should not affect your textures, is it? |
| 20:02.42 | Funkeh` | It doesn't affect anything using SetTexture |
| 20:02.43 | Alram | for those not in interface folders it would |
| 20:02.49 | Alram | (if referenced by name) |
| 20:02.51 | Funkeh` | but does affect anything using the other APIs |
| 20:02.55 | Funkeh` | that's my main issue |
| 20:03.11 | TSquare | wait, if you are adding new textures you can't reference them by name? |
| 20:03.37 | Funkeh` | no, a user is creating a decoration preset using blizz textures |
| 20:03.43 | Funkeh` | not adding their own textures |
| 20:03.56 | TSquare | <whew> good |
| 20:04.31 | TSquare | I assume most textures are not being referenced. Like model textures |
| 20:04.46 | TSquare | is there a "type" of texture that you are missing? |
| 20:04.49 | Funkeh` | literally any texture can be referenced, a user types in paths |
| 20:05.00 | TSquare | ok, well that may not be coming back |
| 20:05.24 | TSquare | but if there are some common ones, I can ask to have them moved to the Interface folder |
| 20:05.31 | Funkeh` | I don't need it to come back, I need the APIs to be updated to handle IDs so a user can type in an ID instead |
| 20:05.37 | Stanzilla_ | ^ |
| 20:05.50 | TSquare | ok, so just those two? |
| 20:06.11 | Funkeh` | I mentioned 3 APIs there, there may be more |
| 20:06.55 | TSquare | it should be easy to add ID support |
| 20:07.02 | Funkeh` | the most important one for me being Minimap:SetMaskTexture |
| 20:08.30 | Funkeh` | TSquare: The other issue is how we're going to handle user databse upgrades. The only thing we could use is an API that will no longer work with non-interface file paths GetFileIDFromPath |
| 20:09.08 | Funkeh` | So our only option would be to update our addons now, have those addons parse user databases using GetFileIDFromPath, store all the IDs in a table, and wait for the patch that upgrades the API calls to accept IDs |
| 20:09.28 | Funkeh` | So we would resort to begging users to update now, and if they don't update prior to the patch, tough luck |
| 20:10.55 | Funkeh` | would it be possible to have some form of API in a LoD addon such as dev tools or the backwards compat addon that referenced all the old texture paths and spits out their IDs |
| 20:11.34 | TSquare | I'm not sure. I'll have to talk with some other people |
| 20:12.20 | foxlit | Funkeh`: would it be possible to have some form of API in a LoD addon such as dev tools or the backwards compat addon that referenced all the old texture paths and spits out their IDs << you can implement this yourself. |
| 20:12.23 | TSquare | To be honest, I did not think addons were regularly accessing any random texture |
| 20:12.49 | Alram | people use what is available to them |
| 20:12.52 | Funkeh` | This would be a one time upgrade for the user's database |
| 20:12.54 | Alram | so it makes sense they would |
| 20:14.17 | TSquare | let me discuss it, and see if there is anything we can do |
| 20:14.31 | Funkeh` | cheers |
| 20:15.36 | ls- | there's plenty of interesting/pretteh sprites in wow that can be used for ui customisation, so people used those fairly regularly |
| 20:15.39 | nevcairiel | They didn't want to give us in-game reachable migration data for the maps due to datasize concerns, and that data was significantly less then a few hundred thousand texture strings no less, so I wouldn't exactly hold my breath and plan otherwise |
| 20:15.39 | ls- | the same goes for various models |
| 20:15.55 | Stanzilla_ | people use textures modules etc all the time |
| 20:15.58 | Stanzilla_ | *models |
| 20:17.27 | ls- | yeah, I'm just saying that people do regularly access random textures for various reasons :V |
| 20:17.51 | Stanzilla_ | TSquare: interface building is a form of art, you are just taking away people's colors :D |
| 20:18.12 | nevcairiel | he really just takes the labels off the pens |
| 20:18.24 | Funkeh` | pretty good analogy |
| 20:18.24 | nevcairiel | well, not "he" |
| 20:18.53 | TSquare | or you can make your own art :P |
| 20:19.03 | Stanzilla_ | without apis that work with ids and paths going away, it's the whole thing gone :D |
| 20:19.11 | nevcairiel | APIs should definitely be fixed to take IDs, no doubt |
| 20:19.24 | Funkeh` | custom art will work fine since it will be in the interface folder |
| 20:19.29 | nevcairiel | but migration help .. would be nice, but I wouldn't put all my eggs in that basket |
| 20:19.30 | TSquare | seriously: I have only supported the interface art (with the exporter, etc) |
| 20:19.42 | TSquare | the other art is not in my area to ensure access to |
| 20:19.47 | TSquare | but I will ask |
| 20:19.50 | Stanzilla_ | yeah that is sad |
| 20:20.14 | Stanzilla_ | please make sure that the people you talk to actually understand what the problem is though |
| 20:20.45 | TSquare | I will |
| 20:20.50 | Stanzilla_ | thank you |
| 20:21.17 | Alram | obviously the solution is to extract the all files |
| 20:21.20 | Alram | and ship them with your addon |
| 20:21.40 | nevcairiel | in before lawsuit |
| 20:21.55 | foxlit | "I got those from Alram!" |
| 20:22.02 | nevcairiel | smart. |
| 20:22.11 | Funkeh` | wonder if curse has a max zip file size |
| 20:22.17 | nevcairiel | probably |
| 20:22.24 | nevcairiel | but some sound and texture packs are pretty big already |
| 20:25.07 | Stanzilla_ | I can already see the community raising multiple kinds of hell if anything they used before is no longer possible after the patch hits |
| 20:25.55 | nevcairiel | UIs breaking on major patches is nothing new, really. And as long as the APIs take IDs, they can be fixed as well. |
| 20:26.11 | nevcairiel | of course 2019 kids are all crybabies and maybe their UI never broke before, so they'll all throw a fit |
| 20:27.17 | Stanzilla_ | that is what I said, IF the APIs get fixed, everything can possible get fixed |
| 20:27.21 | Stanzilla_ | if not, riot |
| 20:29.39 | TSquare | well this is not like we changed the combat log event. Several patches in a row :D |
| 20:30.20 | Funkeh` | gonna split that thing into multiple events again? |
| 20:30.30 | TSquare | and then re-merge them |
| 20:30.35 | Funkeh` | ;_; |
| 20:30.54 | TSquare | for my own sanity, could someone keep a list of functions that need fileID support? |
| 20:31.09 | Funkeh` | I can try and track down some more |
| 20:31.16 | Funkeh` | it may be just luck that that's the only 3 |
| 20:36.56 | TSquare | SetHighlightTexture on Button looks like it should work |
| 20:37.57 | TSquare | it looks for a table (texture object), than a number (fileID), then a string(filename) |
| 20:43.35 | TSquare | SetMaskTexture is easy, I have it mostly done |
| 20:44.01 | foxlit | btw, it would be nice if your "is it a number?" check didn't throw errors when handling things like "inf" or "nan" |
| 20:45.12 | TSquare | that doesn't sound correct |
| 20:45.25 | foxlit | (it tries to coerce the parameter into an integer, and variations of those specific strings fail loudly with "integer overflow attempting to store inf" |
| 20:46.46 | foxlit | , while it would be saner to probably just silently continue to "does it make sense as a string?" case) |
| 20:46.53 | TSquare | let me see. It is a generic function, and I don't want to change that |
| 20:47.17 | foxlit | e.g. UIParent:CreateTexture():SetTexture("inf") throws an error. |
| 20:48.13 | TSquare | yea, but I don't want the generic isnumber to silently fail when actually passed a bad value |
| 20:49.57 | Funkeh` | TSquare: slider:SetThumbTexture, texture:SetMask |
| 20:50.35 | TSquare | Ugh, SetBackdrop is a bit of a mess |
| 20:50.41 | Funkeh` | :D |
| 20:51.03 | TSquare | moving on to slider :D |
| 20:51.24 | Funkeh` | those are from parsing my own addons, there may be more |
| 20:54.16 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 21:09.13 | Mr_Rabies | new ptr build :O |
| 21:11.08 | TukuiDevs | <Azilroka> Yea SetBackdrop is a mess |
| 21:11.46 | foxlit | is it one of those "we wanted to remove this function ages ago, might as well do it now" messes? |
| 21:12.56 | *** join/#wowuidev Tercioo (~Tercioo@196.240.255.6) |
| 21:13.17 | *** join/#wowuidev Ketho (~Ketho@2a02:a44e:ac87:1:6d92:8584:2da5:ad66) |
| 21:13.17 | TukuiDevs | <Azilroka> they could.. then they would have to redo the tooltips |
| 21:20.58 | Funkeh` | TSquare: it might be best to do a search for "texture" or "mask". e.g. ArchaeologyDigSiteFrame:SetBorderTexture() might be one but I can't really go creating use cases for everything when I assume you can just see the functionality :D |
| 21:22.47 | *** join/#wowuidev niluser (~niluser@192.162.189.80.dyn.plus.net) |
| 21:25.06 | Funkeh` | Cooldown:SetSwipeTexture() is something I didn't even know was a thing |
| 21:25.38 | TukuiDevs | <Azilroka> Alot of the Cooldown API doesn't actually work |
| 21:26.32 | Funkeh` | I'm assuming SetFont isn't afected by this change? |
| 21:29.10 | Funkeh` | All the Blizz fonts are in the Fonts folder so it would suck not being able to access them :D |
| 21:31.07 | Funkeh` | TSquare: SetStatusBarTexture unless it's been fixed since I last tested it |
| 21:31.43 | foxlit | fonts still have filenames. |
| 21:42.26 | *** join/#wowuidev TukuiDevs (~TukuiDevs@45.32.153.30) |
| 22:19.55 | *** join/#wowuidev Andols (~yaaic@m77-218-230-130.cust.tele2.se) |
| 22:23.17 | *** join/#wowuidev Andols2 (~yaaic@217-209-12-6-no170.tbcn.telia.com) |
| 22:27.52 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 22:31.11 | Simca_ | also, @TSquare Why are the interface filenames still in root at all? isn't that a waste of space? I mean the entire point of removing namehashes from the rest of root was to save space in root (which must be constantly redownloaded for every executable update), but the namehashes remaining for interface files is fully redundant. |
| 22:31.45 | Simca_ | Interface files are already mapped from FileDataID to file path in ManifestInterfaceData.db2 |
| 22:32.02 | Simca_ | the extract interface files function doesn't need the namehashes in root to extract them if it used that db2 instead |
| 22:32.57 | foxlit | clearly, MID is only used to power the ExportInterfaceStuff console commands, and not in the "hey, fetch me a file" code path. |
| 22:33.04 | Simca_ | but why? |
| 22:33.40 | Simca_ | the "hey, fetch me a file" code path is being effectively abandoned for everything but files in MID |
| 22:35.20 | Simca_ | Fonts\ may be the only folder that is an exception, which actually needs namehashes and to work from the 'hey, fetch me a file' code path |
| 22:36.12 | Simca_ | "Why are the interface filenames still in root at all?" -- I mean to say namehashes there, not filenames, oops |
| 22:37.46 | nevcairiel | but if they need the original code path anyway, changing it to instead fetch from two places (fonts from root, interface from MID) would be rather annoying |
| 22:38.04 | nevcairiel | so might as well leave them in there |
| 22:38.40 | nevcairiel | also adds flexibility in case they still need to allow some other files at some point |
| 22:39.02 | mischanix | They'll save 16MB if they can remove namehashes from the BuildManifest hashtable... so it would make sense to refactor that to just lookup through MID. But I think it's a ton of code that needs to change for that to happen |
| 22:39.45 | mischanix | actually more than that, there's also a namehash pointer lookup, so 32MB |
| 22:41.11 | foxlit | er, the UI still needs a (relatively fast) path to resolve names to file IDs. |
| 22:43.58 | foxlit | MID as-is should be larger than the casc namehashes required to reference its files; you could pre-compute a namehash->fileid map at launch, but that won't save any actual memory. |
| 22:44.14 | mischanix | Yeah, the point is that the hashtable for MID would be much smaller since it's not every file in the game. I guess they could just optimize buildmanifest to not store hashes in buildmanifest entries, but instead only store namehashes in the value part of the namehash -> buildmanifest entry pointer lookup |
| 22:45.53 | foxlit | who's a buildmanifest? |
| 22:46.02 | mischanix | 16 bytes * O(num named files) + 24 bytes * O(num files) instead of 8 bytes * O(named files) + 32 bytes * O(num files) |
| 22:56.07 | foxlit | I don't understand the layout of the data structures you're discussing. |
| 22:56.49 | znf | yo, don't break my font replacement |
| 22:58.42 | foxlit | I guess if you compile the root file down to what you actually want to access at runtime, you'd get a fileid->content hash map (4+16 bytes per file) and a namehash->fileid map (8+4 bytes per named file). |
| 23:05.30 | foxlit | (which matches like none of the constants above) |
| 23:06.56 | mischanix | Ah yeah sorry entry has namehash, content flags, locale flags, and content key, 8+4+4+16=32. The namehash->entry hashtable has pointers to the entries, and it's probed by dereferencing the pointers and checking the namehash in the entry, so 8 bytes per named file |
| 23:06.59 | *** join/#wowuidev stolenlegacy_ (~stolenleg@unaffiliated/stolenlegacy) |
| 23:09.16 | mischanix | and these are power-of-two hashmaps with not very high load factors (or they're reserved based on the numFiles in the header?), so the current build has 2*1024*1024 slots to store all the entries for the current locale+violence level, for a total of 64MB |
| 23:10.51 | mischanix | that said, I don't know how big the encoding key lookup (ckey -> ekey) is in memory and if that's at all optimized, that'd be an interesting point of optimization as well. Could also store hash prefixes (the least common prefix size of the whole set of content keys is like 6 or 7 bytes iirc) |
| 23:24.40 | foxlit | okay, that makes the numbers make more sense. The runtime memory tradeoff still seems indifferent to MID: you could implement either scheme with the current root file. |
| 23:27.50 | mischanix | Yep, that's true. Also I guess if that hashtable is targeting a max load factor of 0.75, 770k/0.75 is just above 1024*1024, so that explains why it's so sparse |
| 23:29.05 | mischanix | Not sure why they keep locale/content flags around either. I guess the dev build needs to support getting files of alternate locales. |
| 23:52.43 | *** join/#wowuidev Ssateneth (ident@unaffiliated/ssateneth) |
| 23:56.52 | *** join/#wowuidev Gethe (~Gethe@98.156.187.225) |