| 00:03.05 | *** join/#wowuidev karl_w_w (~karl_w_w@110-175-132-56.tpgi.com.au) |
| 00:04.22 | Funkeh` | but why are spellName args being removed from UnitSpellcast.. API |
| 00:07.31 | TheDanW | just look up the spell name if you need it, making an effort to reduce duplicate data |
| 00:07.42 | TheDanW | long ways to go, but its a direction |
| 00:07.58 | Funkeh` | did you add GetSpellName =P |
| 00:09.07 | TheDanW | just type (GetSpellInfo(spellID)) ;p |
| 00:09.19 | Funkeh` | yeah, that's totally a reduction in overhead |
| 00:09.36 | Funkeh` | now instead of getting the spellname, fetch all the data! |
| 00:09.39 | TheDanW | there is a spell Lua object now |
| 00:10.18 | TheDanW | in FrameXML/ObjectAPI/Spell.lua |
| 00:19.41 | TheDanW | it's mostly for convenience for async, similar to the item one |
| 00:19.58 | TheDanW | i'm really not that worried about the overhead of GetSpellInfo |
| 00:20.16 | Funkeh` | yet you were worried about sending spellName to Unit events? |
| 00:20.30 | TheDanW | that's not what i said |
| 00:23.11 | Funkeh` | dress it up however you want, it's a perfomance drop for absolutely no reason. The only way it's a gain is with a GetSpellName API. |
| 00:24.39 | TheDanW | i don't know what you think is so expensive about GetItemInfo |
| 00:24.43 | TheDanW | er spell info |
| 00:25.06 | Funkeh` | I don't know what you have against returning spellName |
| 00:25.40 | Funkeh` | also, you've clearly not seen some common practices for weakaura scripts |
| 00:25.52 | Simca | it feels like the reason SpellName was split out from Spell in order to do that |
| 00:25.55 | Simca | but idk |
| 00:26.22 | Simca | does GetSpellInfo return description/etc in BFA or does it only return name and other properties? |
| 00:26.36 | TheDanW | it's never returned description |
| 00:26.45 | Funkeh` | basically everything other than description |
| 00:26.46 | TheDanW | it used to return subtext, but no longer |
| 00:26.56 | Simca | yeah, then it will be fast |
| 00:26.57 | TheDanW | there's a ton of spell data that it does not return |
| 00:27.36 | Funkeh` | it's not a matter of how fast GetSpellInfo is, it's a matter of "why are you making this functionality slower with no reason to do so" |
| 01:17.06 | Simca | you haven't explained very well why it's important to you Funkeh`. from dan's perspective, introducing one-of GetXFromY functions probably looks like a terrible idea and a slippery slope - where does it stop? do you just make a function that returns 1 argument from the table based on the ID of the table for every single table in the game? or at least for every single use case in game? |
| 01:18.59 | Simca | instead of being sassy, try to explain that even saving a few cycles per call may be nice, especially in longer WeakAuras where you have to do an extensive number of lookups, especially because it's not a background process - the user is counting on the responsiveness of the aura |
| 01:19.57 | Funkeh` | I don't think I need to explain why a dumb change is dumb |
| 01:20.19 | Funkeh` | "i woke up today and decided to remove functionality from this API, because lulz" |
| 01:20.40 | Simca | this may be a news flash but not everyone has your perspective, there are other perspectives in the world |
| 01:21.12 | Funkeh` | okay |
| 01:21.15 | Simca | so feedback of 'this is stupid' is inherently unhelpful |
| 01:21.32 | Funkeh` | I've fully explained it, learn to read |
| 01:26.43 | Simca | whatever man, continue living life angry and blaming others when you could have had real change if you went about it properly |
| 01:29.10 | Funkeh` | there is no change that will happen here, the very fact he made this change (especially when its bundled in with spell DESCRIPTION changes) shows that he was smoking the same stuff that he was smoking when he thought that tabs == spaces |
| 01:34.20 | Constie | Tabs and spaces are literally exactly the same thing. Change my mind. |
| 01:34.47 | Simca | the changes as presented are way better than what they originally proposed in 7.3.5 |
| 01:36.04 | Funkeh` | Yup, after we had to point out how moronic the initial changes were. But that's irrelevant, as the description changes have 0 to do with removing spellName api |
| 01:36.07 | Simca | iirc in 7.3.5 ID->name would required a data cache call, loading the row with the strings, then returning the results, whereas now the second (and potentially first?) steps are skipped by removing description stuff |
| 01:36.29 | Simca | and using GetSpellInfo |
| 01:37.36 | Simca | so we went from complaining that ID->spellname will literally take seconds in worst case scenarios to 'we may lose some cycles by getting a little superfluous information' |
| 01:37.52 | Simca | that's a big improvement from those changes |
| 01:38.19 | Funkeh` | Lol, you don't even understand the initial complaint dude |
| 01:38.27 | Funkeh` | stop arguing for the sake of it |
| 01:42.52 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 01:43.26 | [TOM_RUS] | GetSpellInfo(spellId, [infoType]) where optional infoType is what kind of info it will return (ie spell name etc), if specified, only that info is returned, but that gonna complicate C++ side of things :D |
| 01:45.09 | Constie | Maybe you should stop being rude for the sake of it. |
| 01:45.26 | [TOM_RUS] | personally I dont see issue, it's not like GetSpellInfo call cost that much... |
| 01:46.13 | Funkeh` | <Funkeh`> it's not a matter of how fast GetSpellInfo is, it's a matter of "why are you making this functionality slower with no reason to do so" |
| 01:46.33 | Simca | i should do api diff later |
| 01:46.51 | Simca | see if other spell stuff changed |
| 01:47.21 | [TOM_RUS] | you are claiming its slower, by how much? have you done any profiling? |
| 01:47.51 | Funkeh` | you're right, it's actually faster, because magic |
| 01:48.55 | [TOM_RUS] | I mean it's probably barely noticeable at worst... |
| 01:51.44 | Funkeh` | https://github.com/tomrus88/BlizzardInterfaceCode/commit/7e8d90c4ce24a736a709d8f17792df0dc544ad87#diff-62fbc8d6efb985f9d78d1283ecb02374L808 there's 2 disadvantages 1) you're breaking the API order, so the change better be worth it 2) you're forcing the user to look up a more expensive function to re-gain the information that was previously cheap |
| 01:51.50 | Funkeh` | What has been gained? |
| 01:52.19 | Funkeh` | Basic questions you ask yourself when changing API |
| 01:54.08 | Simca | well, namesubtext had to go at least, with the db changes being made. name didn't, technically. |
| 01:54.20 | Funkeh` | indeed |
| 01:56.07 | [TOM_RUS] | it's an improvement for user that don't need spell name or subtext, since event broadcast is cheaper now |
| 01:56.39 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:fcfe:ee74:f9e5:d0d5) |
| 01:56.39 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 01:57.12 | Funkeh` | and it can be an improvement for everyone, wether or not you're using a lot of addons that use that arg, if you had a simple spell name lookup |
| 01:57.33 | Funkeh` | right now you're arguing in favour of "it's an improvement for the base UI" |
| 01:58.13 | [TOM_RUS] | things like bigwigs,dbm,WA should only request spell name once anyway and cache it |
| 01:59.16 | Funkeh` | indeed, everyone should jsut have their own separate caches! |
| 01:59.42 | Funkeh` | (we do, but gl beaming that information into every WA author) |
| 02:14.27 | mischanix | A sufficiently advanced Lua-C interface could just intern strings in the Lua heap and return them instead of making new strings on every call |
| 02:17.16 | mischanix | This is a very old idea: http://lua-users.org/wiki/SpeedingUpStrings |
| 02:21.26 | Simca | neat |
| 02:50.35 | *** join/#wowuidev TheDon1 (~TheDon@203-219-137-117.static.tpgi.com.au) |
| 02:53.25 | nebula | i think sync spell names are far more important than descriptions, so i'm cool with the compromise |
| 03:00.05 | Simca | yeah that part is nice |
| 03:03.12 | *** join/#wowuidev TheDon1 (~TheDon@203-219-137-117.static.tpgi.com.au) |
| 03:22.40 | *** join/#wowuidev NickG365 (~NickG365@cortex.starlabs.theflash.rocks) |
| 03:27.20 | *** part/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 03:52.16 | Fisker | Hey Seerah |
| 03:52.25 | Seerah | hihi |
| 03:57.49 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 04:03.34 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 04:10.00 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 04:10.45 | *** join/#wowuidev Simca_ (~Simca@c-73-55-2-30.hsd1.fl.comcast.net) |
| 04:13.36 | *** join/#wowuidev nebula (~nebula@unaffiliated/nebula169) |
| 04:21.34 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 04:42.27 | *** join/#wowuidev ShadniX (dagger@p5B3D2B1F.dip0.t-ipconnect.de) |
| 04:43.18 | *** join/#wowuidev Andols2 (~yaaic@m83-185-244-1.cust.tele2.se) |
| 05:05.24 | *** part/#wowuidev Seerah (~umsin@2601:3c2:80:1380:fcfe:ee74:f9e5:d0d5) |
| 05:25.18 | *** join/#wowuidev Andols (~yaaic@m83-185-244-1.cust.tele2.se) |
| 05:34.59 | *** join/#wowuidev kd3 (~Kaydeethr@unaffiliated/kd3) |
| 05:39.59 | *** join/#wowuidev Kaelten (~Kaelten@luther.kaelten.com) |
| 05:39.59 | *** join/#wowuidev Kaelten (~Kaelten@WoWUIDev/WoWAce/WoWIFA/CurseStaff/kaelten) |
| 05:39.59 | *** mode/#wowuidev [+o Kaelten] by ChanServ |
| 05:48.44 | *** join/#wowuidev velithris_ (uid290671@gateway/web/irccloud.com/x-werxeotqmbavqoyp) |
| 05:51.43 | *** join/#wowuidev Andols (~yaaic@guest.vattenfall.se) |
| 05:52.45 | *** join/#wowuidev Varyak (~Varyak@ppp-82-135-90-95.dynamic.mnet-online.de) |
| 05:54.56 | *** join/#wowuidev Primer (~daniel@ceregatti.org) |
| 05:55.07 | *** join/#wowuidev bshelden (~bshelden@unaffiliated/dashkal) |
| 05:59.44 | *** join/#wowuidev Semlar_ (~semlar@72.189.128.149) |
| 06:12.44 | nevcairiel | wow i totally didnt expect them to add voice mic sense that fast, either it was planned long ago already or someone did really listen |
| 06:13.01 | nevcairiel | even though the b.net client itself doesnt have it yet |
| 06:35.12 | *** join/#wowuidev mitch0 (~mitch@178-164-136-198.pool.digikabel.hu) |
| 06:40.38 | *** join/#wowuidev VIad (~Vlad@cm-84.213.146.58.getinternet.no) |
| 06:56.17 | *** join/#wowuidev Andols (~yaaic@m83-185-244-1.cust.tele2.se) |
| 08:16.54 | nevcairiel | TheDanW: nice the map id mapping table already arrived, thanks! |
| 08:37.29 | VIad | C_Map #hype? |
| 08:51.01 | Ellypse | The change in the order of the return values from functions retrieving spell info or debuff info is pretty significant. As subtext was the 2nd return value in almost all cases, all return values after that shifted by n - 1. It required all of Blizz UI to be updated and will require all add-ons dealing with spells and buffs to be updated. I'm not cl |
| 08:51.02 | Ellypse | ever enough to have a better solution, but I do see how annoying this change will be for addon devs, and for users who will have many add-ons who completely stop working on patch day because of this. It's going to be worse than the PlaySound change. |
| 08:52.37 | nevcairiel | this expansion has the most UI changes since like the days of wrath or such, addons will be breaking anyway |
| 08:52.46 | *** join/#wowuidev bluspacecow (~bluspacec@121.99.98.200) |
| 08:52.46 | *** mode/#wowuidev [+v bluspacecow] by ChanServ |
| 08:54.06 | Ellypse | Hmm, maybe. But I hope this doesn't mean they can be totally reckless and break everything just because we're already too far gone ^^ |
| 08:55.35 | foxlit | bonus question: paladin horses had spell ranks ("subtext"?) last time I looked. Does that mean no casting chargers without waiting for the client to stop being lazy? |
| 08:56.13 | foxlit | <PROTECTED> |
| 08:57.27 | foxlit | (also some polymorph/hex variants were only distinguishable by rank) |
| 08:57.39 | foxlit | <PROTECTED> |
| 09:17.44 | nimhfree | nevcairiel: where can I find the map ID mapping table? |
| 09:18.36 | Ellypse | It's in AddOns/Blizzard_Deprecated/UIMapIDToWorldMapAreaID.lua https://github.com/Ellypse/wow-ui-source/blob/beta/AddOns/Blizzard_Deprecated/UIMapIDToWorldMapAreaID.lua |
| 09:18.44 | nevcairiel | indeed |
| 09:26.37 | nimhfree | thanks, now I just need to write a converter for this data |
| 09:28.41 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 09:29.39 | nevcairiel | i'll create a converter from mapid/floor to UiMapId when addons get enabled, no sense trying to start now |
| 09:35.08 | *** join/#wowuidev Simca (~Simca@c-73-55-2-30.hsd1.fl.comcast.net) |
| 09:38.23 | nimhfree | I donât want to make a converter to be used in game, but want to have all my data converted out of game. if I convert in the game on the fly then I will have trouble differentiating between the old data, and any new data that is added with the new map ID values. |
| 09:39.45 | nevcairiel | if possible updating out of game is of course best |
| 09:39.57 | nevcairiel | I aim this for things where SavedVariables include map data etc |
| 09:40.35 | nevcairiel | stuff like HandyNotes, GatherMate and more, which save user-generated map data |
| 09:42.08 | nimhfree | Yeah, I use it for NPC/item/object location like: G[1241745]={'945:46.93,44.36'} |
| 09:42.09 | nimhfree | and as the user plays, Grail will record new ones. The 945 here is going to have to be converted to 534 in 8.x |
| 09:45.21 | nevcairiel | so many old map things I already see dying =p |
| 09:47.15 | *** join/#wowuidev nimhfree (~scott@99-117-102-71.lightspeed.sntcca.sbcglobal.net) |
| 10:06.26 | *** join/#wowuidev vince` (vschiu@50.35.70.27) |
| 10:06.47 | *** join/#wowuidev VIad1 (~Vlad@cm-84.213.146.58.getinternet.no) |
| 10:09.30 | *** join/#wowuidev dobson` (~dobson@68.ip-149-56-14.net) |
| 10:10.56 | *** join/#wowuidev Constie_ (~Constie@185-113-98-134.cust.bredband2.com) |
| 10:11.58 | *** join/#wowuidev pnorman_ (pnorman@205.250.46.76) |
| 10:13.47 | *** join/#wowuidev Ermad- (~Ermad@pool-96-246-137-114.nycmny.fios.verizon.net) |
| 10:14.07 | *** join/#wowuidev KaeltenAway (Kaelten@2600:3c01::f03c:91ff:fe15:5b71) |
| 10:14.07 | *** join/#wowuidev KaeltenAway (Kaelten@WoWUIDev/WoWAce/WoWIFA/CurseStaff/kaelten) |
| 10:14.07 | *** mode/#wowuidev [+o KaeltenAway] by ChanServ |
| 10:17.18 | *** join/#wowuidev Kesava (~kesava@unaffiliated/sliker) |
| 10:17.34 | *** join/#wowuidev Arrowmaster (~Arrowmast@WoWUIDev/WoWAce/ResponsibleForEverythingAndNothing/Arrowmaster) |
| 10:26.57 | *** join/#wowuidev AcidWeb1 (~AcidWeb@londe.iosphe.re) |
| 11:37.21 | *** join/#wowuidev Andols (~yaaic@guest.vattenfall.se) |
| 11:38.49 | *** join/#wowuidev jleclanche (uid155154@HearthSim/Founder/Adys) |
| 12:12.17 | *** join/#wowuidev Tercioo (~Tercioo@185.153.176.9) |
| 12:35.15 | *** join/#wowuidev yalb (xsbot@lua/bot/yalb) |
| 12:41.50 | *** join/#wowuidev ls- (~ls@223.204.251.4) |
| 12:45.01 | *** join/#wowuidev Varyak (~Varyak@ppp-82-135-90-95.dynamic.mnet-online.de) |
| 13:03.16 | *** join/#wowuidev ikcerog (~ikcerog@12.165.188.175) |
| 13:52.32 | *** join/#wowuidev Elmoe_ (~Elmoe@24.18.143.238) |
| 13:52.32 | *** join/#wowuidev Gethe_ (~Gethe@cpe-70-112-184-154.austin.res.rr.com) |
| 13:53.12 | *** join/#wowuidev Simca_ (~Simca@c-73-55-2-30.hsd1.fl.comcast.net) |
| 14:34.11 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 14:41.31 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 14:44.00 | *** join/#wowuidev Tercioo (~Tercioo@185.153.176.3) |
| 14:46.25 | *** join/#wowuidev d[karl]b (~karl_w_w@110-175-132-56.tpgi.com.au) |
| 14:55.03 | *** join/#wowuidev Elmoe_ (~Elmoe@24.18.143.238) |
| 14:59.27 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 15:09.07 | *** join/#wowuidev AcidWeb (~AcidWeb@londe.iosphe.re) |
| 15:11.56 | *** join/#wowuidev yalb (xsbot@178.219.36.155) |
| 15:11.56 | *** join/#wowuidev yalb (xsbot@lua/bot/yalb) |
| 15:12.56 | *** join/#wowuidev g0urra (~g0urra@unaffiliated/gourra) |
| 15:19.41 | *** join/#wowuidev Varyak (~Varyak@ppp-82-135-90-95.dynamic.mnet-online.de) |
| 15:34.05 | *** join/#wowuidev Andols2 (~yaaic@m83-185-244-1.cust.tele2.se) |
| 15:47.21 | *** join/#wowuidev harl (harl@unaffiliated/harl) |
| 16:18.27 | *** join/#wowuidev Andols (~yaaic@78-70-44-4-no170.tbcn.telia.com) |
| 16:36.50 | *** join/#wowuidev Semlar (~semlar@72.189.128.149) |
| 16:43.55 | *** join/#wowuidev Elmoe_ (~Elmoe@24.18.143.238) |
| 16:46.06 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 16:49.51 | *** join/#wowuidev pompy (~Mike@c-73-194-183-217.hsd1.nj.comcast.net) |
| 17:53.00 | *** join/#wowuidev Andols (~Andols@78-70-44-4-no170.tbcn.telia.com) |
| 17:54.59 | TheDanW | nevcairiel: hope it helps! |
| 17:56.31 | nevcairiel | still be a lot of work to get everything updated, but at least offers us the tools to do so, so I would think so |
| 18:00.48 | nevcairiel | TheDanW: i also looked over the new map api now that the docs are in, I remember you said its still a WIP, but one thing I noticed so far is that the data to compute a translation to world coordinates (ie. the stuff UnitPosition returns, not sure how you call it) seems to be missing so far? unless I didn't identify it as such in some of the returns |
| 18:05.16 | TheDanW | yeah, i don't think that exists, what uses do you have for it? |
| 18:05.28 | nevcairiel | basically translating UnitPosition to zone coordinates |
| 18:05.44 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:a92f:3e36:5f66:391b) |
| 18:05.44 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 18:05.46 | TheDanW | i see |
| 18:06.04 | nevcairiel | which is also used for positioning things on the minimap, ie. map notes from gathering addons etc |
| 18:06.31 | TheDanW | anything beyond that, would a "get map coordinates for unit" be sufficient? |
| 18:06.35 | nevcairiel | on live thats basically all the info from GetAreaMapInfo and GetWorldMapTransforms |
| 18:07.10 | *** join/#wowuidev Lejving (~Lejving@81-233-148-192-no524.tbcn.telia.com) |
| 18:07.44 | nevcairiel | its also quite handy to translate coordinates between zones, because you have a universal coordinate system you can use at least on the same continent |
| 18:08.01 | nevcairiel | ie. have a coordinate deep in a microdungeon, but show the pin on the continent map |
| 18:09.15 | TheDanW | gotcha, let me talk to the engineer that worked on maps |
| 18:09.29 | nevcairiel | also for distance calculations to way points, since normalized zone coordinates dont hold any real-world relevance |
| 18:09.37 | nevcairiel | basically, map stuff uses it a lot |
| 18:12.36 | nevcairiel | worst case i can steal it out of the db2, but i was really happy to make this library just with API access and no data maintenance for legion :) |
| 18:15.49 | TheDanW | i should have an answer soon, i'd rather keep it in the client also, but i'm not sure if there's a technical reason why it's not available |
| 18:16.28 | nevcairiel | i found the fields in the new db2s, so the data at least still seems to be the same |
| 18:17.16 | nevcairiel | although i'm not sure how UIMapAssignment relates to the plain UIMap |
| 18:23.13 | nevcairiel | (to be precise, what I would like is uiMapId -> instance id (or whatever you call that? the first return of GetAreaMapInfo), and the 4 coordinates from GetAreaMapInfo - and if they still exist, the transforms, or get rid of those, they are annoying |
| 18:30.29 | Thunder_Child | If they exist you want them, but you also want them gone? |
| 18:30.38 | nimhfree | :-) |
| 18:31.02 | Andols | He just wants to push that problem to some C code :P |
| 18:31.34 | nevcairiel | well i didnt see them in some db2 anymore |
| 18:31.39 | nevcairiel | so maybe they are gone |
| 18:31.53 | nevcairiel | (although i fear the concept in game might not be and we just lack that data) |
| 18:34.55 | *** join/#wowuidev tacitAndroid (~tacitAndr@198.74.38.57) |
| 18:37.26 | nimhfree | So, in the new mapping system we will use UiMapID values. Does this mean all the following API will be using them: GetCurrentMapAreaID(), GetMapContinents(), GetMapZones(), GetMapSubzones(), and SetMapByID()? |
| 18:41.43 | nevcairiel | all of those are probably gone and replaced |
| 18:42.15 | nebula | https://github.com/Ellypse/wow-ui-source/blob/beta/AddOns/Blizzard_APIDocumentation/MapDocumentation.lua |
| 18:44.25 | nebula | need to slap the guy who used "UiMap" |
| 18:54.23 | TheDanW | wasn't me! ;p |
| 18:57.11 | nevcairiel | calm your ocd nebula :p |
| 18:58.38 | nimhfree | So with that link to API it appears I can get the name of all the zones by starting with top-level maps and calling C_Map.GetMapChildrenInfo(), but does that mean I need to start arbitrarily at UiMapID 0 and drill down, or will I be able to get a list of continents from API. I know I can keep my own internal list, but using API is much better if possible. |
| 19:02.41 | TheDanW | zones aren't really a uimap concept, as a uimap can represent one or more "zones" |
| 19:05.48 | TheDanW | you could use the map type to try and filter for zones, but i don't think we'll add that to the api directly |
| 19:06.25 | TheDanW | see MapUtil.lua |
| 19:07.29 | Andols | R.I.P Temporary hack |
| 19:07.41 | TheDanW | something like get all continents would be more likely to be implemented there |
| 19:08.02 | TheDanW | i had just updated that comment too :/ |
| 19:09.01 | nevcairiel | i wonder if i'll even need full enumeration anymore, have to think about that |
| 19:11.58 | nevcairiel | an addon that wants to display a zone list might want to |
| 19:12.21 | Andols | 2.1.0 is the first build that a year appears on that comment (According to townlong-yak) |
| 19:12.44 | nimhfree | My addons display the localized zone lists and I use the API I mentioned aboved to get them. |
| 19:13.11 | nevcairiel | yeah for things like mapping localized names to ids that might be needed |
| 19:13.21 | nevcairiel | i believe TomTom uses that for its /way slash command |
| 19:13.51 | nimhfree | yeah, easier that having to use 4 for Durotar, etc. |
| 19:15.07 | Andols | Dan you should add that pice of code back as a comment :P |
| 19:33.46 | *** join/#wowuidev Ammako (~Ammako@unaffiliated/ammako) |
| 19:35.46 | *** join/#wowuidev Ammako (~Ammako@unaffiliated/ammako) |
| 19:36.03 | *** join/#wowuidev tunekey (~tunekey@unaffiliated/tunekey) |
| 19:40.51 | *** join/#wowuidev GreyFox777 (25d17b4b@gateway/web/freenode/ip.37.209.123.75) |
| 19:41.06 | GreyFox777 | Anyone here guys? |
| 19:41.44 | Ammako | there you go |
| 19:42.12 | GreyFox777 | Guys, can some one tell me, how can i create a player frame texture with oUF and make it clickable? |
| 19:44.42 | nevcairiel | I would recommend to go check the oUF forum for some beginner guides, but apparently you found that already |
| 19:55.56 | *** join/#wowuidev schlumpf (~schlumpf@ip5f5ae52d.dynamic.kabel-deutschland.de) |
| 20:03.48 | Fisker | Hey Seerah |
| 20:06.21 | *** join/#wowuidev Cairenn (~Karen@MMOI/Administratrix/Cairenn) |
| 20:06.21 | *** mode/#wowuidev [+o Cairenn] by ChanServ |
| 20:14.39 | *** join/#wowuidev Cairenn (~Karen@MMOI/Administratrix/Cairenn) |
| 20:14.39 | *** mode/#wowuidev [+o Cairenn] by ChanServ |
| 21:34.47 | Ellypse | TheDanW: I would LOVE a "get map coordinates for unit", especially if it doesn't require the player to be looking at the map they are currently in :D |
| 21:36.00 | schlumpf | just expose object manager already |
| 21:43.42 | [TOM_RUS] | schlumpf: too easy |
| 21:46.00 | TheDanW | most map APIs will no longer require you to set the map first, you just use the uiMapID that you want |
| 21:46.10 | TheDanW | there's a few we apis we haven't gotten to yet |
| 21:46.26 | TheDanW | converting unit coordinates will certainly follow suit |
| 21:46.30 | Funkeh` | what if you want the current uiMapID |
| 21:46.49 | TheDanW | define current uiMapID |
| 21:46.59 | Funkeh` | the one you're standing in |
| 21:47.09 | TheDanW | you can be standing in multiple |
| 21:47.19 | Funkeh` | eh? |
| 21:47.20 | TheDanW | a uiMap is a view onto the physical world |
| 21:47.21 | schlumpf | just return E_COSMIC |
| 21:48.01 | TheDanW | exactly, if you're in a dungeon you're in the cosmic, continent, zone, and dungeon map |
| 21:48.10 | TheDanW | and any partial views of those |
| 21:48.40 | Funkeh` | if you're in a dungeon and you want the current map ID, previously it would return the dungeon map, now it should return the uiMapID, which is the map+floor |
| 21:49.18 | Funkeh` | that's what I meant by current id |
| 21:49.52 | TheDanW | perhaps "best" uiMap for some world coordinate |
| 21:50.05 | schlumpf | what about having `current_map()` return a stack of maps? i.e. the whole `[cosmic, continent, zone, area|(dungeon,floor)]`? |
| 21:50.12 | Funkeh` | ill put it another way |
| 21:50.20 | Funkeh` | if i press M how does it know what to show |
| 21:51.04 | schlumpf | a lot of hacks, last time I checked |
| 21:51.12 | TheDanW | that API isn't finalized |
| 21:51.20 | Funkeh` | well that's what we need |
| 21:51.25 | Funkeh` | a "current id" |
| 21:51.30 | Semlar | i'll finalize you in a minute |
| 21:51.47 | TheDanW | best map id, sure |
| 21:52.25 | Funkeh` | best map id, as in, if the area you're in doesn't have a map, it falls back to the next level up? |
| 21:52.30 | Semlar | do you have any thoughts about adding an api to fetch data about subzones |
| 21:52.37 | Ellypse | But for example C_Map.GetCurrentMapID() returns the current map viewed ID, not the current map ID the player is on, so I would assume a C_Map.GetCurrentMapPosition() would return the current position on the viewed map. But maybe not then? |
| 21:52.54 | Semlar | areas that change the minimap name but don't have their own maps |
| 21:53.03 | Funkeh` | ^ exactly, needs one that returns the one the player is on |
| 21:53.35 | Funkeh` | i.e. a replacement for GetPlayerMapAreaID("player") |
| 21:53.39 | schlumpf | I wish that there was at little as possible "current" state. returning anything based on "current" state rather than a given relation is a bad idea, even if it feels like making stuff easier |
| 21:54.05 | TheDanW | basically what schlumpf is saying, that's why i'm resistant to anything like that |
| 21:54.09 | schlumpf | the "coordinates are relative to the currently visible `M` map" notion was a horrible idea to begin with |
| 21:54.30 | TheDanW | it's two parts, what are my world coordinates? whats is the "best" map to display these world coordinates? |
| 21:54.55 | Funkeh` | that's fine |
| 21:54.59 | Funkeh` | as long as it's doable |
| 21:55.04 | schlumpf | TheDanW: is there a reason other than "bots may use it" to not expose actual worldcoords,map these days? |
| 21:55.52 | Ellypse | Right now for example if the user is looking at Stormwind's map but he's in Ironforge and I need to get his map coordinates I quickly set the map to Ironforge, get the coordinates, then set him back to the map he was on, which fires a lot of stuff, dismiss dropdowns, etc. |
| 21:56.21 | schlumpf | Ellypse: that's <8.x API, or also the new one? |
| 21:56.22 | TheDanW | normalized coordinates are simpler in the UI, it's rare that world coordinates are the space to work in |
| 21:56.49 | Ellypse | The 8.x apis "current" still relates to "currently viewed" not "currently in" from my testings |
| 21:57.15 | Ellypse | C_Map.GetCurrentMapID() would return Stormwind and not Ironforge in that previous case |
| 21:58.18 | TheDanW | we do expose world coordinates already |
| 21:58.18 | schlumpf | TheDanW: so "bots may use it" isn't even the reason but "doing worldcoords -> ui mapping in lua is a pain"? always thought it was bots to not expose actual coords |
| 21:58.22 | schlumpf | you do?! |
| 21:58.31 | schlumpf | I must have missed stuff big time |
| 21:58.35 | TheDanW | UnitPosition("player") |
| 21:59.03 | TheDanW | can't get them in dungeons/raids/pvp however |
| 21:59.08 | Ellypse | But that's world coordinates not map coordinates, that's why I said the "get unit map coordinates" was interesting to me when you mentioned it ^^ |
| 21:59.15 | schlumpf | > z = 0 constant, restrictions, not all units (?) |
| 21:59.33 | Semlar | when can i expect an api to recreate this https://i.imgur.com/ro1nQWD.jpg |
| 21:59.55 | TheDanW | needs to be you or party member |
| 22:00.26 | Semlar | 8.1? |
| 22:00.34 | TheDanW | the restrictions aren't for bots, it's for addons - bots aren't relevant to map api |
| 22:01.19 | schlumpf | TheDanW: obviously they aren't, but there still is weird restrictions which seem to be minor anti-cheats, like ah knowing exact times but only exposing those categories |
| 22:01.25 | Funkeh` | so if I want to get the current map the player is in I need to request the map of my coords... which isn't available in dungeons? |
| 22:01.34 | schlumpf | I totally forgot about unitposition being worldcoords. I withdraw all my complaints. z would be nice (to emulate dungeon floor). with that, and dbc -> luatable, one can do everything manually. z really is the only thing missing. |
| 22:01.51 | Funkeh` | then how does one re-create SetMapToCurrentZone getid() for dungeons? |
| 22:03.39 | [TOM_RUS] | schlumpf: UnitPosition only works on map type 0, basically exclues all other types where it was useful... |
| 22:03.55 | schlumpf | yeah, I know. the question here is what the use case is in the end. |
| 22:04.14 | schlumpf | for you it is hacks, obviously, [TOM_RUS]. |
| 22:04.31 | schlumpf | others are likely bossmods trying to hack around position restrictions |
| 22:04.49 | schlumpf | not sure about what are real world use cases that are not target for restriction |
| 22:04.52 | TheDanW | we've already discussed why UnitPosition restrictions are in place, i don't have any additional information on it |
| 22:04.54 | schlumpf | tomtom? |
| 22:04.58 | tz | I had a bossmod back in the day, which auto-swapped out macros and talents based on proximity to an encounter |
| 22:05.08 | tz | something I *really* missed |
| 22:05.23 | tz | RIP YesBoss |
| 22:05.35 | schlumpf | tz: iirc there still is an addon for that but just based on mouseover? |
| 22:05.41 | Ellypse | My RP use map coordinates to know if a player is in a spot where he can look for stuff to pick up or to trigger D&D type of events, so it's being a victim of those boss mods restrictions :P |
| 22:05.45 | nebula | i mean, that wouldn't really be hard to use mapids for |
| 22:05.51 | Ellypse | *RP addon |
| 22:05.52 | tz | mouseover could be done, yes, but it doesn't help when there are some encounters that don't spawn instantly |
| 22:06.04 | tz | actually |
| 22:06.11 | schlumpf | Ellypse: you guys rp in instanced stuff? |
| 22:06.21 | tz | BOSS_ENCOUNTER_START, does that still have combat lockdown applied, or is it beforehand? |
| 22:06.29 | Ellypse | A lot of elves like to RP on Sunwell Plateau |
| 22:06.41 | schlumpf | tz: iirc encounter start is somewhat same time as combat enter |
| 22:06.48 | schlumpf | Ellypse: eww. |
| 22:07.04 | tz | it should be same time, yes |
| 22:07.15 | tz | but if it's not iin combat lockdown then I can change macros and whatnot |
| 22:07.23 | Funkeh` | TheDanW: Im not asking for UnitPosition restrictions to be removed =P I don't care about coords, I care about dungeon floor |
| 22:08.41 | Ellypse | And I'm not asking for restrictions to be removed either btw. I just saw an opportunity to get a way to get current player coordinates on the map they are in without having to quickly swap the map the World map frame is currently displaying ^^ |
| 22:08.50 | schlumpf | TheDanW: I don't want to have restrictions removed either (and think they are good), but have you guys thought about `MapRec::expansionID != CURRENT_EXPANSION` removing restrictions? |
| 22:09.34 | nebula | seems silly |
| 22:09.45 | schlumpf | nebula: it does fix the gay elf issue |
| 22:09.55 | nebula | nothing fixes the gay elf issue |
| 22:09.56 | schlumpf | Ellypse: I haven't looked at the new api too much, but I hope that there is way more context arguments with less relying on previously set state. |
| 22:10.10 | tz | all I want is a non-combat UnitDistanceToEJEncounter() :P |
| 22:11.36 | schlumpf | tz: `ChooseBestTalentsAndMacrosAndGearAndJustInstakillEJEncounterAndDisplay3DInteractiveGuideAndPauseGameBeforeStuffHappensSoThePlayerCanReactMoreEasily()` |
| 22:11.47 | tz | pretty much |
| 22:11.57 | Ellypse | I basically tried C_Map.GetMapInfo(C_Map.GetCurrentMapID()) and it followed the map that was set on the world map frame. There is no GetPosition type of functions in the API as far as I know, at least it's not in the documentation |
| 22:12.05 | schlumpf | well, dan, we have the api we want. go implement! |
| 22:12.12 | tz | nah it was stupidly handy being able to swap out macros for a boss |
| 22:13.09 | schlumpf | tz: even on farm, do you really run into bosses while they are still spawning instantly pulling the second they spawn? I mean, yeah, I had those, but do you really want to optimize for those cases? |
| 22:13.45 | tz | doesn't really matter, I killed the addon when the UnitPosition change went in |
| 22:16.07 | tz | I did remember looking at ENCOUNTER_START way back when, but I think the IDs weren't cross-referencable with EJ unless you dumped out a DB2 or whatever |
| 22:16.29 | tz | ...and I was too lazy to write any tooling for it *shrug* |
| 22:17.54 | schlumpf | so yeah, the known use cases are a) avoid mouseover to auto-talent to save seconds on farm runs; b) do RP in old expansions ( -> lift restrictions in outdated content, possibly with player->level > expansion->level to not fuck over retro raiding); c) properly document ellypses use case and make it less awkward to use with `C_Map.GetCurrentBestEffortMapID()` based on position rather than state for UX. c) was what I thought was a |
| 22:28.30 | Simca_ | schlumpf: no Z in UnitPosition because of AVR addon |
| 22:28.58 | Simca_ | tl;dr they exposed Z once in Wrath, it went real badly |
| 22:29.12 | nebula | i'm not sure how avr would use your z position, it needed camera xyz, not player positions |
| 22:29.29 | Simca_ | that's true, it was camera Z |
| 22:29.48 | tz | I thought it needed player Z for placement of things on the HUD for other units? |
| 22:30.11 | nebula | i do miss drawing genitalia around dalaran |
| 22:30.52 | schlumpf | Simca_: I remember cryect's 3d map thing in BC even. was so beautiful |
| 22:32.01 | nimhfree | So in the new world of maps are we going to get the event ZONE_CHANGED_NEW_AREA? |
| 22:32.41 | nevcairiel | those events are unrelated to the map really |
| 22:33.50 | nimhfree | I worry about (1) where in the world the player is, and (2) what map is actually being shown to the user (as they can show maps other than where they are) |
| 22:34.20 | nimhfree | Therefore, I need to know when either of these things change, and ZONE_CHANGED_NEW_AREA was the way to get one. |
| 22:34.32 | nevcairiel | they are also said to be reworking the world map frame, but you can always ask that what it shows anyway, should be much easier with only one id being involved for everything |
| 22:34.55 | nevcairiel | and there is a lot more events that can change the currently relevant map |
| 22:35.18 | nimhfree | yeah, for me having no dungeons/floor levels makes my life easier, because I just look at the mapId of the currently displayed map and draw my pins that go there |
| 22:35.52 | nevcairiel | in fact the worldmap supports a new data provider api, so maybe you can just register with that and let framexml render pins |
| 22:35.54 | nimhfree | I just allow the user to have the open map switch automatically to the current zone they are in (like on a taxi) |
| 22:36.00 | nevcairiel | i havent looked into details of that yet |
| 22:37.01 | nimhfree | so if I understand what you are saying, I register my app with the map and it queries me to ask what pins should be displayed based on what it is showing. that will make my event processing a lot esier if that works like that. |
| 22:37.28 | nevcairiel | thats at least how i understand it theoretically |
| 22:38.28 | nimhfree | will HBD need its pin support then? |
| 22:38.38 | nevcairiel | for minimaps at the very least |
| 22:39.11 | nimhfree | so this new possible API will only be for the main map then? |
| 22:39.34 | nevcairiel | yes |
| 22:40.53 | nimhfree | I hope these pins the new map might be able to render for us will allow us to provide our own tooltips |
| 22:41.09 | nevcairiel | go read the code and find out =p |
| 22:41.28 | nimhfree | which bit is it in? |
| 22:42.00 | nevcairiel | WorldMap and MapCanvas addons mostly |
| 22:42.26 | nevcairiel | its used for stuff like world quests, so i wo uld assume it can hook up tooltips |
| 22:43.41 | nevcairiel | apparently it has a OnMouseEnter callback you can make a tooltip in |
| 22:59.03 | [TOM_RUS] | schlumpf: but it's good idea to make UnitPosition to be useful again, if blizzard suck at making proper encounter visuals, let addons do the job |
| 22:59.34 | Semlar | i think they should just disable all addons inside of instances |
| 23:00.37 | nebula | for russians, atleast |
| 23:01.38 | Semlar | that probably wouldn't be very effective |
| 23:07.39 | nimhfree | people really like their addons that report damage though... |
| 23:22.58 | schlumpf | if maprec.type == map && player.name == [tom_rus]: disconnect() |
| 23:23.03 | *** join/#wowuidev Seerah (~umsin@2601:3c2:80:1380:a92f:3e36:5f66:391b) |
| 23:23.03 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 23:23.39 | [TOM_RUS] | schlumpf: I bet they are already hardcoded -20% DPS on my characters |
| 23:24.51 | schlumpf | they probably hired someone to just tune in on your raids and spawn void zones below you |
| 23:32.31 | *** join/#wowuidev Tercioo (~Tercioo@185.153.176.2) |
| 23:39.53 | *** join/#wowuidev NickG365 (~NickG365@cortex.starlabs.theflash.rocks) |
