| 00:04.18 | *** join/#wowuidev Resike (~Resike@62.77.234.203) |
| 00:05.43 | Resike | TheDanW: Every time you cast a channel spell, you get swarmed by an OnUpdate PLAYER_STARTED_MOVING and PLAYER_STOPPED_MOVING events, explain whats that for. |
| 00:39.56 | Corrodias | that sounds like a bug, dunnit |
| 01:19.59 | *** join/#wowuidev purl (ibot@rikers.org) |
| 01:19.59 | *** topic/#wowuidev is Happy Holidays! || 7.3.x ToC: 70300 || http://pastebin.com || Battletags: http://goo.gl/2bm7n || #WoWUIDev-commits: CIA & JIRA bots reporting || This channel is logged, via purl |
| 01:29.24 | _Tim_ | you started moving your hands to channel that spell, dur! |
| 01:48.55 | *** join/#wowuidev dobson (~dobson@68.ip-149-56-14.net) |
| 02:08.42 | *** join/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 02:08.42 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 02:43.07 | *** part/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 02:54.09 | *** join/#wowuidev bluspacecow (~bluspacec@121.99.98.200) |
| 02:54.09 | *** mode/#wowuidev [+v bluspacecow] by ChanServ |
| 03:06.43 | Resike | then needs to be added for the others spells too! |
| 05:22.07 | *** join/#wowuidev Myrroddin (~psvan@S010600fc8df0e0b3.ed.shawcable.net) |
| 05:30.49 | *** join/#wowuidev ShadniX (dagger@79.249.244.144) |
| 06:50.25 | *** join/#wowuidev ajmitch (ajmitch@ubuntu/member/ajmitch) |
| 07:11.19 | *** join/#wowuidev Andols2 (~yaaic@83.185.247.251) |
| 07:41.59 | *** join/#wowuidev Guest11471 (~Vlad@cm-84.213.146.58.getinternet.no) |
| 07:52.49 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 07:57.25 | *** join/#wowuidev Borkr (~Borkr@mail.seaonics.com) |
| 08:12.03 | *** join/#wowuidev Borkr (~Borkr@mail.seaonics.com) |
| 08:53.37 | *** join/#wowuidev Ellypse (~Ellypse@213.246.214.170) |
| 09:15.51 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 09:30.17 | *** join/#wowuidev Lynxium (~Lynxium@bzq-79-178-191-215.red.bezeqint.net) |
| 09:42.57 | *** join/#wowuidev Exality (~Exality@78.154.143.158) |
| 09:49.37 | *** join/#wowuidev Exality_ (~Exality@78.154.131.56) |
| 10:07.33 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 10:34.33 | *** join/#wowuidev Kesava (~kesava@unaffiliated/sliker) |
| 10:55.39 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 12:23.22 | *** join/#wowuidev Andols2 (~yaaic@193.10.195.209) |
| 12:25.22 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 13:07.10 | *** join/#wowuidev Andols (~yaaic@193.10.195.209) |
| 13:18.27 | *** join/#wowuidev Andols2 (~yaaic@193.10.195.209) |
| 14:27.17 | *** join/#wowuidev Andols (~yaaic@m83-185-247-251.cust.tele2.se) |
| 14:38.23 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 15:09.18 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 15:45.57 | *** join/#wowuidev Andols2 (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 16:01.09 | *** join/#wowuidev Lynxium[] (~Lynxium@bzq-79-178-191-215.red.bezeqint.net) |
| 16:04.43 | *** join/#wowuidev Lynxium (~Lynxium@bzq-79-178-191-215.red.bezeqint.net) |
| 16:37.42 | *** join/#wowuidev Andols (~yaaic@m83-185-247-251.cust.tele2.se) |
| 16:51.19 | *** mode/#wowuidev [+o eir] by ChanServ |
| 16:51.19 | *** mode/#wowuidev [-bo Creator974!*@* eir] by eir |
| 16:52.21 | *** join/#wowuidev aprok (~Albrecht@x5ce0360a.dyn.telefonica.de) |
| 17:37.54 | *** join/#wowuidev Andols2 (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 17:53.24 | Gnarfoz | [20:10:15] <znf> https://www.youtube.com/watch?v=Rgn4bwvceVs [20:10:17] <znf> what the fuck <-- the wtf thing about that is the UI |
| 17:53.58 | znf | that too |
| 18:04.22 | TheDanW | Resike: [arena] seems reasonable, will add to list |
| 18:13.24 | *** join/#wowuidev Seerah (~umsin@2601:3c2:101:320:64f9:56d6:4219:6d7f) |
| 18:13.24 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 18:17.00 | TheDanW | Funkeh`: spell text (name, description) retrieval on PTR is async, you'll have to wait until the appropriate event signals before its available |
| 18:17.54 | TheDanW | Chipzz: sure, let me know of any bugs |
| 18:17.56 | Funkeh` | TheDanW: event?? |
| 18:24.08 | Funkeh` | TheDanW: that seems somewhat hacked together if that's the case? |
| 18:24.36 | Funkeh` | it's also only failing on the exact same spells every time |
| 18:26.16 | Funkeh` | 26662 (berserk) being one that stood out |
| 18:28.10 | Funkeh` | SPELL_NAME_UPDATE |
| 18:28.16 | Funkeh` | well, this is pretty dumb |
| 18:28.35 | Funkeh` | why not give us an API call specifically for the spel name to avoid this confusion TheDanW? |
| 18:29.23 | Funkeh` | also SPELL_NAME_UPDATE isn't the best name when (i assume) it also signals the spell description is available |
| 18:29.41 | Funkeh` | lol no it doesn't |
| 18:29.51 | Funkeh` | how the hell do we get the spell description now? :D |
| 18:31.39 | Funkeh` | ok so GetSpellInfo is just broken and returns "" always |
| 18:31.45 | Funkeh` | GetSpellDescription works |
| 18:35.12 | Funkeh` | TheDanW: what will be the benefit of this major headache for many addons? |
| 18:35.40 | Stanzilla | <PROTECTED> |
| 18:36.45 | TheDanW | Funkeh`: depends on the system you're working in, for GetSpellInfo its SPELL_NAME_UPDATE |
| 18:37.46 | Funkeh` | (it's broken GetSpellInfo always returns "" for desc) |
| 18:38.24 | TheDanW | GetSpellInfo doesn't return the desc |
| 18:38.29 | TheDanW | only name and subtext |
| 18:38.56 | Funkeh` | my bad, dunno what the 2nd arg is then |
| 18:39.01 | TheDanW | fwiw, this is on the test realm, it's not final |
| 18:39.03 | nevcairiel | it used to be rank |
| 18:39.08 | TheDanW | subtext isn't used much |
| 18:39.14 | TheDanW | any more |
| 18:40.23 | Funkeh` | should just remove spell name from getspelinfo imo |
| 18:40.37 | Funkeh` | should be like a standard query |
| 18:40.42 | Funkeh` | query api with no return |
| 18:40.47 | Funkeh` | get result in event |
| 18:40.51 | nevcairiel | its not like its any different to GetItemInfo |
| 18:43.35 | Funkeh` | TheDanW: weren't you saying at some point you were trying to keep event firing to a minimum though? |
| 18:45.31 | *** part/#wowuidev aprok (~Albrecht@x5ce0360a.dyn.telefonica.de) |
| 18:52.51 | TheDanW | i'll probably get it changed to return nil instead of empty string, but we're not changing the return values for now |
| 18:53.24 | TheDanW | i'm not ecstatic about this approach, but it's a pattern we already have |
| 18:53.52 | Funkeh` | it will just result in needing libraries for every API call if it continues |
| 18:56.15 | foxlit | I wonder if player abilities are permanently cached |
| 19:18.19 | Fisker | I meant hey Seerah |
| 19:18.30 | Seerah | hihi |
| 19:18.43 | Fisker | :D |
| 19:56.07 | [TOM_RUS]|2 | TheDanW: how will we know if spellid is valid if it will return nil even for valid spells? keep it "" |
| 19:57.04 | Thunder_Child | I think that was for the second arg. |
| 19:57.46 | Funkeh` | i thought so too |
| 20:03.17 | *** join/#wowuidev schlumpf (~schlumpf@ip5f5ae54e.dynamic.kabel-deutschland.de) |
| 20:04.49 | Funkeh` | TheDanW: is it still being worked on? Because on live, the first call to a getspellinfo takes 0.02ms for me, with subsequent calls taking 0.016ms. On PTR the first call takes 0.07ms, the rest take 0.03ms |
| 20:05.10 | Funkeh` | seems like a downgrade |
| 20:06.34 | Funkeh` | i'm completely ignoring the length of time it takes for the event to arrive, that's just processing the api call |
| 20:14.12 | TheDanW | yeah, it's actively being worked on, it's being done outside of the UI team, so iteration from feedback is a bit slower |
| 20:15.49 | TheDanW | [TOM_RUS]|2: i'd rather add IsSpellIDKnown or similar |
| 20:27.09 | Funkeh` | TheDanW: tell them "you suck, do it again" 10/10 valid feedback |
| 20:41.28 | *** join/#wowuidev Talyrius (uid175475@gateway/web/irccloud.com/x-fywnpquiojicnhqw) |
| 21:06.01 | elvador | TheDanW: should GetSpellDescription return the desc after SPELL_NAME_UPDATE for the respective spell? or is the desc separate somehow? |
| 21:16.16 | Chipzz | TheDanW: my issue is related to the relativeKey xml attribute. it would be helpfull if you could clarify a couple of things |
| 21:17.31 | Chipzz | 1) almost all occurences save a few start with "$parent." Are those that don't a bug or a valid case in theory? would relativeKey="some_anchor" refer to an anchor on the same Region? |
| 21:19.16 | Chipzz | 2) does "$parent." recurse in the same or a similar way as the name="$parent..." (ie recursing up the chain until you find a Region with a name)? or should you use "$parent.$parent." ...? |
| 21:20.17 | Chipzz | 3) what happens when relativeKey refers to an object that doesn't exist? is the parent region used? |
| 21:22.22 | Chipzz | I have detected 4 cases where traversing further up the chain does find a field that's not found on the Region itself, |
| 21:22.44 | Chipzz | and plenty more where the field isn't found at all even when looking further up the chain |
| 21:23.56 | Chipzz | but I'm not sure those 4 are expected behaviour or not, and whether "$parent.$parent...." would be the appropriate fix |
| 21:57.44 | ThiefMaster | i guess the update that adds async GetSpellInfo will break pretty much all addons that do anything with spells? ;x |
| 22:04.08 | nebula | if the spell data isn't available, rip |
| 22:05.52 | elvador | TheDanW: Did some testing. For most spells, the description is available right on SPELL_NAME_UPDATE. For others though, the description is only available on the next frame after the event. Here are the spell ids I tested it with and can reproduce it 100% of the time: 3026, 175423, 238659, 239031. There are probably many others, but I guess those are enough to debug it. |
| 22:07.53 | elvador | TheDanW: GetSpellInfo(242836) shows an ugly red error on the screen (Reached Max Spell Parsing Recursion Depth; Parsing Spell ID: 239113) https://i.imgur.com/rxsWcYA.png |
| 22:37.56 | TheDanW | elvador: looks like GetSpellDescription isn't handling the cache miss correctly, i'll pass it on, thanks - it should be available when SPELL_NAME_UPDATE fires (which isn't a very good event name) |
| 22:58.46 | TheDanW | Chipzz: 1) relativeKey always starts at the current object, it's a bit of a misnomer, it would more accurately be relativeChildKey or something |
| 22:59.09 | TheDanW | 2) you can have any number of $parent, it'll move up one level as you'd expect |
| 23:00.27 | TheDanW | 3) if there is no relative key or you leave it empty it refers to itself - if you reference an invalid region it stops there and uses the last region it found |
| 23:00.37 | TheDanW | which may be itself if the first key is invalid |
| 23:01.37 | TheDanW | actually, if you leave relativeKey empty i think you get an XML error |
| 23:02.23 | TheDanW | you also would if it ended up resolving to itself |
| 23:49.49 | Chipzz | TheDanW: 1 $parent is equivalent to exactly 1 GetParent(), right? |
| 23:52.39 | *** join/#wowuidev Exality (~Exality@78.154.131.56) |
| 23:53.57 | TheDanW | Chipzz: yup |
