| 02:56.18 | *** join/#wowuidev purl (ibot@208.53.50.138) |
| 02:56.18 | *** topic/#wowuidev is 7.1.x ToC: 70100 || http://pastebin.com || Battletags: http://goo.gl/2bm7n || #WoWUIDev-commits: CIA & JIRA bots reporting || This channel is logged, via purl |
| 06:12.25 | *** join/#wowuidev Andols (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 06:25.39 | *** join/#wowuidev avi90 (avi90@gateway/shell/panicbnc/x-hkxybqjpzdxpvqup) |
| 06:31.06 | *** join/#wowuidev Valhorth (~space@athena.framed.be) |
| 07:42.47 | *** join/#wowuidev Andols2 (~yaaic@m83-185-246-65.cust.tele2.se) |
| 07:48.16 | *** join/#wowuidev Yargoro (~yargoro@catv-89-133-134-186.catv.broadband.hu) |
| 07:54.39 | *** join/#wowuidev Shockah|Work (~Shockah@185.28.17.74) |
| 08:03.07 | *** join/#wowuidev VIad (~Vlad@cm-84.213.146.58.getinternet.no) |
| 08:15.51 | *** join/#wowuidev dRiN (uid18750@gateway/web/irccloud.com/x-kqkurmzuheprtfns) |
| 08:22.59 | *** join/#wowuidev Andols (~yaaic@193.10.192.216) |
| 08:35.18 | *** join/#wowuidev bshelden (~bshelden@unaffiliated/dashkal) |
| 08:53.04 | *** join/#wowuidev Andols2 (~yaaic@83.185.246.65) |
| 09:03.56 | *** join/#wowuidev Andols (~yaaic@193.10.192.216) |
| 09:18.46 | *** join/#wowuidev stolenlegacy (~stolenleg@213-47-49-27.cable.dynamic.surfer.at) |
| 09:18.46 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 09:57.23 | VIad | the rank 3 for alchemy "prolonged potion" should be also a drop from the withered training boss in the same room tbh |
| 10:16.35 | *** join/#wowuidev dajova_ (~Dajova@c-c70de255.010-44-6e796b1.cust.bredbandsbolaget.se) |
| 11:34.39 | *** join/#wowuidev Andols2 (~yaaic@m83-185-246-65.cust.tele2.se) |
| 11:41.44 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 11:51.09 | *** join/#wowuidev haste (haste@faxtrola.ixo.no) |
| 12:04.39 | nevcairiel | that recipe isnt that great anyway, when you produce 10 in one go and proc one extra ... |
| 12:18.18 | *** join/#wowuidev Aftermathh (3e147f5c@gateway/web/freenode/ip.62.20.127.92) |
| 12:18.30 | znf | Hanzo just killed me (Orisa) trough 2 shields |
| 12:18.30 | znf | wtf |
| 12:22.00 | Shockah|Work | simple geometry |
| 12:22.49 | *** join/#wowuidev Andols (~yaaic@193.10.192.216) |
| 12:24.32 | Aftermathh | Can anyone tell me what this error means? Error: https://hastebin.com/zayavuboni.md Code: https://hastebin.com/mepomivafa.sql |
| 12:29.08 | *** join/#wowuidev Andols2 (~yaaic@193.10.192.216) |
| 12:38.05 | Semlar | ? |
| 12:41.17 | Semlar | Aftermathh: is this tooltip.lua because the line numbers don't appear to match what's in the error message |
| 12:43.18 | Semlar | you have, most probably, a function that's causing itself to be called in an infinite loop |
| 12:43.46 | Aftermathh | https://hastebin.com/egaxowevup.sql |
| 12:43.56 | Aftermathh | This should be right |
| 12:44.04 | Semlar | okay |
| 12:44.25 | Semlar | every time OnTooltipSetUnit fires, you're calling TooltipStatusBar:HookScript("OnValueChanged" |
| 12:44.43 | Semlar | this adds an additional hook every single time that tooltip gets set to a unit |
| 12:46.51 | Semlar | you're also creating an anonymous function every time this gets run but that's less of a problem |
| 12:49.25 | Semlar | i don't see anything obvious that would be causing a loop, so it might just be from stacking a ton of hooks on top of each other |
| 12:49.40 | Semlar | when does the error occur |
| 12:50.24 | Semlar | as soon as you mouse over somebody? |
| 12:50.43 | Aftermathh | Oh, that makes sense. |
| 12:50.48 | Aftermathh | Well it only happens sometimes |
| 12:51.06 | Aftermathh | Really not often |
| 12:51.08 | Semlar | if it's only after running it for a while it's probably just from a lot of hooks |
| 12:52.01 | Semlar | every time the tooltip gets set to a unit it's adding another one, which means when OnValueChanged fires on the status bar it's running a function for each hook that was set |
| 12:52.25 | Semlar | so you need to add something to prevent it from hooking the same status bar more than once |
| 12:53.03 | Semlar | and if you're only dealing with one status bar then you don't even have to keep track, you just need to make sure that your hook is only set once |
| 12:53.34 | znf | best shit ever |
| 12:53.44 | znf | use orisas' right click action on Oasis, the one with the hole in the middle :D |
| 12:54.15 | Aftermathh | Okay, so i need to do like a check? |
| 12:55.26 | Aftermathh | or a hooksecure for the tooltip? |
| 12:55.31 | Semlar | you're only dealing with a single status bar, so you just need to move your UpdateStatusBar function and your TooltipStatusBar:HookScript("OnValueChanged" outside of the function that they're in |
| 12:55.48 | kullervo | znf: Oasis doesn't have any holes in the middle, you're thinking of Ilios well |
| 12:56.08 | Semlar | you'll have to modify it so that "Unit" gets set in a way that the UpdateStatusBar function knows which unit to check |
| 12:56.08 | kullervo | znf: except maybe the Oasis indoor map, in which case the hole doesn't really do anything |
| 12:56.28 | kullervo | there's even a health pack down there |
| 12:56.29 | Aftermathh | Alright! Cheers :) |
| 12:56.40 | Semlar | although you can probably just use the second return from Tooltip:GetUnit() |
| 12:56.51 | znf | kullervo, yes... |
| 12:57.00 | znf | kullervo, I just pulled the whole enemy team off the point with that |
| 12:57.14 | Semlar | Aftermathh: like local _, Unit = Tooltip:GetUnit() at the top of UpdateStatusBar |
| 12:57.21 | kullervo | I suppose, with junkrat meta, it could be a devastating drop anyway |
| 12:58.01 | Semlar | actually you'll probably have to move more of this outside of that function |
| 12:58.09 | znf | or just getting them off that Overtime ;-) |
| 12:58.19 | Semlar | since you're relying on variables set earlier |
| 12:58.30 | kullervo | znf: http://i.imgur.com/c9DPjBq.jpg junkrat fucks up orisa |
| 12:58.38 | Semlar | also you really, really shouldn't do something like local UnitIsPlayer = UnitIsPlayer(Unit) |
| 12:58.59 | Semlar | because you're overwriting the UnitIsPlayer function with a variable in the local scope |
| 12:59.21 | Semlar | and not only is that confusing, it's going to prevent you from being able to call that function if you want to |
| 13:00.47 | znf | kullervo, cool |
| 13:00.51 | Aftermathh | Hmm okay, do you mind fixing the code how u mean if u got time? :) |
| 13:03.13 | Semlar | if i do it for you you won't learn how to do it for yourself next time |
| 13:04.19 | Semlar | you know what the cause of the problem is, so you just need to figure out how to write it so that doesn't happen |
| 13:05.43 | Aftermathh | Well, i think its easier to learn when someone points out/show whats wrong and how others think :) |
| 13:10.54 | *** join/#wowuidev ikcerog (~ikcerog@12.165.188.170) |
| 13:11.47 | znf | kullervo, it's nice that we finally have a hero that can immune mei's ice globe thingie |
| 13:14.20 | kullervo | zarya mate |
| 13:19.47 | *** join/#wowuidev Sintacks (~Syntax@74-194-187-125.swbycmtk01.res.dyn.suddenlink.net) |
| 13:32.57 | *** join/#wowuidev PhatsoTGT (~PhatsoTGT@unaffiliated/phatsotgt) |
| 13:46.23 | *** join/#wowuidev dajova_ (~Dajova@c-c70de255.010-44-6e796b1.cust.bredbandsbolaget.se) |
| 13:49.43 | *** join/#wowuidev karl_w_w (~karl_w_w@110-175-132-56.tpgi.com.au) |
| 13:50.45 | pompy | Semlar: just so you are aware https://www.facebook.com/45thSpaceWing/posts/10158222992320012 |
| 13:51.04 | Semlar | spaaaaace |
| 13:51.58 | karl_w_w | looks like it' |
| 13:52.06 | karl_w_w | s time to reinstall windows |
| 13:52.10 | karl_w_w | feels bad man |
| 14:00.52 | *** join/#wowuidev Dajova (~Dajova@c-c70de255.010-44-6e796b1.cust.bredbandsbolaget.se) |
| 14:19.12 | *** join/#wowuidev Aftermathh (3e147f5c@gateway/web/freenode/ip.62.20.127.92) |
| 14:26.18 | *** join/#wowuidev Andols (~yaaic@193.10.192.216) |
| 14:29.47 | Aftermathh | Could anyone tell me why even though i have checks for frames to not re-create it does anyway? I only does when i move items to a new slot. Code: https://hastebin.com/isaxayoyam.sql Lines: 57-90. |
| 14:35.51 | *** join/#wowuidev Ressy (~Ressy@WoWUIDev/WoWAce/ARL/Ressy) |
| 14:36.58 | Semlar | where is this creating something |
| 14:37.46 | *** join/#wowuidev Andols2 (~yaaic@m83-185-246-65.cust.tele2.se) |
| 15:07.10 | znf | kullervo, how come Orisa is disabled in competitive? |
| 15:07.22 | kullervo | to give everyone equal opportunity |
| 15:07.38 | znf | equal opportunity...? |
| 15:07.46 | kullervo | not everyone practised on ptr |
| 15:10.26 | Shockah|Work | also to reduce the number of idiots rushing with a new hero into ranked i guess? |
| 15:21.03 | Aftermathh | Semlar: self:SetTemplate(true, ButtonSize, ButtonSize) |
| 15:21.23 | Aftermathh | Which is this |
| 15:21.24 | Aftermathh | https://hastebin.com/egezixacet.rb |
| 15:21.34 | VIad | hi Aftermathh |
| 15:22.51 | *** join/#wowuidev g0urra (~g0urra@unaffiliated/gourra) |
| 15:23.00 | Aftermathh | hi vlad |
| 15:54.40 | Semlar | Aftermathh: you have a function Bags:SlotUpdate on line 537 that is bailing out if the button isn't skinned |
| 15:57.26 | Aftermathh | What should i do to fix it? :) |
| 16:00.17 | Semlar | i didn't write this, so i don't know what it should be doing, but i'm assuming you don't want it returning out of the function if it's NOT skinned, since you're setting IsSkinned = true at the end of it |
| 16:00.52 | Semlar | this is only running if IsSkinned is already set |
| 16:01.36 | Aftermathh | It's the ButtonPanel which we don't wanna re-create/re-skin again |
| 16:03.14 | Semlar | alright so how do we change line 538 to fix this |
| 16:03.59 | Semlar | it would probably help if your indentation weren't screwy after this if statement |
| 16:08.12 | Aftermathh | Hmm, not sure i've tried various things, and like if you use: if not (button.isSkinned) then the coloring doesn't work for some reason |
| 16:09.26 | Semlar | this if statement is currently preventing the function from continuing because it's returning out of it if the button is not skinned, since this function is skinning the button, i'm assuming that's not what you want it to do |
| 16:10.53 | Aftermathh | So it should be like: (button and button.IsSkinned) |
| 16:10.58 | Aftermathh | return end |
| 16:11.43 | Semlar | probably |
| 16:11.59 | Aftermathh | It doens't work either :/ |
| 16:13.19 | Semlar | technically "if not button or button.IsSkinned", but that's assuming this is supposed to be skinning the button |
| 16:14.25 | Aftermathh | Nop still not :S |
| 16:30.09 | foxlit | if you have no idea what your code is doing, the recommended solution is cleansing fire: delete everything and start over. |
| 16:30.48 | Semlar | yeah, i'm not reading through a thousand lines of code to figure out why your thing isn't doing something |
| 16:31.04 | Semlar | or is doing something that it shouldn't be |
| 16:35.02 | Semlar | the function at the lines you specified probably isn't the problem since it has a check to prevent it from being re-ran on the same frame |
| 16:35.36 | Semlar | so you need to figure out what is happening |
| 16:47.19 | *** join/#wowuidev Andols (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 16:55.01 | *** join/#wowuidev Kinesia (~Kinesia@115-64-111-2.tpgi.com.au) |
| 17:04.25 | *** join/#wowuidev A-KO^^ (~sa@198.74.38.103) |
| 17:11.15 | *** join/#wowuidev Shockah (~Shockah@83.7.11.150) |
| 17:21.26 | Aftermathh | I fixed it |
| 17:29.03 | Semlar | good |
| 18:08.29 | *** join/#wowuidev A-KO^^ (~sa@198.74.38.103) |
| 18:13.11 | VIad | Semlar: know a place I can reliably kill myself to test on death dialog popups? staticpopups :d |
| 18:13.18 | VIad | without the 2 min limit thing |
| 18:13.51 | Semlar | fly up and fall to your death at a graveyard |
| 18:15.07 | VIad | xD |
| 18:15.09 | VIad | I guess |
| 18:15.18 | VIad | gonna rek my gear in bags :d but I guess it works |
| 18:15.45 | VIad | someone linked a WA for disabling release |
| 18:15.49 | VIad | and I found the code horrible |
| 18:15.54 | VIad | like based on someone elses code 10 times |
| 18:16.05 | VIad | so its just wonky imo and people love to link it around :( |
| 18:22.59 | *** join/#wowuidev stolenlegacy (~stolenleg@213-47-49-27.cable.dynamic.surfer.at) |
| 18:22.59 | *** join/#wowuidev stolenlegacy (~stolenleg@unaffiliated/stolenlegacy) |
| 18:27.31 | *** join/#wowuidev aprok (~Albrecht@x5ce55e71.dyn.telefonica.de) |
| 18:36.58 | *** join/#wowuidev gOurra (~g0urra@unaffiliated/gourra) |
| 19:08.48 | *** join/#wowuidev Ssateneth (ident@unaffiliated/ssateneth) |
| 19:14.00 | *** join/#wowuidev Andols (~Andols@62-20-145-33-no170.tbcn.telia.com) |
| 19:14.19 | Andols | VIad: Disable release, RepopMe=nil |
| 19:15.01 | Andols | or my favorite troll when i get access to a friends computer for a few secons AcceptResurrect=PortGraveyard |
| 19:15.29 | Andols | s/secons/seconds/ |
| 19:29.52 | *** join/#wowuidev Funkeh` (~Funkeh`@WoWUIDev/WoWAce/Ace3/BigWigs/funkeh) |
| 19:57.22 | *** join/#wowuidev karl_w_w (~karl_w_w@110-175-132-56.tpgi.com.au) |
| 20:04.59 | *** join/#wowuidev Lejving (~Lejving@78-68-169-135-no37.tbcn.telia.com) |
| 20:27.02 | *** join/#wowuidev A-KO^^ (~sa@198.74.38.103) |
| 20:39.20 | *** join/#wowuidev Seerah (~umsin@104-180-66-29.lightspeed.mmphtn.sbcglobal.net) |
| 20:39.20 | *** mode/#wowuidev [+o Seerah] by ChanServ |
| 21:14.06 | *** part/#wowuidev aprok (~Albrecht@x5ce55e71.dyn.telefonica.de) |
| 21:21.39 | Andols | http://us.battle.net/wow/en/character/malganis/L%C3%BCcien/advanced That trinket |
| 21:23.13 | *** join/#wowuidev gear4 (~notAperso@197.86.176.242) |
| 21:23.18 | gear4 | hey guys |
| 21:23.41 | gear4 | so quick question: can anyone tell me why my HPS is quite low (180-220 max) http://eu.battle.net/wow/en/character/hellfire/Goekoo/advanced |
| 21:23.44 | gear4 | as a paladin |
| 21:23.51 | gear4 | and I run oom very quick |
| 21:26.13 | Shockah | umm |
| 21:26.27 | Shockah | to begin with, wrong channel? |
| 21:26.40 | Shockah | and you have no logs on warcraftlogs |
| 21:26.43 | nevcairiel | yeah you should probably find your class discord |
| 21:27.05 | Shockah | so there's not much we can say |
| 21:28.10 | *** join/#wowuidev chrippa (~chrippa@livestreamer.io) |
| 21:28.17 | znf | gear4, totally the wrong channel |
| 21:28.38 | *** join/#wowuidev Semlar (~chatzilla@142-196-129-245.res.bhn.net) |
| 21:29.17 | znf | also, you don't have gems in all your gear |
| 21:29.33 | znf | you're wearing a blue piece, when there's upgradeable crafted gear |
| 21:29.51 | znf | no enchants |
| 21:30.55 | Stanzilla | (holy paladin wants crit) |
| 21:31.59 | Stanzilla | (you are wearing a dps trinket) |
| 21:32.42 | Stanzilla | get the darkmoon card and upgrade to max |
| 21:33.38 | gear4 | ok cool |
| 21:33.50 | gear4 | znf, can't afford either upgradable or gems or enchants |
| 21:33.55 | gear4 | what's there is what I could get |
| 21:34.05 | gear4 | Stanzilla, I know I need crit |
| 21:34.07 | gear4 | but tx |
| 22:08.11 | *** join/#wowuidev znf (~ibm86@toaster.linge-ma.ws) |
| 22:14.24 | *** join/#wowuidev Andols (~yaaic@62-20-145-33-no170.tbcn.telia.com) |
| 22:15.17 | Gnarfoz | another issue (without logs, it's almost impossible to say) might be too many healers |
| 22:18.39 | A-KO^^ | too many healers is USUALLY a big problem for most groups |
| 22:18.47 | A-KO^^ | I ran into that last night |
| 22:19.01 | Gnarfoz | there's just not enough to heal |
| 22:19.03 | A-KO^^ | My heals (as a druid, HOTs) were just devestated because we basically had 4 healers |
| 22:19.20 | A-KO^^ | and we were like 4-healing 15-man lol |
| 22:19.21 | Gnarfoz | (but if you run lean on healers, your healers better not suck :D) |
| 22:23.33 | gear4 | Gnarfoz, it was 4 healers 14 dps |
| 22:23.48 | Gnarfoz | yeah, apart from your other problems, that's probably too many. |
| 22:24.03 | Gnarfoz | or at least, too many to pull high HPS |
| 22:29.07 | nevcairiel | 4 on 14 is normal |
| 22:29.13 | nevcairiel | thats 20 people overall |
| 22:30.12 | Gnarfoz | oh, I misread |
| 22:30.28 | Gnarfoz | thought 4 on 14 total |
| 22:31.35 | Gnarfoz | "1 per group" (i.e. per 5) is right on par |
| 22:37.25 | gear4 | yea that's what I'm on |
| 22:37.41 | gear4 | still can't pull my hps up |
| 22:37.44 | *** join/#wowuidev Ressy (Ressy@WoWUIDev/WoWAce/ARL/Ressy) |
| 22:37.52 | gear4 | I mean if I use all my cooldowns at once then I can |
