| 00:37.54 | *** join/#stepcode kesha_ (~kesha@49.248.244.66) |
| 00:58.32 | *** join/#stepcode kesha_ (~kesha@49.248.244.66) |
| 01:05.49 | *** join/#stepcode kesha_ (~kesha@49.248.244.66) |
| 01:55.18 | *** join/#stepcode kesha_ (~kesha@49.248.244.66) |
| 02:14.47 | *** join/#stepcode kesha_ (~kesha@49.248.244.66) |
| 13:06.03 | *** join/#stepcode kesha (~kesha@49.249.9.55) |
| 13:13.33 | *** join/#stepcode kesha_ (~kesha@49.249.19.83) |
| 17:26.04 | *** join/#stepcode kesha_ (~kesha@49.249.200.67) |
| 18:52.32 | *** join/#stepcode kesha_ (~kesha@49.249.200.67) |
| 18:57.31 | *** join/#stepcode kesha_ (~kesha@49.249.200.67) |
| 19:51.47 | *** join/#stepcode mpictor (~mark@2601:d:b280:9:d63d:7eff:fe2d:2505) |
| 19:56.01 | kesha_ | Hi mpictor, just sent u a mail. Check inbox and guide me.. |
| 20:06.16 | kesha_ | Using the previous build/ again, make builds successfully. |
| 20:12.21 | mpictor | hi kesha |
| 20:12.56 | mpictor | could you push a branch to github? |
| 20:15.03 | mpictor | without seeing the code, the only thing I can think of is that some braces are no longer printed in the generated code |
| 20:17.47 | mpictor | kesha_: 150 is a good start! :) |
| 20:30.55 | kesha_ | Made a branch ks-issue21 on my system, then "git remote set-url origin https://github.com/stepcode/stepcode.git". Now how to push? "git push origin ?" |
| 20:31.36 | mpictor | that should work. I usually do 'git push origin mybranch:remotebranch' |
| 20:31.57 | mpictor | oh, I misread your first line |
| 20:32.27 | mpictor | 'git push origin' probably wouldn't work, but the one I suggested should |
| 20:33.53 | kesha_ | What shall I fill up mybranch and remotebranch ? |
| 20:34.26 | mpictor | ks-issue21 for mybranch, and remotebranch could be the same or something else |
| 20:35.01 | mpictor | the 'git remote set-url' command shouldn't be necessary if you are using the same computer as before |
| 20:35.36 | mpictor | if a different computer, you'll need your ssh key |
| 20:38.55 | kesha_ | crap, the command prompt is engaged since a long time after entering my github username and password. |
| 20:39.17 | mpictor | strange |
| 20:40.29 | kesha_ | can you walk me again through pushing it onto a new branch ? |
| 20:42.24 | mpictor | what error did you get? |
| 20:42.42 | kesha_ | no error ! |
| 20:42.58 | kesha_ | I killed the process |
| 20:44.40 | mpictor | 'git push origin ks-issue21:ks/issue21' ought to work |
| 20:44.56 | mpictor | oh! the url you used may not work with ssh |
| 20:45.15 | mpictor | try 'git remote set-url origin git@github.com:stepcode/stepcode.git' |
| 20:46.02 | mpictor | <PROTECTED> |
| 20:47.50 | mpictor | well, https://help.github.com/articles/which-remote-url-should-i-use makes it sound like the https url would work |
| 20:48.46 | mpictor | I didn't know you could have write access except with git@ |
| 20:57.34 | kesha_ | Its being pushed :) |
| 21:06.46 | mpictor | is about to get a thunderstorm... |
| 21:09.33 | kesha_ | in balcony and its raining heavily out... |
| 21:09.54 | kesha_ | btw, you can see that branch now. :) |
| 21:10.27 | mpictor | I don't see it at https://github.com/stepcode/stepcode/branches |
| 21:11.33 | kesha_ | https://github.com/stepcode/stepcode/tree/ks/issue21 |
| 21:11.52 | kesha_ | Can you see here ? - https://github.com/stepcode/stepcode/commits/ks/issue21 |
| 21:11.59 | mpictor | I can |
| 21:12.01 | mpictor | strange |
| 21:12.39 | mpictor | oh, it says they're still calculating info about this branch |
| 21:12.52 | mpictor | maybe that is why it doesn't show up in the list |
| 21:13.25 | kesha_ | oh, ya. Shortly it will be there |
| 21:32.53 | mpictor | did you download an archive of the code and then do 'git init'? it looks like most of the history is gone in your branch :/ |
| 21:33.03 | mpictor | no wonder it took so long to push the branch |
| 21:33.35 | mpictor | fortunately, it should be pretty easy to fix |
| 21:35.49 | kesha_ | I cloned the repo from github and did git init. |
| 21:36.20 | mpictor | oh you don't need to do git init after git clone |
| 21:36.31 | mpictor | I guess it wiped the history out |
| 21:36.49 | kesha_ | oh, I saw .. 1337 behind :/ |
| 21:37.00 | mpictor | create a backup of your repo |
| 21:37.14 | mpictor | create a new dir, and clone stepcode into that |
| 21:37.37 | mpictor | in the repo with the changes, delete the .git dir |
| 21:38.01 | mpictor | copy the .git dir from the freshly cloned repo into your old repo |
| 21:38.15 | mpictor | then create a new branch and add your changes |
| 21:38.45 | mpictor | ---- |
| 21:38.47 | mpictor | I found the cause of the error |
| 21:38.53 | kesha_ | what ? |
| 21:39.01 | kesha_ | Curious |
| 21:39.11 | mpictor | https://github.com/stepcode/stepcode/commit/2db903ad43130b03771adb31d306602f96d75b7d#L2L1716 |
| 21:39.24 | mpictor | I guess one of the warnings you fixed was 'unused variable first' |
| 21:39.49 | mpictor | you moved it from outside a loop to inside the loop, so it's always set to 1 |
| 21:40.12 | mpictor | the loop doesn't actually show up on that page |
| 21:40.44 | mpictor | the loop starts on line 1812, hidden in the LISTdo macro |
| 21:40.46 | mpictor | LISTdo( attr_list, a, Variable ) |
| 21:41.27 | mpictor | I don't know why it thought the variable wasn't used, but it is incorrect |
| 21:42.23 | mpictor | if we can't find a way to silence the warning, we'll have to leave it |
| 21:43.22 | kesha_ | previously also I had encountered with such instances where cppcheck claims variable to be not used, but they were actually used. |
| 21:43.42 | kesha_ | I might have been a little careless with this one :( |
| 21:43.53 | mpictor | heh |
| 21:44.07 | mpictor | those macros don't help to make the code easier to read! |
| 21:44.29 | mpictor | they reduce the number of lines, but that's about it |
| 21:45.36 | mpictor | if you haven't seen the definition of LISTdo, it's at https://github.com/stepcode/stepcode/blob/master/include/express/linklist.h#L98 |
| 21:45.42 | mpictor | bleh. |
| 21:47.46 | kesha_ | I reinserted "int first=1", but still the same error ! :/ |
| 21:50.19 | kesha_ | oh, no. It vanished off :) |
| 21:51.53 | mpictor | when you redo your commit after replacing .git, please break it up into smaller chunks |
| 21:52.12 | kesha_ | regarding that transferring of .git/ ,if I delete .git/ , wont it remove all commits also ? |
| 21:53.24 | mpictor | the changes will remain in the files, as long as you haven't checked out a different branch or used 'git reset <...> --hard' |
| 21:53.43 | mpictor | also, please make a backup just in case |
| 21:54.34 | kesha_ | ok. |
| 21:54.47 | kesha_ | How do I go about fixing- "C-style pointer casting" ? |
| 21:55.02 | mpictor | can you give an example |
| 21:55.04 | mpictor | ? |
| 21:55.50 | kesha_ | for example, src/fedex_plus/complexlist.cc:115 |
| 22:02.12 | mpictor | I guess use static_cast or reinterpret_cast http://en.cppreference.com/w/cpp/language/explicit_cast |
| 22:04.19 | mpictor | oops, that particular example should use dynamic_cast since EntList inherits from SimpleList |
| 22:05.06 | mpictor | that line would become nm = ( dynamic_cast<SimpleList *>(ent) )->name; |
| 22:07.33 | kesha_ | okay :) And last one, there cppcheck says many functions are not used. What shall I do to those functions ? |
| 22:07.47 | kesha_ | I dont think commenting out all of them a nice idea ! |
| 22:07.50 | mpictor | heh |
| 22:08.10 | mpictor | it depends where they are |
| 22:08.30 | mpictor | in fedex_plus, unused functions will probably remain unused |
| 22:08.41 | mpictor | so it's ok to comment them out |
| 22:09.31 | mpictor | in one of the libraries - express, exppp, cl* - they might be useful |
| 22:10.16 | kesha_ | heh ,, most of them are from those libraries only ! |
| 22:10.30 | mpictor | I'd leave them alone |
| 22:10.41 | kesha_ | http://paste.kde.org/777530/ |
| 22:11.33 | mpictor | don't bother fixing any warnings in src/clprobe-ui |
| 22:11.51 | mpictor | many of the others are definitely used by the generated code |
| 22:12.04 | kesha_ | Its just the remanant of prev ui :) |
| 22:12.12 | mpictor | yes |
| 22:12.38 | mpictor | I haven't deleted it because it could be useful as a reference on how to do something |
| 22:12.57 | mpictor | (and how not to do many other things) |
| 22:13.40 | kesha_ | so, let those all warnings keep screaming ? |
| 22:14.13 | mpictor | I tried to fix it... many horrible macros in the InterViews widget libraries, and I got many compiler errors that I couldn't figure out |
| 22:14.45 | mpictor | I guess so |
| 22:15.33 | mpictor | we can use a code coverage tool like gcov to get a better idea of what's actually used |
| 22:15.54 | mpictor | it takes a very long time to run, though |
| 22:16.11 | mpictor | http://stepcode.org/lcov/ |
| 22:17.26 | mpictor | oops, I misspoke |
| 22:17.42 | mpictor | gcov / lcov tells you what functions are called in a given run |
| 22:18.07 | mpictor | while a static tool like cppcheck warns you if it doesn't find function calls |
| 22:18.26 | mpictor | if *both* say a function is unused, it probably isn't used |
| 22:20.24 | kesha_ | http://stepcode.org/lcov just shows the stats of *how many* functions - where does it show *which* all? |
| 22:21.20 | mpictor | you have to click on a dir, then a file |
| 22:22.12 | mpictor | the numbers there are very low |
| 22:23.38 | mpictor | hmmm... maybe they are, maybe not... I don't remember if I ran any of the p21read tests |
| 22:24.10 | mpictor | I only provided the link as an example; we would need to re-run it because a lot has changed since then |
| 22:24.59 | kesha_ | http://stepcode.org/lcov/src/test/p21read/index.html ?? |
| 22:26.13 | mpictor | main() has the number 40 by it; I think that is the number of times the line was executed |
| 22:26.32 | mpictor | if all of the tests were done, I think that would be 150 or so |
| 22:27.35 | mpictor | there is a function summary for each file, but for c++ it shows the mangled names http://stepcode.org/lcov/src/test/p21read/p21read.cc.func.html |
| 22:30.33 | kesha_ | hmm..anyways, by tomorrow or max. day after that all the genuine warnings reported by cppcheck will be cleared off. :) |
| 22:30.55 | mpictor | good! |
| 22:31.26 | kesha_ | Then, what will we go for next ? |
| 22:31.52 | mpictor | if you need to find where something is printed in fedex_plus, there is a way to find it fairly easily - but you'll need a commit that isn't in master yet |
| 22:31.58 | mpictor | (one sec) |
| 22:33.27 | mpictor | 'git cherry-pick 0eb4f8ba547' , then 'cmake .. -DSC_TRACE_FPRINTF=ON' |
| 22:34.14 | mpictor | the generated code won't compile, but each line will have a comment listing a file and line in fedex_plus |
| 22:34.16 | kesha_ | did u code it now ? |
| 22:34.45 | mpictor | I did it a while back, but it got broken when I renamed some stuff from SCL* to SC* - I missed that one |
| 22:35.20 | mpictor | I would have told you earlier if I knew you would need to debug the generated code - sorry! |
| 22:36.59 | mpictor | after you work through the cppcheck warnings, what about looking at the gcc warnings for the generated code? |
| 22:37.34 | mpictor | those will be more difficult to trace since they will mostly originate in fedex_plus |
| 22:39.51 | kesha_ | oh, fear and they are large in numbers too ! |
| 22:40.41 | mpictor | fix one and chances are you'll fix a hundred other identical warnings :) |
| 22:41.04 | mpictor | *almost-identical |
| 22:44.03 | kesha_ | How about going to some other issue. I think compiler warnings can be handled when I am sort of little bit busy. I have plenty time now, so I can take up a fresh new thing to work upon and have enough time to read and understand all related code. |
| 22:44.36 | kesha_ | This is just what I feel, you can even say no! :D |
| 22:45.14 | mpictor | what about #200 then? https://github.com/stepcode/stepcode/issues/200 |
| 22:45.47 | mpictor | or for a change of pace, #235 |
| 22:52.47 | mpictor | once you think you're done with #21, enable testing and run 'make test' to run all of the tests |
| 22:53.44 | mpictor | brlcad, starseeker: any point in keeping the 203wseds schema around? all of the files we have for it don't match it and show up on cdash as failed tests |
| 22:53.57 | kesha_ | #235 sounds interesting. I haven't done such a thing, so any pre-requistes knowledge or links you could guide me with to get a headstart ? |
| 22:54.24 | kesha_ | Sure, I will run 'make test' |
| 22:56.43 | mpictor | I'd look at the cmake documentation - http://www.cmake.org/cmake/help/v2.8.8/cmake.html#command:install |
| 22:57.16 | mpictor | their wiki has some useful stuff on it, but some of it is outdated |
| 23:02.00 | kesha_ | cool. Get back to you soon. My bed is calling me ;) |
| 23:02.09 | mpictor | hah I bet |