00:35.04 | *** join/#maemo-ssu RedM (~redw@89-76-164-87.dynamic.chello.pl) |
00:35.21 | *** join/#maemo-ssu DrCode (~DrCode@5.28.134.3) |
00:36.44 | *** join/#maemo-ssu ruskie (ruskie@sourcemage/mage/ruskie) |
03:04.29 | *** join/#maemo-ssu LauRoman (~LauRoman@5-14-50-151.residential.rdsnet.ro) |
03:08.54 | *** join/#maemo-ssu hashcore (~hashcore@unaffiliated/hashcore) |
06:32.10 | *** join/#maemo-ssu Sicelo009N (~sicelo@unaffiliated/sicelo) |
06:54.15 | *** join/#maemo-ssu amiconn (~amiconn@rockbox/developer/amiconn) |
07:00.12 | *** join/#maemo-ssu Sicelo009N (~sicelo@unaffiliated/sicelo) |
07:55.46 | *** join/#maemo-ssu futpib (~futpib@176.214.26.53) |
09:25.18 | *** join/#maemo-ssu hashcore (~hashcore@unaffiliated/hashcore) |
10:08.53 | *** join/#maemo-ssu Pali (~pali@Maemo/community/contributor/Pali) |
10:28.57 | *** join/#maemo-ssu jonwil (~jonwil@27-33-80-219.tpgi.com.au) |
14:16.16 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
15:30.14 | *** join/#maemo-ssu sparetire (~sparetire@unaffiliated/sparetire) |
15:33.57 | *** join/#maemo-ssu kerio (kerio@bad.memes.vs.dank.ninja) |
15:35.13 | *** join/#maemo-ssu NishanthMenon (nmenon@nat/ti/x-xojeaxggqwrscysb) |
15:35.13 | *** join/#maemo-ssu NishanthMenon (nmenon@unaffiliated/nishanthmenon) |
16:01.27 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
16:12.24 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
16:18.46 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
16:37.52 | *** join/#maemo-ssu ravelo (~ravelo@77.119.131.122.wireless.dyn.drei.com) |
16:38.52 | *** join/#maemo-ssu liteIRC_ (~ravelo@77.119.131.122.wireless.dyn.drei.com) |
16:47.08 | *** join/#maemo-ssu ravelo (~ravelo@77.119.131.122.wireless.dyn.drei.com) |
16:51.43 | *** join/#maemo-ssu liteIRC_ (~ravelo@194-118-214-4.adsl.highway.telekom.at) |
16:57.17 | *** join/#maemo-ssu liteIRC_ (~ravelo@178.115.130.46.wireless.dyn.drei.com) |
17:10.03 | *** join/#maemo-ssu liteIRC_ (~ravelo@213-240-73-106.adsl.highway.telekom.at) |
17:12.20 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
17:14.53 | *** join/#maemo-ssu pagurus (~user@pD950C636.dip0.t-ipconnect.de) |
17:18.53 | *** join/#maemo-ssu Sicelo009N (~sicelo@196.15.211.141) |
17:18.54 | *** join/#maemo-ssu Sicelo009N (~sicelo@unaffiliated/sicelo) |
19:24.43 | *** join/#maemo-ssu kerio (kerio@bad.memes.vs.dank.ninja) |
19:30.25 | *** join/#maemo-ssu M4rtinK (~M4rtinK@ip-78-102-146-111.net.upcbroadband.cz) |
20:07.39 | *** join/#maemo-ssu hashcore (~hashcore@unaffiliated/hashcore) |
20:08.02 | *** join/#maemo-ssu luf_ (~luf@ip-89-103-184-51.net.upcbroadband.cz) |
20:33.24 | *** join/#maemo-ssu LauRoman|Phone (~yaaic@5-14-50-151.residential.rdsnet.ro) |
21:05.28 | luf_ | Hi, I just created new pull request against curl. |
21:05.52 | luf_ | It contains several CVEs and few bug fixes taken from wheezy. |
21:10.59 | *** join/#maemo-ssu jurov (~jurov@impr-2-pt.tunnel.tserv5.lon1.ipv6.he.net) |
21:13.13 | *** join/#maemo-ssu kerio (kerio@bad.memes.vs.dank.ninja) |
21:23.08 | luf_ | Can someone review it? It compiled without problem for me ... |
21:28.59 | luf_ | Is anybody willing to test patched curl? |
22:02.57 | Pali | freemangordon, see luf messages ^^^ |
22:03.10 | freemangordon | luf_: hi! |
22:04.08 | freemangordon | luf_: re your EDS patch - I tried to review it, but failed :). I simply have no idea what it fixes |
22:08.09 | luf_ | freemangordon: it fixes 1 mem leak + 2 possible |
22:09.28 | luf_ | nsSBCSGroupProber.cpp - it's called and it allocates new string |
22:09.48 | freemangordon | luf_: hmm, wait, there are new commits to EDS, I was thinking it is about "Remove lines with empty value from VCARD string (except required fields)" |
22:09.49 | luf_ | it frees the memory only if the string len > 0. |
22:10.09 | luf_ | https://github.com/community-ssu/evolution-data-server/pull/1 |
22:10.33 | freemangordon | oh, sorry, my bad, I was under the impression you have commit rights |
22:10.34 | luf_ | I already commited it as I saw no response for quite long time :) |
22:11.15 | luf_ | I have commit rights from pali but I like the idea someone take a look if I don't make some stupid mistake. |
22:11.24 | luf_ | :) |
22:11.25 | *** join/#maemo-ssu jonwil (~jonwil@27-33-80-219.tpgi.com.au) |
22:12.07 | freemangordon | luf_: yeah, sure, it is just that I though it is already commited and saw "Remove lines with empty value from VCARD string (except required fields)" |
22:13.34 | freemangordon | luf_: what is PRUint32 type? int &? |
22:14.59 | luf_ | freemangordon: where do you see it? |
22:15.22 | freemangordon | https://github.com/community-ssu/evolution-data-server/blob/9ce54231c5a94dad92561c4b7a3c2ef2a24a9eb5/libuchardet/src/nsSBCSGroupProber.cpp#L152 |
22:16.41 | luf_ | freemangordon: it's out parameter for FilterWithoutEnglishLettersFilterWithoutEnglishLetters |
22:17.06 | freemangordon | yes, that is why I am asking |
22:17.46 | freemangordon | anyway, does FilterWithoutEnglishLetters calls new char[0] for zero newLen1? |
22:17.59 | freemangordon | I guess I should clone the code and look deeper |
22:19.49 | freemangordon | hmm, seems like yes |
22:20.07 | luf_ | Hmmm it seems like strange problem I overlooked. |
22:20.18 | luf_ | PRBool nsCharSetProber::FilterWithoutEnglishLetters(const char* aBuf, PRUint32 aLen, char** newBuf, PRUint32& newLen) |
22:21.21 | luf_ | But this part I haven't touched. |
22:23.02 | luf_ | Ot it's some weird C++ syntax? |
22:23.59 | luf_ | Ok, PRUint32& is reference (so it can change value inside the func) |
22:24.05 | luf_ | So it's not a problem |
22:25.02 | luf_ | freemangordon: you scared me :D :D |
22:29.03 | *** join/#maemo-ssu xes (~xes@unaffiliated/xes) |
22:32.54 | freemangordon | luf_: sorry, didn't mean to do it :) |
22:34.33 | freemangordon | however, those 2 commits look fine on first look |
22:35.07 | freemangordon | luf_: tomorrow I'll try to find time to build EDS and curl and push it in cssu-devel |
22:36.06 | freemangordon | luf_: but don;t expect me to do a peer review on upstream fixes :) |
22:36.14 | freemangordon | (CVEs that is) |
22:37.53 | luf_ | Don't put EDS into cssu-devel. |
22:38.21 | luf_ | freemangordon: I have few changes prepared but I lend my HF unit ... |
22:39.45 | luf_ | freemangordon: I'll commit curl if you're ok with it. I just took patches from wheezy. |
22:41.26 | useretail | hey guys, i noticed that calendar app doesn't show birthdays in day's details when month-view is selected |
22:42.10 | useretail | only when week selected you can see the actual birthday |
22:42.23 | freemangordon | useretail: how's that related to cssu? |
22:42.39 | freemangordon | luf_: yes, commit those curl patches |
22:42.42 | useretail | no idea, i;m just reporting |
22:42.48 | freemangordon | luf_: ok, will wait for EDS |
22:42.54 | useretail | *i'm |
22:44.24 | useretail | freemangordon: ok, where i have to report? |
22:45.37 | luf_ | freemangordon: I will commit it and I'll upload it to cssu-devel in few days. Thanks! |
22:45.48 | *** join/#maemo-ssu xes_ (~xes@unaffiliated/xes) |
22:46.53 | useretail | actually i have CSSU 21.2011.38-1Tmaemo11+thumb0 testing |
22:55.19 | luf_ | useretail: calendar frontend is not part of cssu ... |
22:56.45 | luf_ | useretail: maybe I'm wrong but I expect it's closed source from Nokia :( |
23:00.59 | luf_ | useretail: https://wiki.maemo.org/Fremantle_closed_packages |
23:01.16 | jonwil | yeah its closed source :( |
23:21.03 | luf_ | freemangordon: https://github.com/community-ssu/libpng/pull/1 |
23:21.46 | luf_ | freemangordon: it seems to me that patches doesn't conflict with your changes and neon patch. |
23:23.09 | luf_ | freemangordon: Do I remember correctly that microb should be recompiled with patched libpng? |
23:25.19 | luf_ | I accepted curl pull request with wheezy patches. |
23:25.50 | luf_ | I'm going to test curl + libpng on my day to day N900 (not only dev) |