| 10:24.17 | *** join/#maemo-ssu infobot (ibot@69-58-76-73.ut.vivintwireless.net) |
| 10:24.17 | *** topic/#maemo-ssu is Maemo Community Seamless Software Update "CSSU" channel, http://wiki.maemo.org/Community_SSU | Known bugs: http://j.mp/communityssu-bugs | Channel logs: http://mg.pov.lt/maemo-ssu-irclog/ | Sources: https://github.com/community-ssu | Latest version: Testing(2015-04-11): 21.2011.38-1Tmaemo11; Stable(2014-09-03): 21.2011.38-1Smaemo7 |
| 10:24.17 | *** mode/#maemo-ssu [+v infobot] by ChanServ |
| 10:33.49 | *** join/#maemo-ssu futpib (~futpib@176.104.194.78) |
| 11:18.30 | *** join/#maemo-ssu arcean (~arcean@nat1-3.finemedia.pl) |
| 12:31.14 | *** join/#maemo-ssu infobot (ibot@69-58-76-73.ut.vivintwireless.net) |
| 12:31.14 | *** topic/#maemo-ssu is Maemo Community Seamless Software Update "CSSU" channel, http://wiki.maemo.org/Community_SSU | Known bugs: http://j.mp/communityssu-bugs | Channel logs: http://mg.pov.lt/maemo-ssu-irclog/ | Sources: https://github.com/community-ssu | Latest version: Testing(2015-04-11): 21.2011.38-1Tmaemo11; Stable(2014-09-03): 21.2011.38-1Smaemo7 |
| 12:31.14 | *** mode/#maemo-ssu [+v infobot] by ChanServ |
| 12:52.38 | *** join/#maemo-ssu jon_y (~enforcer@2001:e68:4074:444c:e01f:8e6d:cdca:d0e5) |
| 12:57.53 | *** join/#maemo-ssu xes (~xes@unaffiliated/xes) |
| 13:19.32 | *** join/#maemo-ssu sparetire_ (~sparetire@unaffiliated/sparetire) |
| 14:43.32 | *** join/#maemo-ssu sailus (~sailus@nblzone-211-213.nblnetworks.fi) |
| 18:21.02 | freemangordon | Pali: do we have a git tree of PR1.3 modest? |
| 18:21.14 | Pali | freemangordon: yes |
| 18:21.19 | Pali | it should be on github |
| 18:21.19 | freemangordon | where? |
| 18:21.26 | freemangordon | a branch? |
| 18:21.35 | Pali | PR1.3 |
| 18:21.53 | freemangordon | Nokia PR 1.3 |
| 18:22.13 | freemangordon | the modest in there, modest-3.4.8+0m5 |
| 18:22.28 | Pali | git://github.com/community-ssu/modest.git PR1.3 |
| 18:23.06 | freemangordon | thanks |
| 18:25.39 | freemangordon | Pali: I think we're hitting https://github.com/community-ssu/modest/commit/bbcd5ff40725eba5d4435163497ed44e8a5e5920 in cssu |
| 18:26.15 | Pali | I wrote more time here on IRC that we are missing lot of commits from PR1.3 branch in master |
| 18:26.37 | Pali | so it is really possible that you hit another bug "fixed in PR1.3" |
| 18:26.38 | freemangordon | yeah, I know |
| 18:26.44 | freemangordon | that one http://talk.maemo.org/showthread.php?p=1483681 |
| 18:26.52 | freemangordon | will try to fix it |
| 18:27.29 | Pali | I think I posted some pastebin link here with all missing commits |
| 18:27.48 | Pali | some semi-automatic shell script which use some git magic |
| 18:40.53 | freemangordon | hmm, that commit is already merged(albeit with a different sha id) |
| 18:41.01 | freemangordon | it must be something else then |
| 19:52.01 | *** join/#maemo-ssu LauRoman (~LauRoman@5-14-15-167.residential.rdsnet.ro) |
| 20:30.54 | freemangordon | Pali: ping |
| 20:46.35 | Pali | pong |
| 21:03.10 | freemangordon | Pali: I think I found what the problem in modest is, but I am not sure how to solve it. |
| 21:03.24 | freemangordon | I lack mime-fu :) |
| 21:04.42 | freemangordon | Pali: https://github.com/community-ssu/modest/blob/master/src/widgets/modest-attachments-view.c#L168 |
| 21:05.14 | freemangordon | for some reason modest checks for "multipart/alternative" |
| 21:05.46 | freemangordon | and if so, the code on https://github.com/community-ssu/modest/blob/master/src/widgets/modest-attachments-view.c#L223 is not executed |
| 21:06.13 | freemangordon | if I set is_alternate to be false, the missing attachments appear |
| 21:06.34 | freemangordon | what I can't get is why this check is needed |
| 21:08.17 | freemangordon | that code was introduced by commit 354a038d69d6b9ac42b49e6c6d3751f7978c4adb ([PATCH] Show digest attachments (and other non body text parts) in attachments view) |
| 21:09.52 | freemangordon | https://garage.maemo.org/plugins/ggit/browse.php/?p=modest;a=patch;h=354a038d69d6b9ac42b49e6c6d3751f7978c4adb |
| 21:20.37 | Pali | freemangordon: MIME email contains (mathematical) tree |
| 21:20.45 | Pali | each node contains email data |
| 21:21.33 | Pali | and if node is marked as "multipart/alternative" then it means that all subnodes are equivalent, just represent same data in different encodings or formats |
| 21:21.49 | Pali | e.g. text/plain and text/html |
| 21:22.20 | Pali | if node is marked as "multipart/mixed" or other multipart/ then its subnodes contains data |
| 21:22.27 | freemangordon | Pali: but that is not the case(in that mail), as text part contains no attachments, while html part contains |
| 21:23.10 | Pali | and if missing attachment is only under some subnode of multipart/alternative node, that it could be hidden |
| 21:23.31 | freemangordon | see http://pastebin.com/wUgr8tkB |
| 21:24.17 | freemangordon | thunderbird shows the attachments, modest does not |
| 21:24.20 | Pali | freemangordon: I will run my MIME tree parser on that email |
| 21:24.34 | freemangordon | wait, it is the header only |
| 21:24.51 | freemangordon | i'll forward it to you |
| 21:24.58 | Pali | nope, this contains also body |
| 21:25.11 | Pali | body of email start after blank line |
| 21:25.32 | Pali | but please send me it as plain text attachment |
| 21:25.42 | Pali | so I can inspect original plain text file |
| 21:25.49 | freemangordon | yep, sure |
| 21:26.10 | Pali | I think I know where is problem |
| 21:26.23 | Pali | but rather I would recheck it on original email |
| 21:26.26 | Pali | first |
| 21:27.03 | freemangordon | oh, so modest prefers the "text" part and ignores the "html" part? |
| 21:28.46 | freemangordon | Pali: mail sent |
| 21:28.51 | Pali | got it |
| 21:32.36 | Pali | freemangordon: ok, it is as I expected |
| 21:33.11 | freemangordon | hmm? |
| 21:33.12 | Pali | MIME email is tree and data (text, attachments, ..) are stored only in leafs |
| 21:33.29 | freemangordon | so? |
| 21:33.38 | Pali | root node is marked as alternative, which means that root subnodes are equivalent |
| 21:33.44 | freemangordon | sure |
| 21:33.51 | Pali | and that pdf attachment is only in one leaf |
| 21:33.57 | freemangordon | yes |
| 21:34.14 | Pali | and thats all, if you interpret that email in other way, then you miss attachment |
| 21:34.34 | freemangordon | but, shouldn't we show the attachments no matter in which node are they? |
| 21:34.37 | Pali | correct view of that email is also to hide attachment |
| 21:34.46 | Pali | freemangordon, no |
| 21:34.51 | freemangordon | hmm |
| 21:35.28 | freemangordon | well, that pdf is marked as inline as well, so what you say makes sense |
| 21:36.02 | freemangordon | Pali: so "freemangordon: oh, so modest prefers the "text" part and ignores the "html" part?" is what happens? |
| 21:36.03 | Pali | if some node is marked as multipart/alternative it does not matter which subnode you choose for rendering/viewing |
| 21:36.19 | Pali | freemangordon: I think that modest prefer html |
| 21:36.25 | Pali | but maybe it is not truth |
| 21:37.02 | Pali | freemangordon: it does not matter if pdf is marked as inline or as attachment |
| 21:37.06 | freemangordon | by the look of it, it prefers the text part |
| 21:37.06 | Pali | in both cases it is same |
| 21:37.25 | freemangordon | yeah, got that |
| 21:37.36 | Pali | I know that lot of multipart/alternative emails with html and text parts, modest shown me html version |
| 21:37.50 | freemangordon | maybe it depends which one comes first |
| 21:37.54 | Pali | but important note is also that in email parts are ordered |
| 21:38.19 | Pali | and I think that RFC say something that first is more preferred as second and etc... |
| 21:38.27 | Pali | no idea if some client respect this order |
| 21:38.41 | Pali | and also client is free to choose format which support |
| 21:38.49 | freemangordon | the first node is preferred over the second? |
| 21:39.22 | Pali | I think RFC say something like that in case that client does not have some other preferences |
| 21:39.31 | freemangordon | hmm, ok |
| 21:39.47 | Pali | I think that thunderbird prefer html |
| 21:39.53 | Pali | and then plain text |
| 21:39.59 | Pali | my KMail prefer plain text |
| 21:40.06 | freemangordon | it seems thunderbird shows both :) |
| 21:41.19 | freemangordon | as I see both "Hallo someone ,some text anotherone " and "anotherone" in bold |
| 21:41.51 | freemangordon | which doesn;t make sense either |
| 21:42.10 | freemangordon | Pali: do you see the attachments in your KMail? |
| 21:42.27 | Pali | I see Einladung.pdf |
| 21:42.44 | Pali | and image002.png |
| 21:42.53 | *** join/#maemo-ssu LinuxCode (~LinuxCode@ipservice-092-209-088-205.092.209.pools.vodafone-ip.de) |
| 21:43.03 | freemangordon | well, then there is still a problem in modest it seems |
| 21:43.12 | freemangordon | as in modest there are no attachments |
| 21:43.22 | Pali | freemangordon: this is how my MIME tree parser see that email: http://pastebin.com/ra0i1Kf0 |
| 21:43.53 | Pali | and my MIME viewver does not see PDF file |
| 21:44.12 | freemangordon | assuming KMail prefers the text node, I see no way for it to show 2 attachments |
| 21:44.54 | *** join/#maemo-ssu LinuxCode (~LinuxCode@ipservice-092-209-088-205.092.209.pools.vodafone-ip.de) |
| 21:45.15 | Pali | kmail has heurstic |
| 21:45.38 | Pali | and show this PDF because it does not see it in text subpart |
| 21:45.59 | Pali | but according to RFCs is correct way also to ignore that PDF part |
| 21:46.12 | Pali | my MIME viewer did it too |
| 21:46.22 | freemangordon | well then , "but, shouldn't we show the attachments no matter in which node are they?" :) |
| 21:46.33 | Pali | apparently not |
| 21:46.40 | freemangordon | seems KMail does it |
| 21:46.50 | freemangordon | as does Thunderbird |
| 21:47.09 | *** join/#maemo-ssu LinuxCode_away (~LinuxCode@ipservice-092-209-088-205.092.209.pools.vodafone-ip.de) |
| 21:47.10 | freemangordon | I won;t argue if it is RFC violation or not |
| 21:47.14 | Pali | it has some heurstic which could work sometimes, but they can damage (=show wrongly) correctly formatted emails |
| 21:47.54 | Pali | basically there is no difference between attachment or text part |
| 21:48.04 | Pali | I mean PDF or textfile |
| 21:48.10 | freemangordon | Pali: yes, I understand |
| 21:48.39 | Pali | you are free to compose email which is multipart/alternative and has two subnodes: |
| 21:48.48 | Pali | 1) is final plain/text |
| 21:49.00 | freemangordon | Pali: http://pastebin.com/xTMCdntw - that one makes modest show the attachments |
| 21:49.10 | freemangordon | just FYI |
| 21:49.15 | Pali | 2) is multipart/mixed (which means that has subnodes) and contains 3 additional html nodes |
| 21:49.47 | freemangordon | and I guess the client is free to choose which one to show |
| 21:49.53 | Pali | and if you run html2text on every 3 html nodes, join them together and put into 1) final plain/text |
| 21:50.05 | Pali | that you get normal email message |
| 21:50.33 | Pali | but which contains 4 nodes... 1 vs 1+1+1 |
| 21:50.55 | Pali | and you cannot exchange them, you must show either first or another 3 |
| 21:51.01 | freemangordon | I understand that. |
| 21:51.11 | Pali | and same it is with PDF files |
| 21:51.31 | Pali | that email which you sent me is just example of wrongly generated MIME email |
| 21:52.16 | Pali | and yes, client is free which alternative part will show |
| 21:52.29 | Pali | generaly it chose that one which can render better :-) |
| 21:53.03 | Pali | e.g. terminal text email clients (like mutt) prefer plain/text parts, because it can show just monospaced text :-) |
| 21:53.39 | freemangordon | I guess modest chooses whichever comes first |
| 21:53.47 | Pali | probably |
| 21:54.33 | freemangordon | Pali: what about showing the alternative part as an attachment? |
| 21:54.50 | freemangordon | as email attachment that is |
| 21:55.02 | Pali | if this bug is assigned to me, I would close it "as not a bug" |
| 21:55.13 | freemangordon | no, it is not assignet to you |
| 21:55.17 | freemangordon | *assigned |
| 21:55.19 | Pali | showing all other alternative parts as attachment is wrong idea |
| 21:55.38 | Pali | now maybe every email contains two alternative parts: text and html |
| 21:55.44 | freemangordon | yeah |
| 21:55.53 | Pali | so basically it show lot of useless attachments... |
| 21:56.02 | freemangordon | so, the same mail formatted correctly, should be: |
| 21:56.03 | Pali | better option would be to switch between alternatives |
| 21:56.13 | Pali | button for switching |
| 21:56.24 | freemangordon | hmm |
| 21:56.25 | Pali | kmail as it: switch between text and html |
| 21:56.38 | freemangordon | I am not sure I can implement stuff like that in modest |
| 21:57.29 | Pali | I know it is hard, but probably only one acceptable solution... as adding heuristic in any way could damage correct emails |
| 21:57.39 | freemangordon | yeah |
| 21:57.46 | Pali | and attachment button for alternative parts just show lot of useless attachments |
| 22:00.28 | freemangordon | ok, I'll post a link to our discussion on thet TMO thread |
| 22:00.37 | freemangordon | WONTFIX :) |
| 22:04.25 | Pali | yes, wontfix is also from my side... it is hard work and just for one incorrectly generated email |