| 01:09.30 | *** join/#bzflag infobot (ibot@208.53.50.136) |
| 01:09.30 | *** topic/#bzflag is https://BZFlag.org || http://ohloh.net/p/bzflag || https://bzflag.org/help || Channel Logs: http://infobot.rikers.org/%23bzflag/ || 2.4.16 released! https://forums.bzflag.org/viewtopic.php?f=62&t=20026 |
| 01:09.30 | *** mode/#bzflag [+v infobot] by ChanServ |
| 12:23.42 | *** join/#bzflag I_Died_Once (~I_Died_On@unaffiliated/idiedonce/x-1828535) |
| 13:40.49 | *** join/#bzflag The_Noah (~The_Noah@47.185.225.32) |
| 14:21.37 | *** join/#bzflag Agatha (180a9d90@gateway/web/freenode/ip.24.10.157.144) |
| 14:27.11 | Agatha | I've written a small plugin, but at load time am getting "<plugin>.so found but does not contain bz_GetPlugin method, error bzfs: undefined symbol: bz_GetPlugin". |
| 14:27.13 | Agatha | I followed allejo's excellent tutorial, read the BZFS_API_2.4_Upgrade wiki page, which suggests to use the `BZ_PLUGIN(<classname>)` macro (which I am doing), and compared to some of the other standard plugins (some of them seem to have the same problem, but couldn't find any significant code differences to the ones that didn't). In-particular, they use the `BZ_PLUGIN` macro, and don't write `bz_GetPlugin` explicitly. |
| 14:27.20 | Agatha | Hoping someone has encountered this before and can give me a pointer. |
| 15:18.06 | allejo | how are you building the plugin? |
| 15:37.46 | Agatha | autogen + configure. I think it's the standard way, although I also have the exact commands handy if you want to check. |
| 15:43.08 | Agatha | eh, typing them out would have been actually shorter. In "bzflag/", run "./autogen.sh; ./configure; make; sudo make install". |
| 15:44.16 | Agatha | Besides this, I added my plugin to "bzflag/plugins/Makefile.am" (~line 31) and "bzflag/configure.ac" (~1092), following the pattern. |
| 15:45.31 | allejo | the new way of building plugins, https://forums.bzflag.org/viewtopic.php?f=79&t=19104 |
| 15:45.45 | allejo | well, at least telling the build system about them |
| 16:00.14 | blast007 | generally that error means it can't find the plugin file |
| 16:03.01 | Agatha | allejo: I changed the configure line to `./configure --enable-custom-plugins=[my plugin's name]`, which seems to be the only difference, and did a fresh build, but this doesn't seem to affect the issue. |
| 16:04.19 | Agatha | blast: I think that is a different error; in-particular, notice that the error starts with "<plugin>.so found". |
| 16:10.53 | allejo | what's your code look like? |
| 16:11.08 | allejo | and did you use newplug.sh? |
| 16:17.00 | blast007 | are you doing a 'make install' or are you just running bzfs from the src/bzfs/ directory? |
| 16:30.56 | Agatha | allejo: I've pushed the code here: https://github.com/agatha2/SpawnkillRevenge |
| 16:31.44 | Agatha | I didn't use newplug.sh; Wiki says this only applies to versions < 2.4.3 (and I'm compiling from current master). |
| 16:32.42 | Agatha | I tried builds both with and without editing the files and with and without the `--enable-custom-plugins=...` option. |
| 16:32.44 | blast007 | src/bzfs/bzfs -loadplugin SpawnkillRevenge/.libs/SpawnkillRevenge.so |
| 16:34.12 | blast007 | wait, I'm way off there |
| 16:34.34 | blast007 | src/bzfs/bzfs -loadplugin plugins/SpawnkillRevenge/.libs/SpawnkillRevenge.so |
| 16:35.59 | Agatha | blast: yes; I am using `make install`. I assume those commands are instead for local usage? Current invocation is `-loadplugin /usr/lib/bzflag-server/SpawnkillRevenge.so`. |
| 16:36.30 | blast007 | if you're using make install, then just do 'bzfs -loadplugin SpawnkillRevenge' |
| 16:36.55 | blast007 | (but you could also try the one I provided) |
| 16:40.25 | Agatha | Hmmm, `-loadplugin SpawnkillRevenge` tentatively seems to be working! Though I'm confused why this should be the case. |
| 17:12.20 | blast007 | does /usr/lib/bzflag-server/SpawnkillRevenge.so actually exist? |
| 17:13.00 | blast007 | it should actually go into /usr/local/bzflag/... if you use make install |
| 17:18.27 | Agatha | It appears it's in neither directory. It's in "/usr/local/lib/bzflag/". Why was BZFS telling me it found my plugin if it actually didn't? :/ |
| 17:23.51 | blast007 | faulty logic :) |
| 17:24.02 | blast007 | should look into that |
| 17:24.05 | Juesto | and in /usr/lib/bzflag ? |
| 17:24.17 | Juesto | and in /usr/games/bzflag ? |
| 17:24.28 | Juesto | hmm, it must be something with the config too... |
| 17:24.56 | Juesto | nvm |
| 17:25.02 | blast007 | Juesto: those would be directories used by the package manager's version of the game, not a 'make install' version of the game (unless you specifically tell configure to use those paths) |
| 17:25.23 | blast007 | the default for configure is /usr/local |
| 17:26.34 | Juesto | right... |
| 17:26.54 | Juesto | still, i guess it expects the plugin to be there when it didnt compile at all or...? |
| 17:28.05 | blast007 | I'm having trouble parsing that sentence |
| 17:29.18 | Juesto | there's the possibility that perhaps bzfs is compiled with such plugin support but the actual plugin isnt included on the compile task |
| 17:30.11 | blast007 | when you build with the autotools way (via ./autogen.sh ; ./configure ; make), it embeds an 'INSTALL_LIB_DIR' into the build that gets built into the binaries, and our plugin loading code looks there |
| 17:32.12 | blast007 | sure, if the plugin wasn't compiled that would make it hard to load it :) |
| 17:38.55 | *** join/#bzflag tupone (~alfredo@gentoo/developer/tupone) |
| 17:43.18 | tupone | motd <- 2.4.18 released! |
| 17:44.34 | blast007 | yes, the MOTD says that |
| 17:44.47 | blast007 | I did forget to update the /title here, though |
| 17:44.56 | tupone | ahh ok, title |
| 17:45.02 | tupone | topic |
| 17:45.07 | *** mode/#bzflag [+o blast007] by ChanServ |
| 17:46.26 | tupone | any other change except windows ? do we need to upgrade linux distro ? |
| 17:46.35 | *** topic/#bzflag by blast007 -> https://BZFlag.org || http://ohloh.net/p/bzflag || https://bzflag.org/help || Channel Logs: http://infobot.rikers.org/%23bzflag/ || 2.4.18 released! https://forums.bzflag.org/viewtopic.php?f=62&t=20030 |
| 17:46.39 | *** mode/#bzflag [-o blast007] by blast007 |
| 17:47.11 | tupone | I will for gentoo |
| 17:47.13 | blast007 | there was only one code change, and it was just changing the order of the window creation and audio initiziation so that Windows worked again |
| 17:47.49 | tupone | yes, my fault ... but I could not check it |
| 17:48.21 | blast007 | nah, that's *my* fault for not testing with speakers/headphones attached :) |
| 17:59.39 | Agatha | blast007: I think I figured out the problem. In "bzflag/src/bzfs/bzfsPlugins.cxx", in function `findPlugin(...)`, if the plugin library cannot be found, it returns the empty string. |
| 17:59.42 | Agatha | When you pass this to `dlopen(...)` on line 297, it interprets it as the calling module, not a library path, therefore returning a non-NULL pointer (and invalidating the logic following). |
| 18:29.13 | Agatha | So it looks like my plugin works as-designed (it's simple enough it worked first time). |
| 18:29.39 | Agatha | You can see it running currently on my testing server laserlady.freemyip.com:5154 |
| 18:30.40 | Agatha | However, I'd like to report that a lot of the standard plugins seem to segfault the server. In particular, chathistory, killall, logDetail, and playHistoryTracker at least do this. I have stack traces if anyone is interested. |
| 19:34.54 | *** join/#bzflag [Gort] (~gort@unaffiliated/gort/x-9231432) |
| 20:04.28 | allejo | if they're segfaulting, i want to say you're doing something wrong lol |
| 20:05.01 | allejo | or are running on some weird OS |
| 21:23.03 | Agatha | example stack trace: |
| 21:23.05 | Agatha | #0 bz_ApiString::c_str (this=0x52a620) at bzfsAPI.cxx:323 #1 0x76faf154 in ChatEvents::Event(bz_EventData*) () from /usr/lib/bzflag-server/chathistory.so #2 0x000befc6 in WorldEventManager::callEvents (this=this@entry=0x160738 <worldEventManager>, eventType=eventType@entry=bz_eRawChatMessageEvent, eventData=eventData@entry=0x7effe7d8) at WorldEventManager.cxx:94 #3 0x000d079e in sendChatMessage (srcPlayer=srcPlayer@entry=0 '\0 |
| 21:24.22 | Agatha | happens when send a message with chathistory plugin enabled |
| 21:24.51 | Agatha | The OS is pretty standard: Ubuntu 16.04. It's an ARM archietcture, though. |
| 21:35.38 | blast007 | are you using your compiled bzfs or the one from the package manager? |
| 22:20.15 | Agatha | compiled |
| 22:35.38 | blast007 | well, you're loading the plugins from the package manager version, so I can't imagine that going well |
| 22:35.55 | blast007 | notice the /usr/lib/bzflag-server/chathistory.so above |
| 23:04.33 | Agatha | ah yes, that does make sense |