00:22.21 | Ressy | my poor back |
00:22.27 | Ressy | I just wanted to go to chiro on saturday. |
00:22.54 | Torhal | Why didn't you? |
00:24.46 | Ressy | closed because its a long weekend. today was a holiday |
00:36.04 | Torhal | Ah |
00:44.29 | *** join/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net) |
00:44.29 | *** mode/#arl [+v pompy] by ChanServ |
07:35.42 | sidji | moin |
09:41.19 | Torhal | Yola |
12:27.52 | *** part/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net) |
13:05.31 | *** join/#arl Ressy (~Ressy@WoWUIDev/WoWAce/ARL/Ressy) |
13:05.31 | *** mode/#arl [+v Ressy] by ChanServ |
13:09.43 | Torhal | Ressy: Yola. |
13:10.25 | Torhal | Just pushed something to help with fixing https://www.wowace.com/addons/arl/tickets/1695-recipes-that-dont-exist/ |
13:10.42 | Torhal | [08:09:24] Repo:83a2f04: Add detection for invalid recipes when running a development build - when found, they will be removed so a new recipe dump will correct the issue. |
13:12.53 | Torhal | On my enchanter: https://www.dropbox.com/s/z5h4rynjxddzk2m/Screenshot%202016-08-02%2008.12.00.png |
13:13.37 | Torhal | Going to bed, now. |
14:06.36 | Ressy | how do you know about invalid recipes? |
15:59.54 | Torhal | Ressy: As I iterate through all of the recipeID entries in the list of IDs I get from C_TradeSkillUI, I tag each corresponding recipe in professionRecipes with recipe.isValidated = true |
16:00.13 | Torhal | After that, I iterate through the professionRecipes themselves and nuke the ones without the tag. |
16:00.53 | Torhal | And yes, I woke up about 10 minutes ago. |
16:09.41 | Ressy | geez |
16:09.46 | Ressy | You got like no sleep |
16:09.53 | Torhal | Indeed :/ |
16:11.21 | Ressy | so it gets everything via the UI, then checks if its displayed |
16:11.41 | Torhal | Pretty much. |
16:11.47 | Ressy | mkay. |
16:12.02 | Ressy | So I've got stuff to do tonight in taking them out of the database, and adding them to the blacklist |
16:15.22 | Ressy | Wanna hear the funniest thing? |
16:15.38 | Ressy | One of the enchanting recipes.. |
16:15.43 | Ressy | in the UI.. |
16:15.46 | Ressy | I had to blacklist. |
16:15.57 | Ressy | Because it's not actually available from the source blizzard says it is |
16:16.29 | Ressy | 2 actually. I made notes in the blacklist list about them. |
16:41.42 | Torhal | [11:12:02] +Ressy:So I've got stuff to do tonight in taking them out of the database, and adding them to the blacklist <-- No. |
16:42.06 | Torhal | They're taken out of the DB by the scan, because they aren't in the default UI. |
16:42.29 | Ressy | But they're in the database or they wouldn't be showing up |
16:43.01 | Torhal | Yeah, but they don't need to be added to the blacklist. The blacklist is for shit the UI erroneously tells us about. |
16:43.21 | Ressy | UI erroneously tells me theres 2 recipes live, when they're not. |
16:43.34 | Torhal | Yes |
16:43.39 | Ressy | when they never made it out of beta. |
16:43.39 | Torhal | That is what the blacklist is for. |
16:43.41 | Ressy | Like those ones. |
16:44.00 | Torhal | The ones that are being auto-removed are being done so because the default UI has no record of them. |
16:44.17 | Torhal | So they don't need blacklisting |
16:44.36 | Ressy | The problem is, I'm not doing dumps except with the original skeleton entries. |
16:44.41 | Ressy | Cuz if I go hit up vendors... |
16:45.04 | Ressy | Theres 3 different ranks of many profession recipes. |
16:45.09 | Torhal | Yes |
16:45.09 | Ressy | It'll add the vendor to all 3. |
16:45.14 | Torhal | That is taken into account now. |
16:45.15 | Ressy | it can't distinguish . |
16:45.18 | Torhal | Oh |
16:45.22 | Ressy | yeah |
16:45.28 | Torhal | That's different but irrelevant, |
16:45.35 | Ressy | So I'm doing it by hand |
16:45.39 | Ressy | Which is why it's taking so long. |
16:46.07 | Ressy | And with the database.. |
16:46.09 | Torhal | The blacklist is for stuff the UI knows about but is wrong for whatever reason. Adding stuff to the blacklist that the UI doesn't know about is WAT. |
16:46.20 | Ressy | I'm doing (1 star) v (2 stars) (3 stars) |
16:46.48 | Ressy | I've been adding stuff to the blacklist which never went live |
16:46.54 | Torhal | Yes |
16:46.57 | Ressy | which never showed up on live, but is still in UI. |
16:47.03 | Ressy | And 2 recipes which SAY are live, but aren't |
16:47.07 | Torhal | The UI still "knows" about that stuff, which is WHY it needs blacklisting. |
16:47.23 | Ressy | Those are the only ones I've been blacklisting. |
16:47.28 | Torhal | This stuff, the stuff being removed, the UI is saying "I don't know what the fuck that is" |
16:47.38 | Torhal | So it does NOT need blacklisting. |
16:47.42 | Ressy | mkay. |
16:47.49 | Ressy | Probably previously on beta, but never made it live? |
16:47.57 | Ressy | considering its 6.0 stuff |
16:47.58 | Torhal | And didn't stick around in records, I guess. |
16:48.00 | Ressy | Or it was removed. |
16:48.18 | Torhal | The spells are obviously still in existence, because they have names |
16:48.23 | Ressy | ya |
16:48.26 | Torhal | But the TradeSkillUI doesn't count them at all. |
16:49.27 | Torhal | That's the only way I was able to find those extra "recipes" that guy had in the ticket. |
16:50.12 | Torhal | All off the ones that were in that ticket were removed in my screenshot |
16:50.23 | Ressy | mkay.. |
16:50.29 | Ressy | so how is it removed. |
16:50.40 | Ressy | Are they still in the database or does it just say "I'm not showing them anymore." |
16:51.43 | Torhal | [08:12:53] @Torhal:On my enchanter: https://www.dropbox.com/s/z5h4rynjxddzk2m/Screenshot%202016-08-02%2008.12.00.png |
16:51.50 | Torhal | Last line |
16:52.00 | Ressy | ah |
16:52.02 | Ressy | alright then. |
16:52.16 | Ressy | Well, I'd rather not do a dump, because I'm actively working on Enchanting. |
16:52.28 | Torhal | That's why it provides the other info. |
16:52.32 | Ressy | nods |
16:52.33 | Ressy | perfect |
16:52.55 | Ressy | I'll manually remove them tonight and push an update. |
16:53.43 | Torhal | Here's another commit: |
16:53.45 | Torhal | Add IsRecipeInfoLearnedByDescendant and IsRecipeInfoUnlearnedByAncestor helpers to ignore irrelevant recipe ranks, since the information is now available via C_TradeSkillUI. |
16:56.29 | Ressy | awesome |
16:56.38 | Ressy | I'll go through and remove the previousrankid stuffs |
16:57.13 | Torhal | So now the code reads as |
16:57.21 | Torhal | if learned then |
16:57.27 | Torhal | <PROTECTED> |
16:57.31 | Torhal | elseif IsRecipeInfoLearnedByDescendant(recipeInfo) or IsRecipeInfoUnlearnedByAncestor(recipeInfo) then |
16:57.31 | Torhal | recipe:AddState("IGNORED") |
16:57.31 | Torhal | else |
16:57.31 | Torhal | recipe:RemoveState("KNOWN") |
16:57.32 | Torhal | recipe:RemoveState("LINKED") |
16:57.33 | Torhal | end |
17:01.16 | Ressy | Mkays. |
17:01.31 | Ressy | Added 2 asana tasks for myself so I remember everything that needs done. |
17:03.25 | Torhal | :D |
17:12.52 | *** join/#arl Thaoky (~thaoky@59.107-240-81.adsl-dyn.isp.belgacom.be) |
17:13.57 | Ressy | You can set them up for me. :P |
17:22.57 | Torhal | I can do what, now? |
17:33.02 | Torhal | Back to bed. |
17:49.38 | sidji | at 7:30 pm? |
18:12.40 | Ressy | lol. You're also 6 hrs ahead of him, and his schedule has been wonky. |
18:12.53 | Ressy | err, 7 hrs ahead of him. |
23:12.43 | *** join/#arl Ressy (Ressy@192-0-172-185.cpe.teksavvy.com) |
23:12.43 | *** join/#arl Ressy (Ressy@WoWUIDev/WoWAce/ARL/Ressy) |
23:12.43 | *** mode/#arl [+v Ressy] by ChanServ |
23:14.42 | Ressy | Um Torhal |
23:14.44 | Ressy | Whatever you did... |
23:15.02 | Torhal | Ressy: Time to throw in the towel on ARL, apparently. "Now that Blizz baked this into the UI on the default professions tab, what does this addon do now that is not done in the Blizz default UI? Great addon, been using it since 2008, but not sure if it's needed now." |
23:15.03 | Ressy | Its no longer making skeleton entries for spells in the UI |
23:15.15 | Ressy | Says who? |
23:15.35 | Torhal | Some dude in comments on mods.curse.com |
23:15.44 | Ressy | o.O |
23:15.52 | Torhal | How do you know it isn't creating skeleton entries anymore? |
23:16.00 | Ressy | Cuz I just tried it with enchanting? |
23:16.02 | Torhal | Did for me this morning. |
23:16.11 | Torhal | Not enchanting, cooking I think. |
23:16.20 | Ressy | I'm trying with enchanting. |
23:16.26 | Ressy | and theres 18 to be made. |
23:16.29 | Ressy | none of which were. |
23:16.41 | Torhal | Example? |
23:16.56 | Torhal | I didn't touch the skeleton code, BTW. |
23:16.59 | Torhal | So... |
23:17.01 | Torhal | ¯\_(ã)_/¯ |
23:17.19 | Ressy | Welp... |
23:17.22 | Ressy | Its not making them. |
23:18.17 | Ressy | lemme push all my changes. |
23:18.21 | Ressy | and you can open enchanting. |
23:18.34 | Ressy | And because you didn't put it on the guild panel, you'll need an enchanting char. |
23:19.59 | Torhal | I have one. That's how I gave you that screenshot... |
23:20.06 | Ressy | k |
23:20.16 | Ressy | lemme push Core updates and then my enchanting changes |
23:20.25 | Ressy | Trying to do localizations and its hanging |
23:24.34 | Ressy | pushed both |
23:25.42 | Ressy | Its pulling Retired recipes out. |
23:26.46 | Ressy | all 5 Engineering ones are retired. |
23:27.47 | Torhal | Easy fix. |
23:28.22 | Ressy | I commented out a TON of recipes in Engineering.. |
23:28.26 | Ressy | Cuz they were just skeletons. |
23:28.32 | Ressy | It recognized they weren't in the db |
23:28.40 | Ressy | but it didn't print the skeleton entries in the dump |
23:29.30 | Torhal | BRB, moar coffee. |
23:30.40 | Ressy | heh |
23:30.40 | Ressy | k |
23:31.53 | *** join/#arl pompy (~Mike@c-50-182-137-173.hsd1.nj.comcast.net) |
23:31.53 | *** mode/#arl [+v pompy] by ChanServ |
23:34.09 | Torhal | Ressy: Do me a favor, please; check whether or not those retired recipes' items are still obtainable at all, even from AH. The fact that the default UI doesn't know anything about them tells me they've likely been completely removed from the game, since I'm grabbing ALL the IDs, which is the reason we even need a blacklist to begin with. |
23:38.57 | Ressy | mkay. |
23:39.08 | Ressy | I'm more worried about the new legion stuff that its not even making skeleton entries for |
23:39.14 | Ressy | which will be obtainable in a few weeks. |
23:39.38 | Ressy | But, Retired means unobtainable. |
23:40.42 | Torhal | Actually, Retired was supposed to mean "This was removed from the game for all intents and purposes, but it's still possible to get it if you find someone who has the recipe item." |
23:40.52 | Torhal | Now it's "Lol, this used to exist." |
23:41.15 | Torhal | We shouldn't be tracking anything that isn't current; the purpose is to help people get things they're missing, not show them things they can never have. |
23:41.49 | Ressy | I'm more concerned about it not creating entries for things that do exist and will be obtainable. |
23:42.00 | Torhal | Though there may be a reasoning behind the current behavior I'm not grasping because I'm very tired and half asleep. |
23:42.16 | Torhal | Yeah, I'll look at it. |
23:42.20 | Ressy | ty <3 |
23:42.38 | Torhal | But if the retired stuff is still obtainable, I need to figure out why the default UI has no damn clue about it. |
23:42.46 | Torhal | Because that would be a weird false-positive. |
23:42.47 | Ressy | I'll double check them. |
23:42.57 | Ressy | I know that some of them aren't obtainable still. |